From: John Hubbard <jhubbard@nvidia.com>
To: Pedro Falcato <pfalcato@suse.de>,
David Hildenbrand <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Jan Kara <jack@suse.cz>, Lorenzo Stoakes <ljs@kernel.org>,
Peter Xu <peterx@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Kiryl Shutsemau <kas@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kairui Song <kasong@tencent.com>, Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Baoquan He <baoquan.he@linux.dev>,
Michal Hocko <mhocko@kernel.org>,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH RFC 0/5] mm: GUP dirty + ->release_folio() fixes
Date: Thu, 19 Nov 2026 16:55:30 -0800 [thread overview]
Message-ID: <4f096d70-6f94-4148-8f47-242b8551e5f9@nvidia.com> (raw)
In-Reply-To: <20261119-gup-dirty-what-v1-0-236d69f25c24@suse.de>
On 11/19/26 12:10 PM, Pedro Falcato wrote:
> Sooo.... It turns out GUP dirty and ->release_folio() interact really
> weirdly. This was initially reported by some AI agent, and David let me
> know.
>
> The basic issue is:
The basic issue is covered in a series of LWN articles that span 5 or
6 years:
https://lwn.net/Kernel/Index/#Memory_management-get_user_pages
Probably good to read and absorb that. There's a lot.
The problem remains not fully solved. pin_user_pages() is a building
block, but we need to fully coordinate with filesystems in order to
finish. It's good that you are looking at this.
> - ->dirty_folio() relies on buffers/IFS/etc being attached to the
> folios. It _cannot_ attach them itself, as dirty_folio() cannot
> block.
> - certain MM paths (reclaim, khugepaged, folio split, etc) are very
> trigger-happy when it comes to asking filesystems to release them. In
> most cases, barring any dirty folios, buffers, it will just drop
> them.
> - there is no problem in usual IO submission, but issues start to pop
> up with GUP, where the code flow (roughly) becomes:
> [get_user_pages(), etc]
> ->page_mkwrite() called here, or before
> ->private correctly populated with whatever the filesystem
> expects.
> folio is marked as dirty, initially.
> *write finishes*
> folio_lock();
> folio_mark_dirty();
> ->dirty_folio()
> dirty_folio expects ->private to be populated by
> ->page_mkwrite(), ->write_begin().
> folio_unlock();
>
> What happens if any filemap_release_folio() runs (and succeeds) between
> the initial dirtying (plus eventually writeback) and the write to the
> folio completes? Welp, it's unpredictable. ext4 for example will
> WARN_ONCE, and likely drop data (see ext4_dirty_folio()).
>
> So, what can we do about it? It's complicated, hence why this is an RFC.
> For the possible solutions:
> - ->dirty_folio() attaching this FS information itself is not really
> possible in many cases. ->dirty_folio() can't block, nor is it even
> guaranteed to hold the folio lock while being called.
> - Can pincount help? Kind of. Things like folio_maybe_dma_pinned() are
> rough, and don't deal with the usage of get_user_pages(FOLL_WRITE).
> pincount itself isn't available in the common order-0 case, and not
> available on order-1 as well on 32-bit, but who cares about that^W^W^W^W^W
> - Could get_user_pages() ban FOLL_WRITE? Mayhaps. I would not be
> opposed to that, but that's probably a larger change than ideal for stable,
> and I'm not familiar enough with GUP requirements to decide to go that way.
> This would require migrating all FOLL_WRITE users to
> pin_user_pages().
> - Can the whole system be reworked? Probably, but not for stable.
>
> This patch series is really rough but kind-of works. Instead of using
> folio_maybe_dma_pinned(), which only interacts with pin_user_pages(), I
pin_user_pages() was specifically introduced for this exact class of
problem. get_user_pages() is now meant for other, much more limited cases.
I've attempted to document that, here:
https://docs.kernel.org/core-api/pin_user_pages.html
> introduce a new helper that helps places deal with the folio refcount
> directly. In that case, we can also deal with GUP. On the other end,
> moar problems:
> - NFS private data itself takes refs on folios. Now private data (that
> we could perhaps release if only we tried) is keeping us from
> releasing that same data. What?
> - ext4 data=journal has some funky usage of buffer_heads. Data journalled
> filesystems will not, in any way, dirty BHs. Instead it will,
> *only if it was DMA pinned*, set the checked flag. ext4 skips
> dropping those buffers if the checked flag is set.
> - ext4 move_extents seems to have suspicious usage of
> filemap_release_folio() as well.
>
> Many of these have suspicious Fixes: (which are definitely wrong). I
> targeted these patches to complement Jan's original fix. Anything before
> that (or which is missing that patch) is hopelessly broken anyway.
> Proper Fixes: can be added, but many of them go back quite far.
>
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>
> ---
> Pedro Falcato (5):
> mm/khugepaged: fix filemap_release_folio() interaction with GUP dirty
> mm/huge_memory: fix filemap_release_folio() interaction with GUP dirty
> mm/vmscan: avoid releasing FS metadata for !FOLL_PIN gup folios
> mm/vmscan: be more careful when releasing FS metadata if buffer_heads_over_limit
> mm/filemap: refuse releasing maybe_dma_pinned folios
>
> mm/filemap.c | 3 +++
> mm/huge_memory.c | 22 +++++++++++-----------
> mm/internal.h | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> mm/khugepaged.c | 19 +++++++++++++------
> mm/vmscan.c | 18 ++++++------------
> 5 files changed, 81 insertions(+), 29 deletions(-)
> ---
> base-commit: 9663aa0da7070d958e333477ce0720512e9fa016
> change-id: 20261116-gup-dirty-what-b73da748f5d1
A git alias to wrap "git format-patch" with a sed(1) invocation is a great way
to avoid accidentally "leaking" gerrit change-id's into a posting, fwiw.
thanks,
--
John Hubbard
prev parent reply other threads:[~2026-11-20 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 20:10 Pedro Falcato
2026-11-19 20:10 ` [PATCH RFC 1/5] mm/khugepaged: fix filemap_release_folio() interaction with GUP dirty Pedro Falcato
2026-11-19 20:10 ` [PATCH RFC 2/5] mm/huge_memory: " Pedro Falcato
2026-11-19 20:10 ` [PATCH RFC 3/5] mm/vmscan: avoid releasing FS metadata for !FOLL_PIN gup folios Pedro Falcato
2026-11-19 20:10 ` [PATCH RFC 4/5] mm/vmscan: be more careful when releasing FS metadata if buffer_heads_over_limit Pedro Falcato
2026-11-19 20:10 ` [PATCH RFC 5/5] mm/filemap: refuse releasing maybe_dma_pinned folios Pedro Falcato
2026-11-20 0:55 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f096d70-6f94-4148-8f47-242b8551e5f9@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baoquan.he@linux.dev \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®