From: Lukasz Luba <lukasz.luba@arm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] thermal: gov_step_wise: Clarify cooling logic description comment
Date: Thu, 4 Sep 2025 08:22:31 +0100 [thread overview]
Message-ID: <4f0c03aa-bdb5-4a30-b81c-59e0e68313be@arm.com> (raw)
In-Reply-To: <4690596.LvFx2qVVIh@rafael.j.wysocki>
On 8/25/25 14:28, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The cooling logic description comment next to the get_target_state()
> definition is slightly ambiguous in what it means by "lower cooling
> state", so clarify that by replacing the ambuguous phrase with "the
> minimum applicable cooling state".
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/thermal/gov_step_wise.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/thermal/gov_step_wise.c
> +++ b/drivers/thermal/gov_step_wise.c
> @@ -23,8 +23,8 @@
> * b. if the trend is THERMAL_TREND_DROPPING, do nothing
> * If the temperature is lower than a trip point,
> * a. if the trend is THERMAL_TREND_RAISING, do nothing
> - * b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
> - * state for this trip point, if the cooling state already
> + * b. if the trend is THERMAL_TREND_DROPPING, use the minimum applicable
> + * cooling state for this trip point, or if the cooling state already
> * equals lower limit, deactivate the thermal instance
> */
> static unsigned long get_target_state(struct thermal_instance *instance,
>
>
>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
next prev parent reply other threads:[~2025-09-04 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 13:26 [PATCH v2 0/3] thermal: gov_step_wise: Two cleanups and small adjustment Rafael J. Wysocki
2025-08-25 13:27 ` [PATCH v2 1/3] thermal: gov_step_wise: Clean up local variable initialization Rafael J. Wysocki
2025-09-04 7:21 ` Lukasz Luba
2025-08-25 13:28 ` [PATCH v2 2/3] thermal: gov_step_wise: Clarify cooling logic description comment Rafael J. Wysocki
2025-09-04 7:22 ` Lukasz Luba [this message]
2025-08-25 13:31 ` [PATCH v2 3/3] thermal: gov_step_wise: Allow cooling level to be reduced earlier Rafael J. Wysocki
2025-09-04 7:32 ` Lukasz Luba
2025-09-04 13:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f0c03aa-bdb5-4a30-b81c-59e0e68313be@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®