From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 197FC25B097 for ; Fri, 22 May 2026 12:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779454533; cv=none; b=j5cCSSRpICjMYUgvs78N1+257VpHbbM2bv9s/4ZNoUTNJqXq9IA3XltSFjOpGhIv2jIYSZugPc+MTOc2rdHb2A9N+PN+XVWVAfhh9S3jYARR9aejMXcyiGBxSeTrDIKsw0mxZWCkiRWX+Olk0T7yeur0ucuiGkz6qNx2Y5M7nTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779454533; c=relaxed/simple; bh=u8mby+ACV+TL9s2LmGmx/0ThG5WU2JXLP4YTWNGA65E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bzTdXt3pVkaSS06BVISr1/1P/cqWgT5yh1M12VSN9GGGyUYBfqf0VLVk68xBI7zizflzYSObk+Junl8OBzQ8GWb0EUtar7iVM8XpQmdQXglHOmAHJGjae5RzKnER5ake5wMMGcOGdyPp645eSPznN/a/QoX9nVhRPDMCYE4HxZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TzqNSWgv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZLDswXBY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TzqNSWgv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZLDswXBY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MCDfFp1958947 for ; Fri, 22 May 2026 12:55:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vQf00yxj1a0MPHiIn8srCpzB81v5fEQ8XVgKIoxl6Ao=; b=TzqNSWgvN/dh7B5l YQ4fT2PVuWWQgv9gXTGx/uFmq6v6Qh7wfrF/D08CTEm4w7Rw/qG+KrPI131vk9Qy r5ZxQ0QYx9kRN+3TUJvV6WIIVd5u1J/B2zghNLPgtDdd3drhjjd9/1HGzd0ifUvW QJ4bP7uhXsxTkkd6UeG4L8PY/DlQr4U6CwLETqzg29udZyJ2EvfuMLclCNo233nT lqRNkwMa0IruFx0wAczCgHPqOULIXGLTtj83WXiERlR+nnTOwpe26eWvvITKKA9Z G+ROjYlZW5NmezXwNR3KeiXts/SfANiGcvKPKy+T34O4ESaxZSwwC7jVmXpVqHHd Sh4YSQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eahxesjbr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 12:55:31 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2baf7748d0aso72269165ad.1 for ; Fri, 22 May 2026 05:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779454530; x=1780059330; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vQf00yxj1a0MPHiIn8srCpzB81v5fEQ8XVgKIoxl6Ao=; b=ZLDswXBYnu7EcM/aYNagK7yqHmaCp3ZgUKKy3zqHIBMRIJEZKsdu40Zf8PNx2OdgId WZMOox/ji1ufvzE61WJUVoWaIYaOI3r5gd2XSLBUHn56aJJX8vkaG4SUQ0NuMoyEBOin uxfNVi4XhGUnUvrkNV45ZU1aYvsMR4FnT5CuUVqNjV9Jgy+ACzXK4l8PH90nWWHmsRLT 9k2+unLYaTf9NwzfQ0jC8Lo4w5UPRKbcL3KnJzjYjCqc2vC/aZODA5eA+HWtc5iAFyHi 90QmFmy8V3C25WDCcgja4Lr8/QvhyVtDH0m7XGI4QrmJSiIUYmmc8vn9qxbG3YZ9aE65 huDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779454530; x=1780059330; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vQf00yxj1a0MPHiIn8srCpzB81v5fEQ8XVgKIoxl6Ao=; b=FlXes4mupd0XgWp1hXabbafE5ou2Fxz/Bs6yqfLlpBZbE8LcJWyaR3Nw96cbxYDJAE JmSS4gL9/afYsijbvoghv62ol6XLsrKRnSTQi3Qecplfnbs+0W6z2a/zlYwAa0deqLOd +lbv1pV2UW08ng/WU06ytBYHhd9hc5jcDZywyB2zHkEVRFjNUTsFS0adLcEbwpXXqwQR idH4vFyc//C1/fnR8u9fkkeCUj2QaWhJM1VUtaeotbVIQTiBsHLBGPqx22u4QD5HuYs/ Rq1cnchA0vW+/0at6G7ZY+T0VxH1+eR9l94VQ7sHbcjeOPJd9GR5iLMLnZH6EeO71CXu zolA== X-Forwarded-Encrypted: i=1; AFNElJ+OGVXt2RRfzvOIWkuofExC4PY1Vq165J8fsfo7El/cROnQFvYd1krxi5r7bFX8PzKcDpe/7fgGsKWi95c=@vger.kernel.org X-Gm-Message-State: AOJu0YzwA3oFcyw9tWKZyYLtW71zA5EITrOityaGTm3/nwGKD45pABQZ k6DDbOeDvrzRVckkAPlplPFPsgImSvZp6vYaxJXjFjD9ZpvFg0HPWIvIHgJegGHJ2QBzgWyum7o Wsl7uFmtX0pPr1ccqpu3ypF5metL6gN6Zih44rrcz54rC5plYvEbz2O7heGTHdEAkA7A= X-Gm-Gg: Acq92OHwvcWzHIDZPC0lfCrS8zJ4S1tepj7iNJO5Besv+j/TDj9Qq9/XR+y/qwbEkfM r6JxIiz2Gke2RBZF7xac3Zz4M0Xk0smO8RWB9JFONvlcBL+TGBJxBVJB+98Mix7d+LcTc4sNLYm H+xQXwvocah4FvGeQIB4qohYgGRcsokW77xFFwI0Ad56ddVYqTJ3lhVvfEujtU2A/mP+p9uAZmT MJIreA2R5AEu2KwiWk7c7xAkXNUXMa0yCVffNDDRuBeD2oDGuEIuuxc/83HBFRcZITQbnmu5OZo vQ/QbFm2o8BMPh4NzY2Yw1KFlLJZXgr2hu9jNQZa2N7VsxLb9iBMkmXP+pjcyl9rYb6VyXuLXMC EftoMSIpjlvaQwEZLm7ujbXL6iee+t6iDu77fA2z1o+BqD+dMSA== X-Received: by 2002:a17:903:11ce:b0:2be:3434:4e28 with SMTP id d9443c01a7336-2beb062c567mr34301675ad.19.1779454530115; Fri, 22 May 2026 05:55:30 -0700 (PDT) X-Received: by 2002:a17:903:11ce:b0:2be:3434:4e28 with SMTP id d9443c01a7336-2beb062c567mr34301395ad.19.1779454529589; Fri, 22 May 2026 05:55:29 -0700 (PDT) Received: from [10.219.49.212] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56b5886sm15757695ad.20.2026.05.22.05.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 05:55:29 -0700 (PDT) Message-ID: <4f0dd486-979a-472f-8d9b-37c1f10e3850@oss.qualcomm.com> Date: Fri, 22 May 2026 18:25:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Konrad Dybcio , Mark Brown Cc: Srinivas Kandagatla , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260518081738.2453957-1-ajay.nandam@oss.qualcomm.com> <20260518081738.2453957-2-ajay.nandam@oss.qualcomm.com> <1b499f23-213b-46d3-b4cc-3b5aae2cad7c@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <1b499f23-213b-46d3-b4cc-3b5aae2cad7c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDEyOCBTYWx0ZWRfX+xcbbPZZCmdU XIVZACiTY0qro0+vFeTZgJ7GVpYUZw2bInKh3iO7U5tjXg6k0JclVXP8WmAgY4u38ksCMu06dgI 8iGo9PBkspG37BSnNk6SjGqW9hYa8IFm7w1TukgQyygx75/dfw6SN5IBUq5GW2/uGByUzz6Eklp 0CuC07qpD9cP/YxbfW+6ES8zGiwHKXRelGsavToFwnoOUh+z+rtTum4LOsRC6UJc+3VM3PAR4YX x3UtQXRXVieiBXAMtenc1W5IFZiBulD3H3unmsR1bsa1HKmoaJKaWXCyV0R2QkMzkXdYmjoXBsJ Fv1KB+eEhIgdhZYOvW/MinifS5cvG3qpfQp8xV/9Ts5O0gmjj6wIG/onGHaTpdzfwKBy0oqzxxh m6mSjd3DnuAEp/3TtA9L+oeMufXTAdCV6o0mu1zMU/0Jkv3TyTyG+sMUv/FD4JN0Z2JpckNGSRG ja/xxaUw98YnXEYfLkQ== X-Proofpoint-GUID: dSLAkvavBhI3dbcBATboE_mOkgIKptH5 X-Proofpoint-ORIG-GUID: dSLAkvavBhI3dbcBATboE_mOkgIKptH5 X-Authority-Analysis: v=2.4 cv=ar2CzyZV c=1 sm=1 tr=0 ts=6a105243 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=jzy3uwMFAPkgEWCbuqQA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220128 On 5/22/2026 4:12 PM, Konrad Dybcio wrote: > On 5/19/26 4:33 PM, Mark Brown wrote: >> On Mon, May 18, 2026 at 01:47:36PM +0530, Ajay Kumar Nandam wrote: >>> Convert the LPASS WSA macro codec driver to use the PM clock framework >>> for runtime power management. >> >>> The driver now relies on pm_clk helpers and runtime PM instead of >>> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen >>> clocks. Runtime suspend and resume handling is delegated to the PM >>> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime >>> PM callbacks continue to manage regcache state. >> >>> + ret = devm_pm_clk_create(dev); >> >> The !PM_CLK stub for this just returns -EINVAL so if that's not enabled >> then none of the clocks will be enabled, the driver needs a dependency >> adding. > > This goes for both the drivers > > I don't think I have other comments with that fixed > > Konrad ACK, Thank you Thanks Ajay