From: Kaitao Cheng <kaitao.cheng@linux.dev>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R . Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Muchun Song <muchun.song@linux.dev>,
Priyanshu Kumar <priyanshukumarpu@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Muchun Song <muchun.song@linux.dev>
Subject: Re: [PATCH v2 0/3] memblock: Remove unused exact nid allocation API
Date: Mon, 12 Oct 2026 11:06:01 +0800 [thread overview]
Message-ID: <4f0e115f-0826-4139-a6a2-30e4520f33bc@linux.dev> (raw)
In-Reply-To: <179023613121.508753.1739135911194499722.b4-review@b4>
在 2026/9/24 15:48, Mike Rapoport 写道:
> Hi,
>
>> Commit ffe55393137c ("mm/sparse: remove sparse buffer pre-allocation
>> mechanism") removed the only memmap_alloc() caller that requested an
>> allocation from an exact NUMA node. All remaining callers allow fallback
>> to other nodes, leaving the exact_nid argument unused.
>
> Overall this looks good to me. There's is an issue though that mentioning
> commit in mm-unstable in the changelog does not really work because the
> commit sha may change.
Commit ffe55393137c was already merged into Linus's tree on June 19,
via a552c81ff4a1, so its SHA is stable.
> Andrew, how do you suggest to deal with it?
>
--
Thanks
Kaitao Cheng
prev parent reply other threads:[~2026-10-12 3:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 13:53 Kaitao Cheng
2026-09-19 13:53 ` [PATCH v2 1/3] mm: Remove unused exact_nid parameter from memmap_alloc() Kaitao Cheng
2026-09-19 13:53 ` [PATCH v2 2/3] memblock tests: Move exact nid tests to memblock_alloc_range_nid() Kaitao Cheng
2026-09-19 13:53 ` [PATCH v2 3/3] memblock: Remove unused memblock_alloc_exact_nid_raw() Kaitao Cheng
2026-09-24 7:48 ` [PATCH v2 0/3] memblock: Remove unused exact nid allocation API Mike Rapoport
2026-10-12 3:06 ` Kaitao Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f0e115f-0826-4139-a6a2-30e4520f33bc@linux.dev \
--to=kaitao.cheng@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=priyanshukumarpu@gmail.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®