From: Shuah Khan <skhan@linuxfoundation.org>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Philip Li <philip.li@intel.com>,
kernel test robot <lkp@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: be sure to make khdr before other targets
Date: Wed, 15 Sep 2021 10:37:48 -0600 [thread overview]
Message-ID: <4f193721-39fd-bcb1-1e14-253c60ab4961@linuxfoundation.org> (raw)
In-Reply-To: <20210915134554.19581-1-lizhijian@cn.fujitsu.com>
On 9/15/21 7:45 AM, Li Zhijian wrote:
> LKP/0Day reported some building errors about kvm, and errors message
> are not always same:
> - lib/x86_64/processor.c:1083:31: error: ‘KVM_CAP_NESTED_STATE’ undeclared
> (first use in this function); did you mean ‘KVM_CAP_PIT_STATE2’?
> - lib/test_util.c:189:30: error: ‘MAP_HUGE_16KB’ undeclared (first use
> in this function); did you mean ‘MAP_HUGE_16GB’?
>
> Although kvm relies on the khdr, they still be built in parallel when -j
> is specified. In this case, it will cause compiling errors.
>
> Here we mark target khdr as NOTPARALLEL to make it be always built
> first.
>
> CC: Philip Li <philip.li@intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> tools/testing/selftests/lib.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 7ee911355328..5074b01f2a29 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -48,6 +48,7 @@ ARCH ?= $(SUBARCH)
> # When local build is done, headers are installed in the default
> # INSTALL_HDR_PATH usr/include.
> .PHONY: khdr
> +.NOTPARALLEL:
> khdr:
> ifndef KSFT_KHDR_INSTALL_DONE
> ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
>
Thank you for the fix. Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/
fixes branch.
thanks,
-- Shuah
prev parent reply other threads:[~2021-09-15 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 13:45 Li Zhijian
2021-09-15 16:37 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f193721-39fd-bcb1-1e14-253c60ab4961@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=lkp@intel.com \
--cc=philip.li@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®