From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753274AbdK1RJe (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 12:09:34 -0500
Received: from merlin.infradead.org ([205.233.59.134]:56022 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753146AbdK1RJc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 12:09:32 -0500
Subject: Re: [PATCH] add missing "source" line for firmware subdirectory in
 drivers/Kconfig
To: Heiner Kallweit <hkallweit1@gmail.com>,
        Sudeep Holla <sudeep.holla@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <db202e46-8521-9514-e0e9-416fe90a7927@googlemail.com>
From: Randy Dunlap <rdunlap@infradead.org>
Message-ID: <4f19cd91-997e-45ef-309d-2d1b83ae632e@infradead.org>
Date: Tue, 28 Nov 2017 09:09:29 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <db202e46-8521-9514-e0e9-416fe90a7927@googlemail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/27/2017 11:12 PM, Heiner Kallweit wrote:
> I have a little bit of a hard time to find the right addressee for
> this patch because there is no maintainer entry for drivers/firmware.
> Can you apply the following through your tree?
> 
> Add missing entry for firmware subdirectory in drivers/Kconfig.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>]

Hi,
Why do you need this patch?  You should explain that in the (missing)
patch description.

I suppose that it could be done like this, but currently any $ARCH that
wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:

arch> grep firmware/Kconfig */Kconfig
arm/Kconfig:source "arch/arm/firmware/Kconfig"
arm/Kconfig:source "drivers/firmware/Kconfig"
arm64/Kconfig:source "drivers/firmware/Kconfig"
blackfin/Kconfig:source "drivers/firmware/Kconfig"
ia64/Kconfig:source "drivers/firmware/Kconfig"
mips/Kconfig:source "drivers/firmware/Kconfig"
x86/Kconfig:source "drivers/firmware/Kconfig"

so all of these would need to be removed.

> ---
>  drivers/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index 152744c5e..a506867d9 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
>  
>  source "drivers/firewire/Kconfig"
>  
> +source "drivers/firmware/Kconfig"
> +
>  source "drivers/macintosh/Kconfig"
>  
>  source "drivers/net/Kconfig"
> 


-- 
~Randy