From: YueHaibing <yuehaibing@huawei.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: <dmitry.torokhov@gmail.com>, <matthias.bgg@gmail.com>,
<chen.zhong@mediatek.com>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-input@vger.kernel.org>
Subject: Re: [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
Date: Mon, 10 Dec 2018 15:16:00 +0800 [thread overview]
Message-ID: <4f1a67e5-b735-f8bd-88b8-3a1ca590eba2@huawei.com> (raw)
In-Reply-To: <20181210061557.GL26661@dell>
On 2018/12/10 14:15, Lee Jones wrote:
> On Sun, 09 Dec 2018, YueHaibing wrote:
>
>> Remove duplicated include.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/input/keyboard/mtk-pmic-keys.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
>> index 02c67a1..5027ebb 100644
>> --- a/drivers/input/keyboard/mtk-pmic-keys.c
>> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
>> @@ -19,7 +19,6 @@
>> #include <linux/input.h>
>> #include <linux/interrupt.h>
>> #include <linux/platform_device.h>
>> -#include <linux/kernel.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> #include <linux/regmap.h>
>
> You are removing the wrong one.
No, linux/kernel.h is a duplicated include indeed.
>
> Please convert this patch's main intent to alphabetise the header
> files. Then you can remove any obvious duplicates.
I can alphabetize it in v2 if need be.
>
next prev parent reply other threads:[~2018-12-10 7:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 6:34 YueHaibing
2018-12-10 6:15 ` Lee Jones
2018-12-10 7:16 ` YueHaibing [this message]
2018-12-10 10:07 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f1a67e5-b735-f8bd-88b8-3a1ca590eba2@huawei.com \
--to=yuehaibing@huawei.com \
--cc=chen.zhong@mediatek.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®