From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A3E2FFF90 for ; Tue, 10 Feb 2026 05:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770703135; cv=none; b=KLhxNrgH5h1xGNBhK/tlgyZd8nU+8mDhk4aGCQkZodlCLA6Zyyt0NRjtO1BEo4RkX3MjM3oquatRgYYWHiw9EMQnXlS574v3zY24nuvp6KWskR/E20GYv4naZ//HgWT086kQDGt7o0fKq1Os3Xfk1cyxMcLZ8WnNAPQdged1hlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770703135; c=relaxed/simple; bh=nfuh6+izjFO8XKlIKCJxp3+e9ldOQyhtZbhKvPv8/ZA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZhxDKjFbWznUj+NvjBptIneYSKWq/qaqawzeM3MfnIBozDA0QIEtWme2zyEqwPnRApy7og1HnHzh3rSIy4htIocajHNxbuSFFOQkAe8/9Oc2sX4dguO+PQ8z1Vk1jesK11QmkUMApSHMNr8xRTO8Mm2BngJdzVBIn+eoe6P7Pak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qnUOGHsZ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qnUOGHsZ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48329eb96a7so16343175e9.3 for ; Mon, 09 Feb 2026 21:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770703133; x=1771307933; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=nfuh6+izjFO8XKlIKCJxp3+e9ldOQyhtZbhKvPv8/ZA=; b=qnUOGHsZZgQxZAHMS+3zoyEndKhWIN+PHzkDX8TkuIuCbdYI+7r3OhjQSr2cYNMQ2l RyK6JdTbcixDJYsh40EEHVzD92ko/0RbwqZby+5txvAhWWb4Hh3ZFY0H2575VbzQCrUC SgJY1DeAf1lwNpmBPPgyWAw7OR3K4OIyD08dwGIXBZneYcGZgJow6kZpcpJbu41PDYm1 U9d+Uq4K3+9zmhSJqsRfSpn+7eaVk2uok/sYXxNESngUXo8FkDvPfC1BR3Jpfn+s/tIg ZvKZVCkbsb5AUZF4cdJqzbCi7Z7m2RI23SsUGSoISCZ+yYlldCMCrQHCAym6iRjw0taM EDAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770703133; x=1771307933; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nfuh6+izjFO8XKlIKCJxp3+e9ldOQyhtZbhKvPv8/ZA=; b=oP7tFBsDsN88yt/NqY3oMTyxgNoZy+xJK+h7wRIVgTxMBHqaDEG6ULrOX84hG+PyaQ ehNHvuEC6VIbO6E3McCjiIKualFjffrvU5djM+3CRZxumh7W9aANHC5uzfcQJbdM5+GX DjwIS+FHYZLaEXq7pIFwVTWm5mIdgfGvcTV+BWQhx88XzIHYLeaUQv+4fU7iNBIV7zl4 ufPRf8/qKrWDP/gqG8ojjjSX9dIkoTJdStPPZeufNHevyXnIo6o/ZxAZpafBIw8mL3jL wIisfJWDQl2RL9xadoQ3s2WJ9VBIzu2FAl+e/XK+9/IXuY6tQVx0LB8XX7mHGNHT2n/B DB+A== X-Gm-Message-State: AOJu0YyaY5kjKza6ibz6ezLg2g+IDYIerIoUaRHp9LoWRJ0wDm7MnRz6 2g9LYby2bVwzfdA7p2wpvP1LcCftt1Yt5ap+c0SH0YA/28LOiCQMYgt9Dopm56t207Y= X-Gm-Gg: AZuq6aI/cFK0A9yVjq9rWpsiDDOcAl+atJNpCeh5HLyo4d9J/IwVlpZ32G/kAfFjZNd 6uBHgXLeYjrJc3E5mfB/burcFD2ImKhYrqIkN7Wrgn2a1wedu1Mk630mXHURElbAM1Ib2Q5Ds29 UXSGKURIOuY4Uxz0hmbuKtOFsxkHPBRgaPBQJxkRf/l8NwXpwHmbTc4lY2Els0IpCoRzI4n43ZA kQhdjE5OEPP8s1Znp/V+v+8t8TMWKFLF9nt0gvr6y3GcaqebZTcpqfYzZDZWJYWWtPGdB+StivK Qu9q94HS5PjQSVvjMXGku49UGB2Zm3u18FipJKgu3nJXBT6/XDiqqLdvGtQCyOhCYxjp/0CA4Ih bsCAgMxYhGfExE5HIAmt2Po9oDx5qd7h3Ht6tNpAXn4jZCDFKxUJk4VQTUzbz7lCY11SKjIjeQl xv0YwA7h8nead/D/VdbEf5+v8fpUair4D2HDXc7OH3 X-Received: by 2002:a05:600c:348a:b0:480:3ad0:93bf with SMTP id 5b1f17b1804b1-48320966729mr193678165e9.24.1770703132738; Mon, 09 Feb 2026 21:58:52 -0800 (PST) Received: from draszik.lan ([212.129.79.225]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d482480sm39954985e9.0.2026.02.09.21.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 21:58:52 -0800 (PST) Message-ID: <4f1b1d857c0ee17436cd61e97219f508bd89f917.camel@linaro.org> Subject: Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb() From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Dan Carpenter Date: Tue, 10 Feb 2026 05:59:20 +0000 In-Reply-To: <170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org> References: <20260209-s2mpg1x-regulators-fixes-v1-0-ead348e64e14@linaro.org> <20260209-s2mpg1x-regulators-fixes-v1-1-ead348e64e14@linaro.org> <170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof, On Mon, 2026-02-09 at 17:09 +0100, Krzysztof Kozlowski wrote: > On 09/02/2026 16:07, Andr=C3=A9 Draszik wrote: > > The sanity checks being removed in this commit are useless as earlier > > code checks for out-of-bounds conditions already. They also are > > incorrect (as they're off-by-one). > >=20 > > Simply remove this incorrect code. > >=20 > > No functional change. >=20 > If they are incorrect then how it could be "no functional change"? To me > original code looks buggy and this is a fix. Fix must have functional > change... Earlier code already checks for all conditions, including all error cases. So the code being removed here has no effect, as any potential error it could catch will already have been caught by earlier code. Removing it therefore doesn't change behaviour or functionality. I can reword to 'incomplete test' instead of 'incorrect code' if you think that's more clear? Cheers, Andre'