From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
John Garry <john.garry@huawei.com>,
Kajol Jain <kjain@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 15/15] perf vendor events intel: Add metricgroup descriptions for all models
Date: Tue, 16 May 2023 13:53:56 -0400 [thread overview]
Message-ID: <4f1e2e31-4efd-ba94-18e5-e53189429d9b@linux.intel.com> (raw)
In-Reply-To: <20230515215844.653610-16-irogers@google.com>
On 2023-05-15 5:58 p.m., Ian Rogers wrote:
> Add metric group descriptions created by:
> https://github.com/intel/perfmon/blob/main/scripts/create_perf_json.py
> The descriptions add some additional detail in perf list.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> .../arch/x86/alderlake/metricgroups.json | 122 ++++++++++++++++++
> .../arch/x86/alderlaken/metricgroups.json | 26 ++++
> .../arch/x86/broadwell/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/broadwellde/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/broadwellx/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/cascadelakex/metricgroups.json | 114 ++++++++++++++++
> .../arch/x86/haswell/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/haswellx/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/icelake/metricgroups.json | 113 ++++++++++++++++
> .../arch/x86/icelakex/metricgroups.json | 114 ++++++++++++++++
> .../arch/x86/ivybridge/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/ivytown/metricgroups.json | 107 +++++++++++++++
> .../arch/x86/jaketown/metricgroups.json | 100 ++++++++++++++
> .../arch/x86/sandybridge/metricgroups.json | 100 ++++++++++++++
> .../arch/x86/sapphirerapids/metricgroups.json | 118 +++++++++++++++++
> .../arch/x86/skylake/metricgroups.json | 113 ++++++++++++++++
> .../arch/x86/skylakex/metricgroups.json | 114 ++++++++++++++++
> .../arch/x86/tigerlake/metricgroups.json | 113 ++++++++++++++++
> 18 files changed, 1896 insertions(+)
> create mode 100644 tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/alderlaken/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/broadwell/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/broadwellde/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/broadwellx/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/cascadelakex/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/haswell/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/haswellx/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/icelake/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/icelakex/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/ivybridge/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/ivytown/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/jaketown/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/sandybridge/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/sapphirerapids/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/skylake/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/skylakex/metricgroups.json
> create mode 100644 tools/perf/pmu-events/arch/x86/tigerlake/metricgroups.json
>
> diff --git a/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json b/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json
> new file mode 100644
> index 000000000000..273ccfb0ed6f
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/x86/alderlake/metricgroups.json
> @@ -0,0 +1,122 @@
> +{
> + "Backend": "Grouping from metrics spreadsheet",
> + "Bad": "Grouping from metrics spreadsheet",
> + "BadSpec": "Grouping from metrics spreadsheet",
> + "BigFoot": "Grouping from metrics spreadsheet",
> + "BrMispredicts": "Grouping from metrics spreadsheet",
> + "Branches": "Grouping from metrics spreadsheet",
The description "Grouping from metrics spreadsheet" seems meaningless,
and may bring confusion information, e.g., what is metrics spreadsheet?
I think it may be better to leave it empty if we don't have a proper
description for the metricgroup.
Other descriptions look good to me.
Thanks,
Kan
next prev parent reply other threads:[~2023-05-16 17:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 21:58 [PATCH v1 00/15] Event, metric and metric group improvements Ian Rogers
2023-05-15 21:58 ` [PATCH v1 01/15] perf vendor events intel: Update alderlake events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 02/15] perf vendor events intel: Update broadwell variant events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 03/15] perf vendor events intel: Update cascadelakex events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 04/15] perf vendor events intel: Update elkhartlake events Ian Rogers
2023-05-15 21:58 ` [PATCH v1 05/15] perf vendor events intel: Update haswell(x) metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 06/15] perf vendor events intel: Update icelake/icelakex events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 07/15] perf vendor events intel: Update ivybridge/ivytown metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 08/15] perf vendor events intel: Update jaketown metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 09/15] perf vendor events intel: Update sandybridge metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 10/15] perf vendor events intel: Update sapphirerapids events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 11/15] perf vendor events intel: Update skylake/skylakex events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 12/15] perf vendor events intel: Update snowridgex events Ian Rogers
2023-05-15 21:58 ` [PATCH v1 13/15] perf vendor events intel: Update tigerlake events/metrics Ian Rogers
2023-05-15 21:58 ` [PATCH v1 14/15] perf jevents: Add support for metricgroup descriptions Ian Rogers
2023-05-15 21:58 ` [PATCH v1 15/15] perf vendor events intel: Add metricgroup descriptions for all models Ian Rogers
2023-05-16 17:53 ` Liang, Kan [this message]
2023-05-16 18:19 ` Ian Rogers
2023-05-16 21:41 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f1e2e31-4efd-ba94-18e5-e53189429d9b@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome