From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48A5C2620C3 for ; Mon, 20 Oct 2025 14:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760970369; cv=none; b=Qh7TWp9TdAnS9nahOeAO/b4RRAmQ6XcSDbLdk3upC+wUdbZqxqaRZBBwgzovXQXfUGvIE2zo/DDc6cZUd+cQGRE0VoVvZcQ1cxQ7DkRpn8cvVd6IFRifHBS/RNd6hvTfbZpY2WCZeKp8pZgcokvEJjmnJ1UGKz84r1fQR6Nq+Cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760970369; c=relaxed/simple; bh=hQAelAZ9HvVlNDMc9j43CpUIrb6f3Hpl+8tUuJ8nWUE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pW4Ab+sbHQ9hNpglQNJ39L28jMrwQkMA65EDFe6gGwZZru5bPjOfQ1Z3JnVzsLOYZxWiRhGIslwH/h+bJnFTLZE5yLih0EHdlYWQ/kf7dew0uv1cybVEN1kcIQxMLI1p/D8QDLP9IRfA6Yjk57tG1hTm/3X3ec7fcUbzzsIoifE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bvQV5ree; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bvQV5ree" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760970367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pQyqqPVnzX80M9s6VBgWNHBBaztCyITJ++CqjP/sV5c=; b=bvQV5reeDITVvD5GR0dHTxfpab0PuPAJhWWGjRqBMyd4472FqdbWQydPbRsZMU+vXjuUWx uF4B5eASoviQ0UZngUQUm4LTwI7hNXcd28se+HSKajIKOmDSXDccVsvuguLUIvtV1+bc3E peXs4YcZCZwJRe+er/bGS+aHD+ljSC4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-9AISqJAZPo-oMCsMi5mqhA-1; Mon, 20 Oct 2025 10:26:06 -0400 X-MC-Unique: 9AISqJAZPo-oMCsMi5mqhA-1 X-Mimecast-MFC-AGG-ID: 9AISqJAZPo-oMCsMi5mqhA_1760970365 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47113dcc15dso32657885e9.1 for ; Mon, 20 Oct 2025 07:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760970365; x=1761575165; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pQyqqPVnzX80M9s6VBgWNHBBaztCyITJ++CqjP/sV5c=; b=wS1y23OrYDJ2LCF+3dUt3284ZT2EWCPYXSq/iP6mvVeOF5HXlp4vCEVXfkAilVS3hr kJQ3hlEEJ6qeLRKbGJFgLafSUs+fjtB+8RMgGMwIRSgEPKnSXpJIdiE5G+riEdUdAWkC P4iGWULiRbo5TFCONYTIAehhmf/Ch0Rmrj4tyqzUVI/ZNIRIprcSlhiLzzE8SpNQJvBA 6/HUJ/C8+2nD67S3KTAMgFh1d4agYPko+hZgBUAtuuz7yr3YtDVDWjjM63naJAPjTWdK WwhVso++1Z3+4GZhXB4mDGaU4cHaMAW1GA3met3pe/crcJU2t3l15b5MAEkqjOXC/pix wukA== X-Forwarded-Encrypted: i=1; AJvYcCWhPo9u2atbIGMK3UJfRp2CXe5wuSiunHc1xEACV7zk9019X1QeZL/YVBwQtC+6bPkySk5NDCi5oYLKXiU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0G990ZaeWBu6ULqqOlV5WT9ZFxW3/O25mXhUEjFKRxj+Tedwa FUGjBQTiVRmB+v4ePJtiy0Bo0oGAvr+0Cn3+JnOYpGSdDZ6hlfIXXlIPINAs60g0ad0oSEfzG/V 4TEobp94uQNOl+Vj6S8wnS0/yE9qXhYsiOsVXlNOOyo3CUoiVCd6jGKhOlSQ21t8paw== X-Gm-Gg: ASbGncv0xpDfdfDzUzD0cyUPxEqssNWRX0i84u+AzS4MIdFe6X65GWJ9ire7HrZkqrq 1pwx7b84R2eumTBT5Krc9LboWtJaOb1Os7IqGbJV//q6AoTJteV+44rIbwOn+yYgQ8N6tclWgGi uMf/UNSZHlulo21fk0VUa/m1cZ37DlC/PUL5xtgQ2Jhy+A13bSQ6ksHnjtX9D3F67TstOgu+eEj 8pSFGgbs/t6RvGZAN5pXjLcd3nWfgtMVOYApLlZnIaWGCvvxMKJN0PqdERQYrYykFO0Cy1Jz3DA iH+h5O/cuoIZbV7V07MsSt2IMsjFmSS3shEl/26cEOCespOUzVshAcwZCE6H5dvGMmXCPlH9cK0 uuqglvi8/Gel9GpcvZGFgvKbkZXDdaM59TegTsVajHgd+zR8RUzYChm//uA8gH2bJKTbWGZMfLt S0Jc1fKZVGbCrHQhEBwhmudqt+aX0= X-Received: by 2002:a05:600d:62b1:b0:46f:b43a:aef4 with SMTP id 5b1f17b1804b1-471b5341411mr31713275e9.38.1760970364926; Mon, 20 Oct 2025 07:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFivef5uKK4dO0bLoUG5afbj0PkGjj8ivIcoCqNvXGcEAdVc8Dd+wjfTpX6dFddxGB9NaRtjw== X-Received: by 2002:a05:600d:62b1:b0:46f:b43a:aef4 with SMTP id 5b1f17b1804b1-471b5341411mr31713105e9.38.1760970364447; Mon, 20 Oct 2025 07:26:04 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0c:c200:fa4a:c4ff:1b32:21ce? (p200300d82f0cc200fa4ac4ff1b3221ce.dip0.t-ipconnect.de. [2003:d8:2f0c:c200:fa4a:c4ff:1b32:21ce]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4715520d753sm148339825e9.13.2025.10.20.07.26.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 07:26:03 -0700 (PDT) Message-ID: <4f2066f8-f26e-4704-9f75-4652d4018cd9@redhat.com> Date: Mon, 20 Oct 2025 16:26:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot ci] Re: Fix stale IOTLB entries for kernel address space To: Baolu Lu , Dave Hansen , syzbot ci , akpm@linux-foundation.org, apopple@nvidia.com, bp@alien8.de, dave.hansen@linux.intel.com, iommu@lists.linux.dev, jannh@google.com, jean-philippe@linaro.org, jgg@nvidia.com, joro@8bytes.org, kevin.tian@intel.com, liam.howlett@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, luto@kernel.org, mhocko@kernel.org, mingo@redhat.com, peterz@infradead.org, robin.murphy@arm.com, rppt@kernel.org, security@kernel.org, stable@vger.kernel.org, tglx@linutronix.de, urezki@gmail.com, vasant.hegde@amd.com, vbabka@suse.cz, will@kernel.org, willy@infradead.org, x86@kernel.org, yi1.lai@intel.com Cc: syzbot@lists.linux.dev, syzkaller-bugs@googlegroups.com References: <68eeb99e.050a0220.91a22.0220.GAE@google.com> <89146527-3f41-4f1e-8511-0d06e169c09e@intel.com> <8cdb459f-f7d1-4ca0-a6a0-5c83d5092cd8@linux.intel.com> <13d660ea-9bff-47dc-9cd7-ae74869edc5a@linux.intel.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <13d660ea-9bff-47dc-9cd7-ae74869edc5a@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20.10.25 07:34, Baolu Lu wrote: > On 10/18/25 01:10, David Hildenbrand wrote: >> On 16.10.25 10:00, Baolu Lu wrote: >>> On 10/16/25 00:25, Dave Hansen wrote: >>>> Here's the part that confuses me: >>>> >>>> On 10/14/25 13:59, syzbot ci wrote: >>>>> page last free pid 5965 tgid 5964 stack trace: >>>>>    reset_page_owner include/linux/page_owner.h:25 [inline] >>>>>    free_pages_prepare mm/page_alloc.c:1394 [inline] >>>>>    __free_frozen_pages+0xbc4/0xd30 mm/page_alloc.c:2906 >>>>>    pmd_free_pte_page+0xa1/0xc0 arch/x86/mm/pgtable.c:783 >>>>>    vmap_try_huge_pmd mm/vmalloc.c:158 [inline] >>>> ... >>>> >>>> So, vmap_try_huge_pmd() did a pmd_free_pte_page(). Yet, somehow, the PMD >>>> stuck around so that it *could* be used after being freed. It _looks_ >>>> like pmd_free_pte_page() freed the page, returned 0, and made >>>> vmap_try_huge_pmd() return early, skipping the pmd pmd_set_huge(). >>>> >>>> But I don't know how that could possibly happen. >>> >>> The reported issue is only related to this patch: >>> >>> - [PATCH v6 3/7] x86/mm: Use 'ptdesc' when freeing PMD pages >>> >>> It appears that the pmd_ptdesc() helper can't be used directly here in >>> this patch. pmd_ptdesc() retrieves the page table page that the PMD >>> entry resides in: >>> >>> static inline struct page *pmd_pgtable_page(pmd_t *pmd) >>> { >>>           unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); >>>           return virt_to_page((void *)((unsigned long) pmd & mask)); >>> } >>> >>> static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) >>> { >>>           return page_ptdesc(pmd_pgtable_page(pmd)); >>> } >>> >>> while, in this patch, we need the page descriptor that a pmd entry >>> points to. >> >> Ah. But that's just pointing at a leaf page table, right? > > Yes, that points to a leaf page table. Right, so I guess there is no simplifying that. Like we have in pte_lockptr(): return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); So page_ptdesc(pmd_page()) is the way to go for now. Sorry for the confusion. -- Cheers David / dhildenb