From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751707AbdKTQEB (ORCPT ); Mon, 20 Nov 2017 11:04:01 -0500 Received: from esa7.dell-outbound.iphmx.com ([68.232.153.96]:28627 "EHLO esa7.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdKTQD6 (ORCPT ); Mon, 20 Nov 2017 11:03:58 -0500 IronPort-PHdr: =?us-ascii?q?9a23=3AVh8GUR0CARCEciKrsmDT+DRfVm0co7zxezQtwd8Z?= =?us-ascii?q?seIfK/ad9pjvdHbS+e9qxAeQG96Ku7Qc06L/iOPJYSQ4+5GPsXQPItRndiQuro?= =?us-ascii?q?EopTEmG9OPEkbhLfTnPGQQFcVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZv?= =?us-ascii?q?JuTyB4Xek9m72/q89pDXYAhEniaxba9vJxiqsAvdsdUbj5F/Iagr0BvJpXVIe+?= =?us-ascii?q?VSxWx2IF+Yggjx6MSt8pN96ipco/0u+dJOXqX8ZKQ4UKdXDC86PGAv5c3krgfM?= =?us-ascii?q?QA2S7XYBSGoWkx5IAw/Y7BHmW5r6ryX3uvZh1CScIMb7S60/Vza/4KdxUBLmiD?= =?us-ascii?q?kJOSMl8G/ZicJwgqBUoBO9qBJwzIHZe52VNON8fq/BYd8WWXRNU8BMXCJBGIO8?= =?us-ascii?q?aI4PAvIGMOhftYb9vVoOrRykCQeqBePvzzhIhnnq0q07zeshFQXG3As7Et0Trn?= =?us-ascii?q?vUqNH1OL0OXuCyyanF1DPOZO5V1zfl8IXFcxMsreuSUb9+b8bd01QjGgPLg1mK?= =?us-ascii?q?t4DpIy2Z2vwQv2SH9eZsSO2ihmA9pw1vrTWj2N0gh4vJi44N11zJ+it0zJwoKd?= =?us-ascii?q?C5SUN3e92pHZtKuy2EK4d7Q8UvSHxytikg0L0Jo5u7cTAPyJQg2hHQdeSKc5ON?= =?us-ascii?q?4hL/TOaRJip4hG59dLK/mRmy9U+gx/XiWcmvyllGsDBJncTSuXAJ0xzf88+HSu?= =?us-ascii?q?Zh/ki63jaPygbT5fxaLUwulKrbM54hwrs/l5YJrUvDGSr2lF33jK+QaEok5vCl?= =?us-ascii?q?5uXkb7n8uJOROZF4hhvjPqkulMGzG/o0PhQQU2SD/OSzzrzj/Un3QLVQif02l7?= =?us-ascii?q?HUvpfAKsQBp665BBVZ3IAi6xa6CDem1sgXnXgZI1JBfBKHiJPkNEzQL/D8Cfez?= =?us-ascii?q?mUijkDBux/zeJL3uHo3NLmTfkLfmZbt9709cyAwuzdFQ/p5UCa8OIOj1WkDvsN?= =?us-ascii?q?zVFQE5MwOqzOb9Etl91Z0RWXiJAqCHNKPeq1iI5vggI+OUfo8apC79K+Q55/7p?= =?us-ascii?q?lXI5gVsdcrO13ZsZb3C4BPFmL1yEbnr2g9cBD3kFvhAnQO3li1CPUCVeZ2i9X6?= =?us-ascii?q?0i/DE3EoGmApnZRoCrnrOB2D23HppMZmBJWRiwFiK8e5uEUu0QQCOULNVonjEN?= =?us-ascii?q?Wf6mUYB3hj+0swqvn59uNOvTvAkZsJXl39l44+nUvR0/8TgyBMOYhTLeB1pol3?= =?us-ascii?q?8FEmdllJt0plZwnw+O?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2F3AAC5+xJamMqZ6ERbGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQSficHjhePKIF9ggCGXI4GghEKhTsChH8/GAEBAQEBAQEBAQE?= =?us-ascii?q?CEAEBAQEBCAsLBigvgjgigkUBAQEBAzo/DAQCAQgRBAEBAR4JByElCQgCBA4FC?= =?us-ascii?q?IoFAxWrCIczDYM1AQEBAQYBAQEBAQEBIYM0ggeDPoMrgmuCN0WFLAWRc5AOPZA?= =?us-ascii?q?ThHCTVY0siQaBOh+CLnqDQoJsJYFOd4o4gRQBAQE?= X-IPAS-Result: =?us-ascii?q?A2F3AAC5+xJamMqZ6ERbGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?SficHjhePKIF9ggCGXI4GghEKhTsChH8/GAEBAQEBAQEBAQECEAEBAQEBCAsLB?= =?us-ascii?q?igvgjgigkUBAQEBAzo/DAQCAQgRBAEBAR4JByElCQgCBA4FCIoFAxWrCIczDYM?= =?us-ascii?q?1AQEBAQYBAQEBAQEBIYM0ggeDPoMrgmuCN0WFLAWRc5AOPZAThHCTVY0siQaBO?= =?us-ascii?q?h+CLnqDQoJsJYFOd4o4gRQBAQE?= From: X-LoopCount0: from 10.166.132.190 X-IronPort-AV: E=Sophos;i="5.44,427,1505797200"; d="scan'208";a="1180541626" X-DLP: DLP_GlobalPCIDSS To: CC: , , Subject: RE: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace interface if missing hotfix Thread-Topic: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace interface if missing hotfix Thread-Index: AQHTX+QqL3IIl8k0TUe/zvHp0FjgK6Mdcaqw Date: Mon, 20 Nov 2017 16:03:53 +0000 Message-ID: <4f2192b6a6ed4764b5645efa7f6f2a54@ausx13mpc120.AMER.DELL.COM> References: <1510891992-31659-1-git-send-email-mario.limonciello@dell.com> <20171117203922.GG22250@fury> In-Reply-To: <20171117203922.GG22250@fury> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAKG45nm012817 > -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Friday, November 17, 2017 2:39 PM > To: Limonciello, Mario > Cc: Andy Shevchenko ; LKML kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org > Subject: Re: [PATCH v2] platform/x86: dell-smbios-wmi: Disable userspace > interface if missing hotfix > > On Thu, Nov 16, 2017 at 10:13:12PM -0600, Mario Limonciello wrote: > > The Dell SMBIOS WMI interface will fail for some more complex calls unless > > a WMI hotfix has been included. Most platforms have this fix available in > > a maintenance BIOS release. In the case the driver is loaded on a > > platform without this fix, disable the userspace interface. > > > > A hotfix indicator is present in the dell-wmi-descriptor that represents > > whether or not more complex calls will work properly. > > > > "Simple" calls such as those used by dell-laptop and dell-wmi will continue > > to work properly so dell-smbios-wmi should not be blocked from binding and > > being used as the dell-smbios dispatcher. > > > > Suggested-by: Girish Prakash > > Signed-off-by: Mario Limonciello > > Queued up, thanks Mario. Darren, even though this came after the merge windows opened considering this restricts the SMBIOS interface from some platform/firmware combinations it shouldn't be offered, do you think this can be included with a future 4.15 RCx PR so it can land with the rest of the series rather than targeted for 4.16? I'd hate to get stuck in a situation that an interface deemed "broken" gets offered to people it shouldn't.