From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72C8938F62B for ; Tue, 3 Mar 2026 09:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772531745; cv=none; b=NYx19s6HBAw0i7bfzBDi/qIfD4LFA4LwDzoFuziopn1/66RCcBjtAw5m3C3n1/lKe2/HlqO4Ubmbi8kzc5/lemvLKJHbiWM0rfmso6hcOVutGURU0+fF9ad+0XrIrrMUABxwg2uPxFWu6+ZfmlZOsCdQ4l3sOduhd141ZYXzHuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772531745; c=relaxed/simple; bh=XfEQZg8O1NwywMbwrjVuCdoCa1sFQb9IBIllLzxCgYE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p6vQ6eJOMOudyuc1WXLXAeXLZlgtsGjeSwFFAZmnJwksDp2FHWJIa3cPBIvOwzKG+FVlLv4vprl3m0Vyv3J6DCjkFtsvWvGNg7UmoV0EWBw5XyxReXC78KPRgZKGrdNdFvZI6qyTyJ5mVyLg7mlbqFXFZpOrfliw3wLB2unz2uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xXDWwTpz; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xXDWwTpz" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483a233819aso52593985e9.3 for ; Tue, 03 Mar 2026 01:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772531743; x=1773136543; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s8b78R18+qD2EcN3iJ6PBq/vdbXQerYBeT4QKKh24O4=; b=xXDWwTpzcfIpZk/BnlC2pRpX1mlJiEZcQsysfzAXgw9qfjHD/Wr1Jjxrz/NbCoEs9W h5ZC2mOOscdUKa5Qz/NVMt4FHZk6ipS0Himoa0ZUg2QQ3hcyECe0bSwmr1QYFDcDVOrG GK7LjZvoNsuA6b/RzqWJQ+fFJUgmnY0jsxu+84nE+N6IvXO5jHL7riHUa7NbMuCshUHE dM1UyOdi8M45wGC6nhl06ZcyXUbZMls+UqTGb4eo2rc7/1g3j3ZYWgFginoKfvQrTxL2 c6YTuZ7IVAqKjWrGaLXE3FOYM/mh21bjTsUB6tsNiFfKjua6EprUTIK61zErAeMhNqcf 13eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772531743; x=1773136543; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s8b78R18+qD2EcN3iJ6PBq/vdbXQerYBeT4QKKh24O4=; b=k3n0+eOWixMpigPnISxasijMTJ1H2WIURcTDTGwA4pDmd6uUx+UMvvGOAJHe9Anr3M DzgkceXcr6jdHtAbTfGYNiiCdKuQVL4yIQV1mh9TxRVvi9TxaEO5jjEWH3Ze6wT/29G+ qbopFyMHM9jiCU8kH/pUDpfFtzTcBt+/RwGJPrBEUrpb1RkD0V3a79dUCk620KYSALed ldbatZ14GyVWEOxgLTlqk10h8HjlpSZ6KmPHeqFW+ZkeOHhlHC1LbjdGWTgBBl5XOvLF 9AKsx/5UZm2YqlGrutg73zPWLa8Oe/mZ9ZlQNG1TJGlUneDLHavnw2JTApvx1RdbqYYH 7kvw== X-Forwarded-Encrypted: i=1; AJvYcCWTP3jeYWlBS7dqHmiLlTchdPAc8kevmbPR2vX8rvUpKvQFocCQpECtpJg91PvclzswFPxbGSODfQzhNIo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Vxx+2p4aX2Kzvbz6hWBklCjHzdrexNJxkesuYwNl7DqBfwwA 3sG5dQYcI0wnygPLNmVp1u+FpyOKucewXFKrZnEISUfTXMgNh0yPJmOLWBqekG4aDBY= X-Gm-Gg: ATEYQzxMZNTo0pdvhAQfJBs4289DssGd5NLSnBUdlUVx+Ahn0S6nMZBOiii967fIhOM 34PA/yfstJ1E50GZ4uHb1qNWWtYmjduVIQbN/ngSfHU6IVbf5udLY8i7E+iJca7xYi7uXVQ1eSh /AW8i3oVJGwBYgTG/ALNN9IFW8e7yXxCtWtnIPeVsSPS6E/OfOK55AjMJXkYd6pP6mmA/dW3kCI 0ZYBIIfrt0q33ezXjNVI+dE6D8RoZNk2UDZk48RzX1rBXK2gu2z6YNK6gtLmUOMuL1uxHmkYbzv Qxm7gzDIwMjGBjM7RYyR/hPUkuvVVLQ/qI4ni0mCQxglBihfKVvMamYvMWEttGK54y+R2h9nYVa MNZ+dk80dodpMoB3WY/1keAh5fPEO+pvycAn88w5HOSXnz0WOZp0lN0qvYzrDaeHUXBZaGHTd7o 2eCaCXg/HIYh4nueJnv3koH4kMWs4YO+q7sWrBTzaJTLdMpvTj+FXsXNmo0Qm7IHlJ X-Received: by 2002:a05:600c:8106:b0:483:afbb:a064 with SMTP id 5b1f17b1804b1-483c9bb7b7emr255369825e9.1.1772531742805; Tue, 03 Mar 2026 01:55:42 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485125ba6bdsm14310115e9.0.2026.03.03.01.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 01:55:42 -0800 (PST) Message-ID: <4f29492f-c5c0-402c-b2aa-0e1886299d59@linaro.org> Date: Tue, 3 Mar 2026 09:55:40 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH WIP v4 6/9] media: qcom: camss: csiphy-3ph: Update Gen2 v1.1 MIPI CSI-2 CPHY init To: david@ixit.cz, Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Konrad Dybcio , Joel Selvaraj , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260301-qcom-cphy-v4-0-e53316d2cc65@ixit.cz> <20260301-qcom-cphy-v4-6-e53316d2cc65@ixit.cz> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260301-qcom-cphy-v4-6-e53316d2cc65@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/03/2026 00:51, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > These values should improve C-PHY behaviour. Should match most recent > Qualcomm code. > > Signed-off-by: David Heidelberg > --- > .../media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index 5482fb5163e17..c612192ee727a 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -225,9 +225,9 @@ csiphy_lane_regs lane_regs_sdm845[] = { > /* 3 entries: 3 lanes (C-PHY) */ > static const struct > csiphy_lane_regs lane_regs_sdm845_3ph[] = { > - {0x015c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS}, > - {0x0168, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, > - {0x016c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x015c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0168, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x016c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x0104, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x010c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > {0x0108, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, > @@ -245,9 +245,9 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = { > {0x0164, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x01dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS}, > > - {0x035c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS}, > - {0x0368, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, > - {0x036c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x035c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0368, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x036c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x0304, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x030c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > {0x0308, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, > @@ -265,9 +265,9 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = { > {0x0364, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x03dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS}, > > - {0x055c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS}, > - {0x0568, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, > - {0x056c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x055c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0568, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x056c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x0504, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, > {0x050c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > {0x0508, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, > Squash down and Co-developed-by --- bod