From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Robert Foss <robert.foss@linaro.org>,
todor.too@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH v2] media: camss: vfe: Don't call hw_version() before its dependencies are met
Date: Thu, 12 Aug 2021 12:16:41 +0200 [thread overview]
Message-ID: <4f2e8d19-8c89-53d4-37d3-97dead170065@samsung.com> (raw)
In-Reply-To: <20210812092152.726874-1-robert.foss@linaro.org>
On 12.08.2021 11:21, Robert Foss wrote:
> vfe->ops->hw_version(vfe) is being called before vfe->base has been
> assigned, and before the hardware has been powered up.
>
> Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version needlessly")
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 6b2f33fc9be2..71f78b40e7f5 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -604,6 +604,8 @@ static int vfe_get(struct vfe_device *vfe)
> vfe_reset_output_maps(vfe);
>
> vfe_init_outputs(vfe);
> +
> + vfe->ops->hw_version(vfe);
> } else {
> ret = vfe_check_clock_rates(vfe);
> if (ret < 0)
> @@ -1299,7 +1301,6 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
> return -EINVAL;
> }
> vfe->ops->subdev_init(dev, vfe);
> - vfe->ops->hw_version(vfe);
>
> /* Memory */
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2021-08-12 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210812092201eucas1p1ba2165a230084f99e3a858827788cf54@eucas1p1.samsung.com>
2021-08-12 9:21 ` Robert Foss
2021-08-12 10:16 ` Marek Szyprowski [this message]
2021-08-23 10:10 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f2e8d19-8c89-53d4-37d3-97dead170065@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=mchehab@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=robert.foss@linaro.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®