From: Phi Nguyen <phind.uet@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] samples/kobject: Use sysfs_emit instead of snprintf
Date: Thu, 3 Mar 2022 16:45:07 +0800 [thread overview]
Message-ID: <4f3310b4-beab-9b5f-0cd4-f530559aa470@gmail.com> (raw)
In-Reply-To: <Yh/SGeW1KPcbH4ob@kroah.com>
On 3/3/2022 4:22 AM, Greg KH wrote:
> On Thu, Mar 03, 2022 at 02:11:36AM +0800, Phi Nguyen wrote:
>> On 3/2/2022 10:51 PM, Greg KH wrote:
>>> On Wed, Mar 02, 2022 at 08:07:59PM +0800, Nguyen Dinh Phi wrote:
>>>> Convert sprintf() to sysfs_emit() in order to check buffer overrun on sysfs
>>>> outputs.
>>>
>>> There are no such buffer overruns on these sysfs files.
>>>
>> I don't want to duplicate the title so I use the description of sysfs_emit()
>> as the patch message. I have just realized that the title is also incorrect,
>> sorry for my mistake.
>>
>>>>
>>>> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
>>>> ---
>>>> samples/kobject/kobject-example.c | 4 ++--
>>>> samples/kobject/kset-example.c | 4 ++--
>>>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> Why is this a resend? What happened to the first version?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> There is no response for the first version. Actually, there is no Maintainer
>> is associated with these two files (in MAINTAINERS files), hence, my first
>> patch was only sent to the linux-kernel mailing list.
>
> You need to give reviewers a hint as to what is going on when you do
> this, we can't read minds :)
>
> thanks,
>
> greg k-h
Hi Greg,
Am I right in thinking that you are the maintainer of these files? Can I
send a patch to add an entry to /linux/MAINTAINERS file?
BR,
Phi.
next prev parent reply other threads:[~2022-03-03 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 12:07 Nguyen Dinh Phi
2022-03-02 14:51 ` Greg KH
2022-03-02 18:11 ` Phi Nguyen
2022-03-02 20:22 ` Greg KH
2022-03-03 8:45 ` Phi Nguyen [this message]
2022-03-03 13:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3310b4-beab-9b5f-0cd4-f530559aa470@gmail.com \
--to=phind.uet@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®