From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1631F3537D0; Mon, 24 Aug 2026 11:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787569333; cv=none; b=QN9G1j7s3cmtOwh8mgRElQ19uKaHwnbGrMheI/606p2eFXgzAOpZ3GqFxdGQeY2qhIfIsOXuMxqDain81lO/1YBB9bCOXgFtCv+LtB1ukubqjnq3r5WfKW7sNsNIdic4ZDXE7Q3cNoh8ssDFd+MY45a5OAsv398wQlLYHms1sQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787569333; c=relaxed/simple; bh=D9BZ+hJJpuWA/8cQ7oCYLZ0wTvxa5m969omII2jFUE8=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=uqxesJPeWVTOeKj9HL2KuGSk/nJNNr+4QNvEVu7n/EedFZeslpdZZzMw1DueHvE5vZ2VbtF1V4ab+QKYhDWbIgsu73ZOQTsA/9sIoLzErQM/cjO7jO0Y/oBtJFTrajU6IDXDDwrmZJVvGbOE96Bhc2uVz5LvS74bzjC6Kc58l1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=KpBKffmn; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="KpBKffmn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1787569315; x=1788174115; i=markus.elfring@web.de; bh=hHlrmazqcVpvEqwVpnhYhqqkG2VxRO9nSsjD2wAwwls=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=KpBKffmnlNwfBHHo68jOWUBJ8rSDNw7f/FsXT756kTcwAOTnpZuukL5TQNiOELK9 2tBQ6h6BKP9wOgCS6yUGd7naJvr3eqaij7jJN4EPDHl+S/WlIucVpWLuHlU5A4cGt EvSCw1ZGPiGnpX41CndfjeC/S+eVjGUaNCy9cxpnQK8GHFy4YQaVjcDoCqedByHUe XqQQfOWEwiCBeqr9KQkuFXy5NpmbTapV32DRWTsyzpHDG9aYfFvVvhv1oH55GwHWF PfS7x5JSWs8zGYyb8haoI3P/r5zDsPofuhJMVRgrbFDKn/IrXTPKVIdo8z0GP+zjQ sszXDdc0979kMnwd6Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N2BMA-1wn5Pp1Vd8-00ssm3; Mon, 24 Aug 2026 13:01:55 +0200 Message-ID: <4f3ab9c9-7f0a-4e1b-84ad-7fe5b0b211a8@web.de> Date: Mon, 24 Aug 2026 13:01:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: hanzhijian1991@gmail.com, imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Bjorn Helgaas , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Lorenzo Pieralisi , Lucas Stach , Manivannan Sadhasivam , Richard Zhu Cc: sashiko-bot@kernel.org, LKML , kernel-janitors@vger.kernel.org, Fabio Estevam , Frank Li , Rob Herring , Sascha Hauer References: <20260824075512.3386898-1-hanzhijian1991@gmail.com> Subject: Re: [PATCH v3] PCI: imx6: fix resource leaks in probe error paths Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: <20260824075512.3386898-1-hanzhijian1991@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:6EMYblq/sqAKTZ76CQ1mfxMBjYW6kcppsrGFyVBiFlmeGRh/w0q 8n6uM+Svx1idjlfZ4aBdDWZf+ECp5vGN7Cl4kk+pgzO8icwq14XbaZ4l1GIZHShY+ML4ONY gSj8C+4hRXb8XqeOhnIu+S7r5V/4sqLTTZWf9Qyr4YYouAzs/m9mnbjE8/ff6/AggxPDufP istixft1SeG+GhxBGGW8Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+/Dpa6abCrU=;g9PZbIhB4O05A6xzneizjiJwAbD EoG/el32INtZ86rU7CctfKubjJA652e7K71+UgtGVME9OhL9Ck6UdO6NFruoYxJHXlTyzIGzY e9E9qmA37168zhgf0YaPhKQd2O1PADPwe5YVzM9LFmTXcQGFIaUC2fJRHp/buLdwNY6qR2k1+ sEgGgZoTfCfHAMsrw8aB/Ye0CSOGKUZt7VRZo114vFJq4BkFpnieVBQeA3nqf+Hubm2Fi2x5K tl1JA7AdiyalUf9euz4Gb9l1OvjK76NZ4NnWlj1052cpB/ABvJ0MbxieLzd2k3mw/ncT1gUBB MUFGmuYt7VE4SorroqprXFUzReP5O2KxRCh0ymb5Wu1+fXoD5H/Sy+ZHsfKJ4DN/k9tOjzvS+ xR2K5NscOpmfxl+PAi4K+NoNmsBCnt1RXDWCjFHP1K3NzGfBfxrnvteWIXTtXgEXL4BjYl1tW yz+y8XuHdHZrPoEwFWfuc+OCD9WiZ9fPhsGjQ48Vk2gVWsjcQYWwW0hbkR4ACpbZSvwSvQ/D6 L7Faf2WfX8WCi9k9N/FUPpnHSumQsQdT2HERq+w7yOBcV9ouURwCy4YDNJNqEkuHOa5EzWuWI bTXRHQiVPMsdJAmDD4rOhH1DYAgnkq54P9rx44oXbUHvAIedL5kwwBa2k3AD3AchQ6W2jug/X C2hFqPFw6p8hHBlF8wpi2nsBhMDraj3y+7C0FEVrVQ0l8w1lJ79/+0S5L2kN/fgstJPIlY2OL W+sbGg3Jg1TzSvRMNlLamq3M/sl8AOEG5+FYf12TvhlKvIvvyNNnnf68EjYPltWccZhZHzy05 Z46vIqL5dpU7o/bpD9DeIIPaQsMdvWoCkFk9HTN6f+EjYFqoAgZYwAjht3hPCDEmP3PfhNZY/ jhw6XSppvcveM7GMxllBELl/4hcJuavkgql4uvfON4nCL/0OTYDSsLucCvFK7dtiYs9REbv5X pDChcbzPAesSVZ4BV2Tqf6m+YOrFauAz3pTQ/BHJJN9kg8OqOwPiMWz47py6OMMdPNkHn6GaV pAzsfWaRQKF7ZNg+q2eSPXxycsyQtZw7ukUXybBKiMFE0TMBDDFCAJMuKecmZwme6zB8/DVsC Da8QagNiUj92/TfTpO5fWfWpdVf5nn7Tw1PR/ivrOmCwAHHuBBFokUvuTkQexosBYWLMCHGWF MX2EXn/m44pUPZhDmjl+zyd+rrmJUlJVSZJzNoXhFW1GkbwlBhvhvJvmGgDC0N0vaWBElfxT5 9C28e9DnU6mT1ZYfly3aJ4zCQfjKDJCHG9KkWi0W7fTwMr7an8AOWbPgyR2LOkiDIYT0lHjYl DMx5JNMPaE5NH0gdM3MWYJyBvsQ/nFqZj/2aEeJ23vUeN0Ri9hp7DfPE9vnhTn352E6cy/BZO qyvnvJ1EUsbo56/MI+YEXszauHWGS3MUzZdrGzbVz4JGyO+vhjISRxUK38PQjgpnJNNPmDyn0 Y4glAl0jTvObI21X56ZZPEpODA4d/Iydw85f3l6/Bupv7ENTCHnyfUvkQwFDlSbFlGe6X9huL sekMfC4HZXi2QRkDf/dZ17k4apYxoY3ETsNQ3lc6QjTCmqErUqpqisjXQf4SAlPJQLeh7BGtB EUw5U4y0fqpNCTNGLOjFf5GfZ4vF+Vacmh9tst5xuR6NoKfE0dkSAw9s+6oabUi6suft9K8CZ /y8ZuXut9s8IMXAHh2dSWo0k6+n3sLaey1f1/dn4Kc9GDd9w7NaaZcZMOEBRhbxRoD3iolOBD P4rJV0B3BvdzTWbIaqhRNVRp/mRneFFZOwUjMx4Af4JyuABl334PZIP3a7K6TmpWbOZs1v+OW HZDaxfljU3oU8FQ3n8r9dhWarhuV7PA919SZ6Ianab36RubeIVPIZxjwcFLhKoqbgbwXLiC5P lDVacFqT7ue3bbIk/XQEpmIfGNy4/zZQAbEmc8qyEUeR+iNN2IvCSVFmU2P++2WsqXLSu1r24 CH9IJzhWYoyyw27goF4z4rWZOYnlaZeJ1i9LnXct7CuUXha7n9ZXZEJAN1YOXNMAeI7TIXpma ChsOroqPYrKjiRDI+w+I4gXu8n44wh25rox3RnGhcaxLOX9zVUPqEcvodjU/7+Nnrsap+sdm5 1iAbf/9R9aOs5rKTH7wyhQPNdFU55ZjF5QCDXjoAFBmm35R2+4BincFmL8NSrS6jmRwx2mG31 Mg7gG0f639kTgYkzN4+CSmBGkPw5BT86lSqYYHg+Lk6D4Xmr81IALxyB2xfsrylpBtJqX+uda fBfX+BGp31AzxU9lbiBmT8R2bvHQdFRwiD5Z7lbnISFJjWAfBgWm8cEVsrCEOiSEJ6DtNOUnh T9p0mAsTND1tszOjUJti1Ab5woaLNN6QDIZDlqsvduduQJYBuevviMxTiNS3fIBPNEu9+DwD/ etbeh2y1HrFyYP9+d8kdmclaTXlfasxXWl5saiDoEM1Dv+CYGCGsYHdgpdNJh/fSQbxAqAiZF cXtyo5kwdrl+RSmjq/eS/SWBTVONs/N55C5/hL1UYR/bKh1/lj9GYlkibmdxfovimQplm8ut3 AEykK7ZMSMuPmX3OzMNkyN2zauUqbcqwqzz6HliLM2EfJvK2Q5ASIZ6c5QLNsg36u1jU87D35 UzT28wX81e9r6YTc6yw8wf2bpQxA7EtOAIqmb4gm8yj730XYPsWt+Yx17HIDrXE5QMZ9OBSbc FgIyapxrj4pqI/SEH8tIeBQginGM0DHb7H1QWOz52ZQuMogzyfhNwFc05eKHhf8igfrEbrJMy SlG/l5hUA5K7SmgIq2MEMEHib9LJWc6qiSU1Zg2D6HAqyiHfEGRCeh6Zdsy66ZLk/ojTSAltL oGYOXIUGlNnGLITGcCCHSvbSvRVH9mfOwLVrwwYGHiMRQWR/QMcjbcf5Kkh/wNavNGLs36nzb zY3uagRXAHNNB9BQHj8/NPA8XQXoNDyMVOqRDnCFqJ09QY7ycHPV6LDDPnZm3sJKrH0qwusuY vhGy/uM6BYOrKBnElrqZD09Jx9Nk9NkNEFD9hwlHbIzRZWBSSAd7lRwOxWeNvxoJjrdF5daH/ pR4gAyEO4mxN6w2ObcH63I01YufQb7OrrqYwUCoaaPt+ZnUTaQ1+7Jb+nLNcYyf2XqSdumzYc yKVFsQ7W4q/Go9HAfQubQOPZYoMXtiS8G2vczNUL3oI8cydBBZifPlhrnf3nYL8S4A3izcow2 vf8g+A+sfjQtTrIIe8676MXI7XRTLzkY2k2SZlx1GTa+nl/EgwPSe8kwNChyvBdULQxAz88vH NnO++6vkkEigZ94MfggXUgfL/vtkWz1x+27Wf54Y6XAIhpoaEh0uVz9Ymo5VT81PgRVuPNgfd vPfGBHAyFHMUVvawX4Y19/y7qglb1rJVSbYeArUlwtkXGZGAcydM4Sb60lpJ1waPHJYGHtiTa AuqP/erAh+2n494BwcHvZEwhdajLDc9JizDSioHqjaEsh/G6Ej1UUmoMEi0uD1teMhGhlYNXq Ir7n8QjejAasy53PGxbuEvtQ/Y7Ta8XRmlzoDU3FKRJ1TjxCjf0N1MI42yo0OzjGs6jFRxGCk cmNbUVa3yuBbouA03F+qdNnC3GpB836CjSdy0M8CT/Jj+jqFBbCHpcnb3PIGisoKZPNiPfceg fTV8RYTKOOD6tZicXv6mYqihXnHdKWac8+vUTzGz4ctE1Xm9we1XTUqNVM4PYNUT8fHuheFOr vfzO+7bq0X7gbad/E3LTd2epWCZaZ3pZ6ljNMqPkjtSp0x0P1pOUNZ6MCzdQGn282rDaSUDsq ocjAEsfoUasuuvEsdWssIVfuCUJwXlduWFi22RPDstH0LqhyRE+NOTaZMOvnrBcfvow/mna7w ljwDswh7+NftRHMxqYGLQcyVc60PLARaWh97377AW3uwJ0GX7Lu0qezR0pNQrd2vbl+2sz7cd FMR3NFpbjrezDrTNC64jrsF2p9RB+OcSkizbeWynz59o/BLhpBCx+iqkXUdNsXOtIIClTjpsi zS29Kmh8kCq6tOxP/SJxD5Akp5n9azUjxDFke7JTG58V/CincTy+A7Wq4pk9mSg+1iR4cKJLN J5Od+kxvm27tZIb3fjW7NIC912mzvgMpZ7c8exyaEhojdTZCgjxMGiCcHKWBodR59xWtbmpZj L/PYHF8YD1V2HU4SVCJKwtZCZ3Ad8ADT6mAycRXSyTEJUzUZYnZxQwLL5QXEZiiPi+EhC385g +PeAzSPuQrO36hwL4IvvS49NKBCm77ZOOHD+pW15yY+BDYJ+MFGEhqxsU5K65yTwX0E4xDENZ 7J/9F1eXBDT6tOxbacsLaGy8gyrCXisda9R37mASJVQcTIAn7+T6HGwROLrikAFYamOoNpJEJ BKKHUuYvAyx+TsAfed+dYDCg++2/Cfy8d0SYMeAJYpzH2QJ7X1HxyQTtkABKtW1eIEVMNPjlp SPCmREnghuQGnqUnBo7pwN39fhU+HfP6nq5UVsSTbM4nRqUFSCf4zSJ54pTLeap4WLYbPpBOu jJGZINZFVfVJADFstBz+xjHUZbDNWkrCe/AnsPLBj064ldp4pYiv8FzSFnOQFOQ3tO1yXHlGg EHuC2jUW80S3lGov7Xn0CwOw37TuUeOkqYxCRuNGe06+LG/s300ETelRY2reBBURe/diceD7A 4CPwT1BqU7OaoiwYlW47Sa90s88Ud/f7TYuZ4cQqRhr1TYdERnqW1Nv43EWjDtZiDhwKkirK1 kRT9u9lWbldlPBuDUUsD3qPxXni6uZGq/WEQ12wNtI5uYC6D7Tfo+eekgVsLq3DXvodSPEVHH TmB9v7nlvP48AlI8NzuYYpC1PdnP5/0l7S9UMMKzTPUCXE78knp50aZZJj/XgxmsB1xX6wN2X fOqoYz5Ji1If3NeV9uvL+CjHQDhr5FcW7vSt21ygGlpQEyzUv+CI6L6R5M1KczDUWq8a/cS54 EIRALf++176dYv3y0bYtsBMNqN7/OF5M1MsRa154g5O+L4Wg79ZSoSFE2f6WEndpLylVmnOTi knIwEeJFqT+o6HvWqrq0yQGaonKQw7XMSQLg7dquE7MRyxiwvU3+2Tn5mlv21IkyDj2TjXj0M eyeGt0/PWiLVdOLHej+VI9WA9NBcuNt9EGwXY85ntrXZQoEoJarzItJvwljw43LiWfMNoKdAV J+G1sP8RtKTYH89okMnzniRW1oqvp8A5YNQiXQ/LgaiL/ZKE6jiykWkkkRWZP8hVo1XqzJLdG pPtMEqtU5HsEusE7WeF9qxAG+cgGxb8eI0fslOuICAQk7fO1n3dLMWuN80Wo6/urMisKWxZTT Kfke24DVe1S/u553BYathMUj2H4BqcAjmAhs+ttgCrzriLtHqB/HoJrGU+wWnKZj4d6+Z19we qi6VDof1r/dW7ly0pdgEGzn7eNcgNHaE3RcwFBfzzpT82/A+ADE6ttJc/Sme+yIzOSVMpZsNQ 1dXYSbeyoEJy+Jt32AvPcA+azSocgoy6frcMVv/e3zBVPNEZvh5xSIpLwU542gxvUyt8PcA+6 E//S+D6wIF5sV57pojI33g2DyBmt+4hN4CwK76XCWZX9RqM03lEEDFS7kFCzwI/cJ1VA86S2v QhTfFaXea2uBqoeeaNqKHxIW+QxI5nyoOXVieVHuts4pG5MvSqlJ0OgJMQDKS5Afdjgf0i4g1 yqZiIvBg1Cf6bCyBzVtXm852jC7u0YRZf+SQbUTKk3NlxEi7ila3445+RmgiJDhFanHDwVaOA j6tvs2ZcUGeOe75UgiJFgyHOFSo6taDzhjL4CcqkiFIfFewg2/fc6ji4923jkHRnPQP28QZYp iZwDxvdL/Y35Zd2pP0OWfUJ7PjBU+EXFzMAcg7Bj22CXsH6BB4FZzg1/pry1lNPs/qyAPPHGA ZI0CjsO0aG10FjidQO7+sp1ZgUlbwrlmBs/AHRFk4RIPYkpUwqEUoQcVx9tyOLYPMkU5JoaQm WRFXTb17t6paUuCbzRJc1dTJJ3lEPM80QWa2uH8c9revnBxOAICOkiWuf3wsijUZM0x7Lp5Yw 0/YwCWM8pQeCyIVkD0k92p41QNijS54vsZ1gn6Eactk/Jfpk3nlUFCpPyx8qPft7tz46rqaU0 9aJGU9PeUYpaAY7lxiBrMdog71o5+HfqkCbilfKIgZR6XoycRoaC32Bi44VFqGKZEGjt8/AIZ PBdkUs/XTTRbKos3dIOWyjohBf+7/AZNfXQFy9ufBkzUh5Ntx/Iw+OJmCplbiBJIcKBQ5sXHd AaR+4WsYM08rrIt0bUmoOAI8AlSIvzEsMMq+1MdTyPzVJWpyWJyF3FDiC+O2ldUiPFM43ju2Z ltcE/vB877553RzdrIfJz6HSeyW2vgK2vaHB7FrxIXhoK2rcq4k9/6oqN3q5MTd9NLqL5BmYZ uQFi6pD/Q3lk3LlDAe62tAcf2gHKsf0HCkZDw6XvaMKwcAibR0+cch74qA2GIT9Ceweip/uEd FgZt/nGpNfeimI3y1rDQ2nDQPEHGpQI0GdDf+L+gpwArrXGX8EhUoKwJKHIG7ApA2YkDaWZc1 oxqE3Tm+i8DT/gjXuduwaIuN5ffWy0JpttbRM675UTffYFtJNehM7QryxNiubYlbtb7nOKRHI QU/h1mXuHgHozh6Q9KoKONcJCmvi+psaw/UOvVRPB8PH621P9DicDJTbZIYyOrvdrQryhtS4G 81fWrPStgjX+1bVyDwM+IVHipTz0+R7Ft9IIXaXv9uAu2CoD1ikkYkXJzOVPj4VxyjDCw0Zfp rWa33vPMY+bCdyWximmKMdhP1Sx3Nphi > imx_pcie_probe() leaks both pwrctrl devices and power domains on > failure: =E2=80=A6 How do you think about to add any tags (like =E2=80=9CFixes=E2=80=9D and = =E2=80=9CCc=E2=80=9D) accordingly? See also: * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/submitting-patches.rst?h=3Dv7.2#n145 * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/= Documentation/process/stable-kernel-rules.rst?h=3Dv7.2#n34 Would you like to avoid a bit of duplicate source code here? > Signed-off-by: hanzhijian Can an other representation be more desirable for the =E2=80=9Cpersonal na= me=E2=80=9D according to the requirements for the Developer's Certificate of Origin? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv7.2#n396 > --- > drivers/pci/controller/dwc/pci-imx6.c | 42 ++++++++++++++++++++++++--- =E2=80=A6 Some contributors would appreciate patch version descriptions. https://lore.kernel.org/all/?q=3D%22This+looks+like+a+new+version+of+a+pre= viously+submitted+patch%22 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv7.2#n310 Regards, Markus