From: Christian Borntraeger <borntraeger@de.ibm.com>
To: David Hildenbrand <david@redhat.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jon Masters <jcm@redhat.com>, Marcus Meissner <meissner@suse.de>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 2/6] s390: implement nospec_[load|ptr]
Date: Wed, 17 Jan 2018 15:04:16 +0100 [thread overview]
Message-ID: <4f3c7daf-6669-9908-8307-17d394b76f52@de.ibm.com> (raw)
In-Reply-To: <08d3bfc0-97ae-6f2b-c44b-531be00737cc@redhat.com>
On 01/17/2018 02:58 PM, David Hildenbrand wrote:
> On 17.01.2018 10:48, Martin Schwidefsky wrote:
>> Implement nospec_load() and nospec_ptr() for s390 with the new
>> gmb() barrier between the boundary condition and the load that
>> may not be done speculatively.
>>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>> ---
>> arch/s390/include/asm/barrier.h | 38 ++++++++++++++++++++++++++++++++++++++
>> arch/s390/kernel/alternative.c | 7 +++++++
>> 2 files changed, 45 insertions(+)
>>
>> diff --git a/arch/s390/include/asm/barrier.h b/arch/s390/include/asm/barrier.h
>> index 1043260..b8836a6 100644
>> --- a/arch/s390/include/asm/barrier.h
>> +++ b/arch/s390/include/asm/barrier.h
>> @@ -8,6 +8,8 @@
>> #ifndef __ASM_BARRIER_H
>> #define __ASM_BARRIER_H
>>
>> +#include <asm/alternative.h>
>> +
>> /*
>> * Force strict CPU ordering.
>> * And yes, this is required on UP too when we're talking
>> @@ -23,6 +25,42 @@
>>
>> #define mb() do { asm volatile(__ASM_BARRIER : : : "memory"); } while (0)
>>
>> +static inline void gmb(void)
>> +{
>> + asm volatile(
>> + ALTERNATIVE("", ".long 0xb2e8f000", 81)
>> + : : : "memory");
>> +}
>
> Just to be sure:
>
> There are now 2 new facilities:
>
> 81 and 82.
>
> Is 82 just the virtualization (SIE) support for 81?
81 is for ppa15 (see this patch) and 82 is for ppa12 and 13 (see patch 3).
In KVM we want to provide both (and let the guest decide what to do).
next prev parent reply other threads:[~2018-01-17 14:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 9:48 [PATCH 0/6] s390: improve speculative execution handling Martin Schwidefsky
2018-01-17 9:48 ` [PATCH 1/6] s390/alternative: use a copy of the facility bit mask Martin Schwidefsky
2018-01-17 13:54 ` David Hildenbrand
2018-01-17 14:24 ` Cornelia Huck
2018-01-17 9:48 ` [PATCH 2/6] s390: implement nospec_[load|ptr] Martin Schwidefsky
2018-01-17 12:41 ` Jiri Kosina
2018-01-17 14:52 ` Jon Masters
2018-01-17 13:58 ` David Hildenbrand
2018-01-17 14:04 ` Christian Borntraeger [this message]
2018-01-17 9:48 ` [PATCH 3/6] s390: add options to change branch prediction behaviour for the kernel Martin Schwidefsky
2018-01-18 9:52 ` Cornelia Huck
2018-01-19 4:53 ` QingFeng Hao
2018-01-17 9:48 ` [PATCH 4/6] s390: add system call to run tasks with modified branch prediction Martin Schwidefsky
2018-01-17 10:03 ` Florian Weimer
2018-01-17 10:05 ` Paolo Bonzini
2018-01-17 11:14 ` Christian Borntraeger
2018-01-17 11:50 ` Paolo Bonzini
2018-01-17 11:55 ` Martin Schwidefsky
2018-01-17 13:25 ` Heiko Carstens
2018-01-17 9:48 ` [PATCH 5/6] KVM: s390: wire up seb feature Martin Schwidefsky
2018-01-17 11:18 ` Christian Borntraeger
2018-01-17 11:22 ` Paolo Bonzini
2018-01-17 11:28 ` Christian Borntraeger
2018-01-17 11:29 ` Christian Borntraeger
2018-01-17 11:32 ` Paolo Bonzini
2018-01-17 11:33 ` David Hildenbrand
2018-01-17 11:39 ` Christian Borntraeger
2018-01-17 13:44 ` [PATCH v2] KVM: s390: wire up bpb feature Christian Borntraeger
2018-01-17 13:51 ` David Hildenbrand
2018-01-17 21:43 ` Christian Borntraeger
2018-01-18 6:27 ` Martin Schwidefsky
2018-01-18 9:59 ` Cornelia Huck
2018-01-18 10:09 ` Christian Borntraeger
2018-01-17 9:48 ` [PATCH 6/6] s390: scrub registers on kernel entry and KVM exit Martin Schwidefsky
2018-01-19 6:29 ` QingFeng Hao
2018-01-19 7:57 ` Christian Borntraeger
2018-01-19 8:27 ` QingFeng Hao
2018-01-17 12:00 ` [PATCH 0/6] s390: improve speculative execution handling Cornelia Huck
2018-01-17 12:05 ` Christian Borntraeger
2018-01-17 13:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3c7daf-6669-9908-8307-17d394b76f52@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jcm@redhat.com \
--cc=jkosina@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=meissner@suse.de \
--cc=pbonzini@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®