From: Randy Dunlap <rdunlap@infradead.org>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND] iosys-map: fix typos
Date: Mon, 12 Feb 2024 10:56:40 -0800 [thread overview]
Message-ID: <4f3fa9e4-3000-4a96-a7f6-e32e69b57a84@infradead.org> (raw)
In-Reply-To: <bf0d02d4-2c90-40a4-8018-bd96a01f2751@suse.de>
On 2/11/24 23:13, Thomas Zimmermann wrote:
> Hi
>
> Am 12.02.24 um 05:28 schrieb Randy Dunlap:
>> Correct spellos/typos in comments.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>> include/linux/iosys-map.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h
>> --- a/include/linux/iosys-map.h
>> +++ b/include/linux/iosys-map.h
>> @@ -34,7 +34,7 @@
>> * the same driver for allocation, read and write operations.
>> *
>> * Open-coding access to :c:type:`struct iosys_map <iosys_map>` is considered
>> - * bad style. Rather then accessing its fields directly, use one of the provided
>> + * bad style. Rather than accessing its fields directly, use one of the provided
> Ok.
>> * helper functions, or implement your own. For example, instances of
>> * :c:type:`struct iosys_map <iosys_map>` can be initialized statically with
>> * IOSYS_MAP_INIT_VADDR(), or at runtime with iosys_map_set_vaddr(). These
>> @@ -85,7 +85,7 @@
>> * if (iosys_map_is_equal(&sys_map, &io_map))
>> * // always false
>> *
>> - * A set up instance of struct iosys_map can be used to access or manipulate the
>> + * A setup instance of struct iosys_map can be used to access or manipulate the
> That's not a typo. This refers to "an instance that has been set up".
>
Thanks. I'll drop that part and resend the other.
>
>> * buffer memory. Depending on the location of the memory, the provided helpers
>> * will pick the correct operations. Data can be copied into the memory with
>> * iosys_map_memcpy_to(). The address can be manipulated with iosys_map_incr().
>
--
#Randy
prev parent reply other threads:[~2024-02-12 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 4:28 Randy Dunlap
2024-02-12 7:13 ` Thomas Zimmermann
2024-02-12 18:56 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3fa9e4-3000-4a96-a7f6-e32e69b57a84@infradead.org \
--to=rdunlap@infradead.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®