From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org, axelrasmussen@google.com
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 7/7] selftests/ftrace: Add test case for synthetic event syntax errors
Date: Mon, 12 Oct 2020 15:18:09 -0500 [thread overview]
Message-ID: <4f445625d0d6dc0656e550057aa784d56832b5f2.1602533267.git.zanussi@kernel.org> (raw)
In-Reply-To: <cover.1602533267.git.zanussi@kernel.org>
In-Reply-To: <cover.1602533267.git.zanussi@kernel.org>
Add a selftest that verifies that the syntax error messages and caret
positions are correct for most of the possible synthetic event syntax
error cases.
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
.../trigger-synthetic_event_syntax_errors.tc | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc
diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc
new file mode 100644
index 000000000000..136276b11386
--- /dev/null
+++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic_event_syntax_errors.tc
@@ -0,0 +1,19 @@
+#!/bin/sh
+# SPDX-License-Identifier: GPL-2.0
+# description: Synthetic event parser error log check
+# requires: synthetic_events error_log
+
+check_error() { # command-with-error-pos-by-^
+ ftrace_errlog_check 'synthetic_events' "$1" 'synthetic_events'
+}
+
+check_error 'myevent ^chr arg' # INVALID_TYPE
+check_error 'myevent ^char str[];; int v' # INVALID_TYPE
+check_error 'myevent char ^str]; int v' # INVALID_NAME
+check_error 'myevent char ^str;[]' # INVALID_NAME
+check_error 'myevent ^char str[; int v' # INVALID_TYPE
+check_error '^mye;vent char str[]' # BAD_NAME
+check_error 'myevent char str[]; ^int' # INVALID_FIELD
+check_error '^myevent' # INCOMPLETE_CMD
+
+exit 0
--
2.17.1
prev parent reply other threads:[~2020-10-12 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 20:18 [PATCH v2 0/7] tracing: Synthetic event dynamic string fixes Tom Zanussi
2020-10-12 20:18 ` [PATCH v2 1/7] tracing: Don't show dynamic string internals in synthetic event description Tom Zanussi
2020-10-12 20:18 ` [PATCH v2 2/7] tracing: Move is_good_name() from trace_probe.h to trace.h Tom Zanussi
2020-10-12 20:18 ` [PATCH v2 3/7] tracing: Check that the synthetic event and field names are legal Tom Zanussi
2020-10-12 20:18 ` [PATCH v2 4/7] tracing: Add synthetic event error logging Tom Zanussi
2020-10-12 21:42 ` Steven Rostedt
2020-10-12 21:49 ` Steven Rostedt
2020-10-12 21:59 ` Tom Zanussi
2020-10-12 22:04 ` Steven Rostedt
2020-10-12 22:24 ` Tom Zanussi
2020-10-12 20:18 ` [PATCH v2 5/7] selftests/ftrace: Change synthetic event name for inter-event-combined test Tom Zanussi
2020-10-12 20:18 ` [PATCH v2 6/7] tracing: Handle synthetic event array field type checking correctly Tom Zanussi
2020-10-12 22:14 ` Steven Rostedt
2020-10-12 22:24 ` Tom Zanussi
2020-10-12 20:18 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f445625d0d6dc0656e550057aa784d56832b5f2.1602533267.git.zanussi@kernel.org \
--to=zanussi@kernel.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®