From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 103EC2E2679 for ; Thu, 3 Jul 2025 12:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751547013; cv=none; b=MoK6WcSa7Gfws9Few+hc7t/aza94/H3BqIQP22gORTcuwYZRnj+cvGpW2c54SU3aqvL/uyQDnLC1GxqBkdppjx1Vjd2g30WFD2NJi/4t6/MBkiS9PQ1nvtX4LPv8NBxCXaQQRvsyO1LVIpvb85F3G7B0T50iUcioBYDClTCv1sU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751547013; c=relaxed/simple; bh=Qqgc1GnsOOAq4v1APP985iIN3JGVd/bERoSbPbqKFAQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZFUWLogxdcQSP5az4aswAfC/B6nMzBhjSekLGMzixLGCaJwyCHu6OcAmrqDcqbE9hncddgV7hvDo84B9vBekeNTj3uIrb1vD67lJbpkpnBdSF/djobBT1PItNmmiKMU5AtnyTo4B02srcirLIYKfg/BtO4v5VOWGmaQ8aJ74Lt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ceIyflyr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ceIyflyr" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5636vRo8020476 for ; Thu, 3 Jul 2025 12:50:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uj1sS16Dw8PguzC7LFhxazWH4isKpN88omJ0VRX+99Y=; b=ceIyflyrPBy0NZjV JjVKQl9IXmvqESL+iKNOQ89Ru+xutmghTyTYK5EGp42+lVDIR2p8WQpK/pfEBOuh Cut0L5fIVUaYkSPZef+Be8Wc8zGbE55uixKvrwSfPV29jE4xyTk53tGYU2l38gxF /r00NMy7mQeCibDWjRGgyG6PIBzhY6IHAu9LNfxu52o+9O3DjB8JfW1LkEhYZMHr d403Hv+GCrQcnPprsD98e5eYyY5mJCmdXFHgUHUFUbvtnuHcEgrAg4sT7mKy0WeZ ik+kmm0rcoQfNI0GeNxE2YpdUO4c107araPDhvKtCvrmcSJyGXqY8icv375VLe1a +D3mEQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47mhxn75xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 03 Jul 2025 12:50:10 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c5e2872e57so908129885a.0 for ; Thu, 03 Jul 2025 05:50:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751547010; x=1752151810; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uj1sS16Dw8PguzC7LFhxazWH4isKpN88omJ0VRX+99Y=; b=psUwFX+zlTQgRo5gROxpddKuqgapncg1bs4fOJK/xDKBOokveGWlw7fukNZGh9pnwo CWVGy3hPsUnQDHu7tnGqaHWR6cPKCEZ5mcFiSmGCkpnoWsU6WQWRRTJBZckSgFxK0MpF y3U8ZBm3FfuqeHh8ggXrygfhftYAz+NZr/LarGzxLbI7PWqGR/56vYj0ZyVGtADX2H9a AQ58zIm4y1jjDFyFBcLQjgg13/cMW5CXcKCfi1L3sqfsh1v25dC6BtW76Mcpt6Pkq+eI /5ounBjrq61yM8rxnvStwXWt5CsqzRJLZLDpMMmzaa1D3jIcTLEPYY09mn41Dx6ihkKA BAJA== X-Forwarded-Encrypted: i=1; AJvYcCXYLR0PoSGQo/pK5ntw3pB9SC0WSVDWQOVoqnXKtl9Y9CNR9XaIVKR0bdDGMDPAiOYwBlXtNO5+Q9Pl200=@vger.kernel.org X-Gm-Message-State: AOJu0Yw72t/sZ6Vxx03BlVzdCYJ/GuIN1z1a+/PkMGdLkqVcWRyI0dYD s4/AAxkbgelbuTii3kYTpGqKS0yrN2YzKBNAXFy47u9fyFeAY0kkPDc6vS7nqNTW0dmnJ4ZXLJX dM+qCYuCC4OLmfXVeFDmkJVy0BDZBQhI6JcbsHl30hl4hGBM6ABA/64THASmlV+DhueA= X-Gm-Gg: ASbGncvVsC/jvvFGI9JjyUmqwXRHoBYdntDkfPvfD4MSjY4g/0y3D5eJw3FhbkIQ9BY 4j3CdNkIFSwB8VwK2Uj1oDJQewzeYwLkyVP85G6eafnMV30XdkZkC2Q39YfrAcxTNxEHQYqC0t5 AZaRhqP0v8de39kU6s/Gt4lbrcDPqBML36q6wHF7AOYUXbkex9pGBnw3ZtOWtpI8j1RfoDqb/fP +FuXEe9xvGPjl/9PS3ap3KFUVw1K3WtxTw2pZuQInbIkAx8Lj4VEB8jiIsRltAkYXKs69zQ69M9 1WY8BFG32CqQZKBNBRYTnVxzqEMXq/WYOp2CQuwyBDP9MIMG X-Received: by 2002:a05:620a:28cc:b0:7d4:536a:c0c5 with SMTP id af79cd13be357-7d5c4704096mr755996785a.2.1751547009980; Thu, 03 Jul 2025 05:50:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5zoCjhAwYQJaY5mtO22xdyqlDuhd9aBfqot1+DE6Zj4R49CJv87BJ4eKnl1sxbcb4/h4Iyg== X-Received: by 2002:a05:620a:28cc:b0:7d4:536a:c0c5 with SMTP id af79cd13be357-7d5c4704096mr755991085a.2.1751547009398; Thu, 03 Jul 2025 05:50:09 -0700 (PDT) Received: from [192.168.68.115] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3a88c7ec6aesm18533845f8f.5.2025.07.03.05.50.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 05:50:08 -0700 (PDT) Message-ID: <4f51fa0f-96ac-4b9a-8e8f-e9e3d9c1f512@oss.qualcomm.com> Date: Thu, 3 Jul 2025 13:50:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] ASoC: codecs: add new pm4125 audio codec driver To: Alexey Klimov , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephen Boyd Cc: Lee Jones , Jaroslav Kysela , Takashi Iwai , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20250626-pm4125_audio_codec_v1-v1-0-e52933c429a0@linaro.org> <20250626-pm4125_audio_codec_v1-v1-3-e52933c429a0@linaro.org> <00b63483-8012-4a04-9486-536a7b236497@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAzMDEwNyBTYWx0ZWRfX2YdLiwPmkSSA lfo62SctM/0UD8VOuDYGrcxj1zVIvfVbtSbRy5Uv6TGcKLY92rDAPPPPatsj8MvW8/BT1BqGDT2 ENnLrX2HVGit0Ch79BeGirPXSRW4tH0TR3pyHxw0bUwjbq26H4n5lP7vawGKGOnE3KvKJZcNP6p jMVSIDiPJH0PkV8gy2R7sX2ANJaN2AGWpDZbSOlqwNFgO251LbhoniLYQEwJB4CL+6a0yQNFjc0 lp3QltsIU/XJrN+rT3NzjSb04K2xz/kOISh57Rc8lwVMSJzy7q8gulmXypl1NqHx2kOUnkEZ7Yd EtnUsLmg7uzj1ikUPFnx8fA08vxGvM+sUTviHw+Wct6LAwL1qfpXipPFDFr4XrN/7ePIQALNZEe FxRnjPnm7co8EJzW7uh7S4tyzvMc/l3tpcc2RLHfd8hwWB0m1ZMEtfI/UzYde+N64taC8X7O X-Authority-Analysis: v=2.4 cv=EbvIQOmC c=1 sm=1 tr=0 ts=68667c82 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=Men2jHeljtYBJhSsfTwA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: gXUfYZG6lnKGGFWoLZXhiQFydWJBzDJI X-Proofpoint-GUID: gXUfYZG6lnKGGFWoLZXhiQFydWJBzDJI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-03_03,2025-07-02_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=607 lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507030107 On 7/2/25 2:43 AM, Alexey Klimov wrote: >>> +static int pm4125_handle_post_irq(void *data) >>> +{ >>> + struct pm4125_priv *pm4125; >>> + >>> + if (data) >>> + pm4125 = (struct pm4125_priv *)data; >>> + else >>> + return IRQ_HANDLED; >> This will result in interrupt storm, as you are not clearning the source. >> >>> + >>> + regmap_write(pm4125->regmap, PM4125_DIG_SWR_INTR_CLEAR_0, 0); >>> + regmap_write(pm4125->regmap, PM4125_DIG_SWR_INTR_CLEAR_1, 0); >>> + regmap_write(pm4125->regmap, PM4125_DIG_SWR_INTR_CLEAR_2, 0); >>> + >>> + return IRQ_HANDLED; >>> +} > Do you mean that it should be: > > static int pm4125_handle_post_irq(void *data) > { > struct pm4125_priv *pm4125 = (struct pm4125_priv *)data; > > regmap_write(pm4125->regmap, PM4125_DIG_SWR_INTR_CLEAR_0, 0); > regmap_write(pm4125->regmap, PM4125_DIG_SWR_INTR_CLEAR_1, 0); > regmap_write(pm4125->regmap, PM4125_DIG_SWR_INTR_CLEAR_2, 0); > > return IRQ_HANDLED; > } yes. We can not return IRQ_HANDLED without clearing the pending interrupt source. --srini > > I need to fix irq_drv_data = NULL in pm4125_regmap_irq_chip then. > IIRC it is always NULL.