mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Libo Chen <libo.chen@oracle.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: peterz@infradead.org, mgorman@techsingularity.net,
	longman@redhat.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, tj@kernel.org
Subject: Re: [PATCH v2 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning
Date: Fri, 28 Mar 2025 16:16:29 -0700	[thread overview]
Message-ID: <4f5453e8-61b6-45d1-8c6c-8b4fb99a6448@oracle.com> (raw)
In-Reply-To: <5d29adc1-0f6b-4cf5-b4d6-2e9ed13273cf@oracle.com>



On 3/28/25 15:28, Libo Chen wrote:
> 
> 
> On 3/27/25 07:03, Steven Rostedt wrote:
>> On Wed, 26 Mar 2025 21:32:32 -0700
>> Libo Chen <libo.chen@oracle.com> wrote:
>>
>>> On 3/26/25 19:06, Steven Rostedt wrote:
>>>> On Wed, 26 Mar 2025 17:40:02 -0700
>>>> Libo Chen <libo.chen@oracle.com> wrote:
>>>>   
>>>>>> +	TP_printk("comm=%s pid=%d tgid=%d ngid=%d mem_node_allowed_mask=%lx",    
>>>>>
>>>>>
>>>>> I cannot find a way to print out nodemask_t nicely here with %*pbl.
>>>>> So I fall back to just raw hex value. Will be grateful if someone
>>>>> knows a better way to print nodemask nicely in a tracepoint    
>>>>
>>>> Ug.
>>>>
>>>> I guess I need to add support for that. Both in the boot verifier as well
>>>> as in libtraceevent.
>>>>   
>>>
>>> That will be fantastic, I think this is quite useful.
>>
> 
> Oops just saw this right now, not sure how I missed it.
>  
>> I'm curious to what was broken. Just the user space side? Or was the kernel
>> side broken too?
>>
> 
> That's a good point, I originally only tried %*pbl with trace-cmd, but I
> tested your patch without trace-cmd. So yeah %*pbl may already be working in
> the kernel, I will report back later today.
> 
> -- Libo
> 

Okay yes, it does prints out to trace log. Not seeing the output is due to the
userspace tool not the lack of check. 

-- Libo

>> I notice that i2c_write has "[%*phD]" which means it worked, and also
>> skipped out on the verification tests. This should be fixed.
>>
>> But trace-cmd and perf will not be able to print that out either.
>>
>> Now %*pbl works in the kernel (not checked), but probably doesn't work for
>> trace-cmd.
>>
>> -- Steve
> 


      reply	other threads:[~2025-03-28 23:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27  0:23 [PATCH v2 0/2] sched/numa: skip VMA scanning on memory pinned Libo Chen
2025-03-27  0:23 ` [PATCH v2 1/2] sched/numa: skip VMA scanning on memory pinned to one NUMA node via cpuset.mems Libo Chen
2025-04-01 13:23   ` Mel Gorman
2025-04-01 17:43     ` Libo Chen
2025-03-27  0:23 ` [PATCH v2 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Libo Chen
2025-03-27  0:40   ` Libo Chen
2025-03-27  2:06     ` Steven Rostedt
2025-03-27  4:32       ` Libo Chen
2025-03-27 14:03         ` Steven Rostedt
2025-03-28 22:28           ` Libo Chen
2025-03-28 23:16             ` Libo Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f5453e8-61b6-45d1-8c6c-8b4fb99a6448@oracle.com \
    --to=libo.chen@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®