From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
devicetree@vger.kernel.org,
Lucca Fachinetti <luccafachinetti@gmail.com>
Subject: Re: [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml
Date: Mon, 21 Jul 2025 13:16:46 +0200 [thread overview]
Message-ID: <4f57cca8-49a8-4431-b41c-78097eb11da9@kernel.org> (raw)
In-Reply-To: <20250721-leds-is31fl3236a-v5-1-264e841f4da9@thegoodpenguin.co.uk>
On 21/07/2025 12:55, Pawel Zalewski wrote:
> +
> +properties:
> + compatible:
> + enum:
> + - issi,is31fl3236
> + - issi,is31fl3235
> + - issi,is31fl3218
> + - issi,is31fl3216
Keep alphabetical order.
> + - si-en,sn3218
> + - si-en,sn3216
Here as well.
> +
> + reg:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^led@[1-9a-f][0-9a-f]*$":
This still does not match min/max constraints. You already got the
comment on this and nothing improved.
> + type: object
> + $ref: common.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + description:
> + LED channel number (1..N)
> + minimum: 0x1
> + maximum: 0x24
And these are supposed to be decimal.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-21 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 10:55 [PATCH v5 0/3] Add support for is31fl3236a LED controller Pawel Zalewski
2025-07-21 10:55 ` [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml Pawel Zalewski
2025-07-21 11:16 ` Krzysztof Kozlowski [this message]
2025-07-21 12:26 ` Pawel Zalewski
2025-07-21 12:34 ` Krzysztof Kozlowski
2025-07-21 10:55 ` [PATCH v5 2/3] dt-bindings: leds: issi,is31fl3236: add support for is31fl3236a Pawel Zalewski
2025-07-21 11:16 ` Krzysztof Kozlowski
2025-07-21 12:27 ` Pawel Zalewski
2025-07-21 10:55 ` [PATCH v5 3/3] leds/leds-is31fl32xx: " Pawel Zalewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f57cca8-49a8-4431-b41c-78097eb11da9@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luccafachinetti@gmail.com \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®