From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>, Babu Moger <babu.moger@amd.com>
Cc: Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
the arch/x86 maintainers <x86@kernel.org>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/3] KVM:SVM: Enable INVPCID feature on AMD
Date: Mon, 15 Jun 2020 15:46:53 +0200 [thread overview]
Message-ID: <4f5a7fca-02b3-4cd9-159c-59fcda3debd0@redhat.com> (raw)
In-Reply-To: <CALMp9eSn36W=YK5XtaVATJis-J--udGK4ZOESDhYyT0zJ4YZ9A@mail.gmail.com>
On 13/06/20 02:04, Jim Mattson wrote:
>> I think I have misunderstood this part. I was not inteding to change the
>> #GP behaviour. I will remove this part. My intension of these series is to
>> handle invpcid in shadow page mode. I have verified that part. Hope I did
>> not miss anything else.
> You don't really have to intercept INVPCID when tdp is in use, right?
> There are certainly plenty of operations for which kvm does not
> properly raise #UD when they aren't enumerated in the guest CPUID.
>
Indeed; for RDRAND and RDSEED it makes sense to do so because the
instructions may introduce undesirable nondeterminism (or block all the
packages in your core as they have been doing for a few weeks).
Therefore on Intel we trap them and raise #UD; on AMD this is not
possible because RDRAND has no intercept.
In general however we do not try to hard to raise #UD and that is
usually not even possible.
Paolo
next prev parent reply other threads:[~2020-06-15 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 21:48 [PATCH 0/3] INVPCID support for the AMD guests Babu Moger
2020-06-11 21:48 ` [PATCH 1/3] KVM: X86: Move handling of INVPCID types to x86 Babu Moger
2020-06-12 18:02 ` Jim Mattson
2020-06-12 20:06 ` Babu Moger
2020-06-11 21:48 ` [PATCH 2/3] KVM:SVM: Add extended intercept support Babu Moger
2020-06-11 21:48 ` [PATCH 3/3] KVM:SVM: Enable INVPCID feature on AMD Babu Moger
2020-06-11 23:50 ` Jim Mattson
2020-06-12 19:35 ` Babu Moger
2020-06-12 20:10 ` Jim Mattson
2020-06-12 21:47 ` Babu Moger
2020-06-13 0:04 ` Jim Mattson
2020-06-15 13:46 ` Paolo Bonzini [this message]
2020-06-15 14:59 ` Babu Moger
2020-06-15 13:47 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f5a7fca-02b3-4cd9-159c-59fcda3debd0@redhat.com \
--to=pbonzini@redhat.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome