mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Thomas Weißschuh" <thomas@weissschuh.net>,
	"Mark Gross" <markgross@kernel.org>,
	"Jeremy Soller" <jeremy@system76.com>,
	"System76 Product Development" <productdev@system76.com>,
	"Azael Avalos" <coproscefalo@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/4] platform/x86: gigabyte: constify pointers to hwmon_channel_info
Date: Tue, 11 Apr 2023 10:31:37 +0200	[thread overview]
Message-ID: <4f609a98-6376-5993-45aa-bb5c6a213a49@redhat.com> (raw)
In-Reply-To: <20230407150339.80218-1-krzysztof.kozlowski@linaro.org>

Hi,

On 4/7/23 17:03, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> This depends on hwmon core patch:
> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
> 
> Therefore I propose this should also go via hwmon tree.

Ok, taking all 4 these patches upstream through the hwmon tree
is fine by me, here is my Ack for that:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


p.s.

I'm going to drop these from my patch queue now. If for some
reason merging these through the hwmon tree does not work out,
please resend them after 6.4-rc1 is out (assuming that will
have the pre-requisite patch) and then I'll apply them directly.





> 
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-hwmon@vger.kernel.org
> ---
>  drivers/platform/x86/gigabyte-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index 5e5b17c50eb6..7cc969fb1beb 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -99,7 +99,7 @@ static umode_t gigabyte_wmi_hwmon_is_visible(const void *data, enum hwmon_sensor
>  	return usable_sensors_mask & BIT(channel) ? 0444  : 0;
>  }
>  
> -static const struct hwmon_channel_info *gigabyte_wmi_hwmon_info[] = {
> +static const struct hwmon_channel_info * const gigabyte_wmi_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(temp,
>  			   HWMON_T_INPUT,
>  			   HWMON_T_INPUT,


      parent reply	other threads:[~2023-04-11  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 15:03 Krzysztof Kozlowski
2023-04-07 15:03 ` [PATCH 2/4] platform/x86: hp: " Krzysztof Kozlowski
2023-04-07 15:03 ` [PATCH 3/4] platform/x86: system76: " Krzysztof Kozlowski
2023-04-07 15:03 ` [PATCH 4/4] platform/x86: toshiba: " Krzysztof Kozlowski
2023-04-11  8:31 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f609a98-6376-5993-45aa-bb5c6a213a49@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=coproscefalo@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=jeremy@system76.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=productdev@system76.com \
    --cc=thomas@weissschuh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®