From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F3162AEE4 for ; Fri, 30 Jan 2026 09:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769767164; cv=none; b=pMSIIcMX5mkqutK1NrIql+ooLx5VJud6NC+9kFMB9u3FWFFCITg/aeJAUrf8+XLN+1MgPXyvzei65puYxa1DLuo0wtcDMbQzSucGlmz1s89zrkOK+kVugoLmHCjG8ZZ7/44CozViJtVaRwQRZaaEOt9ScWxBGPqdjhI8p6+TIuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769767164; c=relaxed/simple; bh=y+ld/lU540REhCwUO2kGbqIBRB63NO2FgB2v6hUzuQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gtzZ8IIYpWVUkaswpKdFy+AL1R0/gZd0KllctJThsN7BC+ewYqBzpC2vHK3TxOe4Swta/7/osOxyj1qp//rUW7FB4gEMaYF34X1QzyJzbZ/TZR/OPV6n/1JTF82AMOJqY5SV2RbtrNbbRSGGkkCyMhfRQTwI0p6068gZ3NxbVHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kg10Vuxq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WEVptrwi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kg10Vuxq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WEVptrwi" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60U4bRb11485339 for ; Fri, 30 Jan 2026 09:59:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eC8XP++LfeEAqnsmOumYbjOL/tAKd5tjfsWvrjLtYtk=; b=Kg10VuxqFJWyfPU9 rcCfABCZr4Nd7QdhQJbZc0hFZ+rnVV9NmEH3h+P5zzUqeUTw1URxncnn+k73fCBA 7l4nCQ7+o775DZi41jzXthas/ZsMN5l8yyQMLAc9wyZdySRjVqkw9D7Y5jWLMpH8 dBUMEgXJ/+1FgGHFYOf1OtiQYWPPMTplZhCNsVs7URigPZDXYxm7jbYw+Iv027RP JK1AQqHbJD01/BTPL7xW2jgVp/L+ChPKFI5H+oQP+8mbDJnhUneE+UxTBSV/uE4b 60/kmAhp4DjCHmPJNxxXe3N7ByMKyBdeK2xPeko0EJCEUj+rbU7lusA7058jRuRU S5yyOA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0nsf8wp8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 09:59:22 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8946586903dso1590256d6.3 for ; Fri, 30 Jan 2026 01:59:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769767162; x=1770371962; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eC8XP++LfeEAqnsmOumYbjOL/tAKd5tjfsWvrjLtYtk=; b=WEVptrwiL1nhhz3RMuzycLEzrLmqMibMP5MDlTklg0W1J62PhTD5az1c/UL89kXEZJ R0QE9Y+fLFzYX362/JC5YrSPEyxM8e/fkRJ4UQ/hSSCiS2FtRkn1+Gv1Uh8fkRUUBPGy +Ozz/OHe0Judpd5u65TGthvZJ5hQOl9hxsf4z1I6oRX9oaVHXF9/y5NSeu5WsLsyAUlU uehjdnUqYJPHohRot17emLl0XmQDuckE5O/lZsh2c61xG04267AnNqd7HHfzFmGRsRMx eZd8S80BOXrnrUsoSi5W5Nb6/GAOlLAKyulIyA/xjTdfRcNu7DTl4M4sbq7jPBRyfABX JHfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769767162; x=1770371962; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eC8XP++LfeEAqnsmOumYbjOL/tAKd5tjfsWvrjLtYtk=; b=aUMq5wuMGk5ciSiK75K+l9JDlduwe+KO/116q5ATKwlZVd8UdafTI6hGOhDW9mnVAD bh/ZqgYXOoIHUwNHgAvqolWzu5+riBR+CXbGP7qK+53Ffi45FyvOrmLfc5U2bhDctVpM KjE5vE+rYqKWQghQRH4mbaF2qV9ZoDm2GzYHtUtdE3/+E9pz0r3K9vOnUcAf0gyYncQX 5tsbl6xVzwLVsd9gtkitKsQM/6HcGPZRybI47sC8csg3me8wBhbN+LwyMggicGXjgPPF SIPDJjdnS68VPtz+qtbgFlu06FZsIwloqN5T6Brl/yyJp3W0xuS2hR5ATU4dzZJn3TEm BT1w== X-Forwarded-Encrypted: i=1; AJvYcCXvIMiWu+547msBHGZb56Wi+2NEzhyb3h8bfxNEL7Pku1NxrxEZslgWghRkUSHYu5mOEb3pYotVjcjhnx4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz54f5K2f79B4ZlZlkXO7l1Mt6lnwabmAP1R6xFpLn6DPYdVNB9 iFggRPbCuYAltkzaFjNGjaXb5pHzKDCHPUTgpMIBHNMaB+rGWGPKaYeuahal2IPN2w7ZwJ1bA8z VWHpa0hsR26tTw0hazoSjpsdXrcwu8N3ZmjuvB51ZEv+qPUz4pYs2dPsXXjbMXcjrxlU= X-Gm-Gg: AZuq6aLNInqZDupqSqp/CX+Lv1Q7LyHMyQq+MHhZ3KBhCaxoB4OKAH9QK/8sHKXS9MO zKD1C8uKa/aebybxXqqLCyT6eOLIzsloT6AU58kSiSwYLY00MTEO7VWZeD7LkMwt4h+mi40uplo 1AuYtNaWthMZdw+SzL+a9XMbKiCS+HkWbod7x7wVib5zVILEQbXVXY6yc4uj1kCYFWtJcjhuxPo ekwIIPCVbv7NTEWahJn7kaWsQ63LseOi0cBc/9ttksqt4uAyf77TeZbLM8+svHa0PgqQ6oqpcNp oKyG09lwLQWJD3CmHLWAk6KVCjdzccfpzoqe4hQ+R258JOd/zqLJ54DW/RV2U5SCD8ZSUQZUWiR dP6rtAXMmO/knkWvhsTnDQ+vMfDO6cos2EQ3etzB9/9DXVx8xuCnSkNZsM51prWLXpkw= X-Received: by 2002:a05:620a:25d2:b0:8c5:3699:97d9 with SMTP id af79cd13be357-8c9eb2eb845mr211649185a.7.1769767161657; Fri, 30 Jan 2026 01:59:21 -0800 (PST) X-Received: by 2002:a05:620a:25d2:b0:8c5:3699:97d9 with SMTP id af79cd13be357-8c9eb2eb845mr211647885a.7.1769767161186; Fri, 30 Jan 2026 01:59:21 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e0a5a3b1asm61732766b.57.2026.01.30.01.59.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 01:59:20 -0800 (PST) Message-ID: <4f629971-94cb-44aa-9502-4f5ebfd63937@oss.qualcomm.com> Date: Fri, 30 Jan 2026 10:59:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: ice: Avoid probe deferring for un-supported ICE feature To: Sumit Garg , Rob Herring Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, abelvesa@kernel.org, mani@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg References: <20260130091118.147379-1-sumit.garg@kernel.org> <4ad700f3-da8f-4175-9172-3fc4d87d8152@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 6jLpsyAQvYDuA0eU4IxDyUbLnNHky5ir X-Authority-Analysis: v=2.4 cv=EvjfbCcA c=1 sm=1 tr=0 ts=697c80fa cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=T2EDkwNYl7ncRtK5NtwA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: 6jLpsyAQvYDuA0eU4IxDyUbLnNHky5ir X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA4MCBTYWx0ZWRfX7dkCJTzeNdjI etYwTPUMG1A4f6PrqS7KmX90145DyTD0+gcbb8mKF4KkEd8Wved82PPeDljLQ6FPB63d3KRIxB0 zMz9Qdhhb3A6XzZU7sa93oH3WnmDRe6NgL7m26INGR2M/WRrCthMR/zZN/WuxdWMZq4Sf85b/0g sRX6g/HqpXADv7/DW2L7iDmjvOBUk9bOghPfFdHORHORcCOy5aG+ktlLEpVKccrcmlWwkt+M3co XJBZ6v7s3KRrcXX5a299x0Kig69xCdu6tlVQ7Z6zH2QRX5tpK/5yq7D+ZYPZ8UIZzDwIvci2slu fUt1ImN4KLeTbARAabiw/DKgC+oJbksmPVcqN4QyBAKr83DduGKiwjBREWNqhAbI7WXDVf8YGJn /FE8WV/519Jq7usKtVmMEyekMO20KwzdC0q9PLvYmnXwwTq+inlQXQwY0r8PwA0L2t7ObciuJ6d Po68C8sfMLd6CvG6yfg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_01,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300080 On 1/30/26 10:52 AM, Sumit Garg wrote: > On Fri, Jan 30, 2026 at 10:34:26AM +0100, Konrad Dybcio wrote: >> On 1/30/26 10:11 AM, Sumit Garg wrote: >>> From: Sumit Garg >>> >>> ICE related SCM calls may not be supported in every TZ environment like >>> OP-TEE or a no-TZ environment too. So let's try to avoid probe deferring >>> when it's known that ICE feature isn't supported. >>> >>> This problem only came to notice after the inline encryption drivers were >>> enabled in the arm64 defconfig by: commit 5f37788adedd ("arm64: defconfig: >>> Enable SCSI UFS Crypto and Block Inline encryption drivers"). >>> >>> Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") >>> Signed-off-by: Sumit Garg >>> --- >>> drivers/soc/qcom/ice.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c >>> index b203bc685cad..ab9586b8caf5 100644 >>> --- a/drivers/soc/qcom/ice.c >>> +++ b/drivers/soc/qcom/ice.c >>> @@ -652,7 +652,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev) >>> dev_err(dev, "Cannot get ice instance from %s\n", >>> dev_name(&pdev->dev)); >>> platform_device_put(pdev); >>> - return ERR_PTR(-EPROBE_DEFER); >>> + return NULL; >> >> Wouldn't this wreck the "actually need to defer" case, i.e. >> >> >> qcom,ufs probes first >> calls devm_of_qcom_ice_get() >> "ice" reg is missing, non-legacy case >> qcom,ice is absent (not yet probed) >> return NULL >> >> ... >> >> qcom,ice probes >> >> ? > > Since qcom,ufs depends on qcom,ice via a phandle, so isn't the probe > orderering automatically taken care off? Or that isn't the case here? No, that's guaranteed by devlink only with certain properties. In this case though, I think it could make sense to add it to the "suppliers" list in drivers/of/property.c. I don't know if vendors adding their custom properties there is a pattern that +Rob will be happy about though.. Konrad