mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] misc/fsa9480: Improve a size determination in fsa9480_probe()
Date: Sun, 7 Jan 2018 22:30:12 +0100	[thread overview]
Message-ID: <4f62f094-3b5c-7c13-8b9f-1d2da9b1baf4@users.sourceforge.net> (raw)
In-Reply-To: <afa46cf0-1a3a-e311-7fbd-d63a23785b16@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 Jan 2018 22:20:19 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/misc/fsa9480.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c
index 4d7f763195bc..bf199cd5fce9 100644
--- a/drivers/misc/fsa9480.c
+++ b/drivers/misc/fsa9480.c
@@ -417,7 +417,7 @@ static int fsa9480_probe(struct i2c_client *client,
 	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
 		return -EIO;
 
-	usbsw = kzalloc(sizeof(struct fsa9480_usbsw), GFP_KERNEL);
+	usbsw = kzalloc(sizeof(*usbsw), GFP_KERNEL);
 	if (!usbsw)
 		return -ENOMEM;
 
-- 
2.15.1

      parent reply	other threads:[~2018-01-07 21:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-07 21:28 [PATCH 0/2] misc/fsa9480: Adjustments for fsa9480_probe() SF Markus Elfring
2018-01-07 21:29 ` [PATCH 1/2] misc/fsa9480: Delete an error message for a failed memory allocation in fsa9480_probe() SF Markus Elfring
2018-01-07 21:30 ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f62f094-3b5c-7c13-8b9f-1d2da9b1baf4@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®