mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Paul Moore <paul@paul-moore.com>,
	eparis@redhat.com, linux-security-module@vger.kernel.org,
	audit@vger.kernel.org
Cc: jmorris@namei.org, serge@hallyn.com, keescook@chromium.org,
	john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
	stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
	selinux@vger.kernel.org, Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH v5 4/5] Audit: Fix indentation in audit_log_exit
Date: Tue, 5 Aug 2025 16:06:37 -0700	[thread overview]
Message-ID: <4f6c9294-dfb3-45cf-8f46-c1a0063d2921@schaufler-ca.com> (raw)
In-Reply-To: <d5f0d7a5edea8511ab4467e0fb225b8b@paul-moore.com>

On 8/5/2025 12:39 PM, Paul Moore wrote:
> On Jul 16, 2025 Casey Schaufler <casey@schaufler-ca.com> wrote:
>> Fix two indentation errors in audit_log_exit().
>>
>> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
>> ---
>>  kernel/auditsc.c | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
> As this is indepdendent of all the other changes in this patchset, I'm
> going to merge this into audit/dev-staging now and audit/dev later when
> the merge window is closed.

Spiffy. Thank You.

>
>> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
>> index 322d4e27f28e..84173d234d4a 100644
>> --- a/kernel/auditsc.c
>> +++ b/kernel/auditsc.c
>> @@ -1780,15 +1780,16 @@ static void audit_log_exit(void)
>>  						  axs->target_sessionid[i],
>>  						  &axs->target_ref[i],
>>  						  axs->target_comm[i]))
>> -				call_panic = 1;
>> +			call_panic = 1;
>>  	}
>>  
>>  	if (context->target_pid &&
>>  	    audit_log_pid_context(context, context->target_pid,
>>  				  context->target_auid, context->target_uid,
>>  				  context->target_sessionid,
>> -				  &context->target_ref, context->target_comm))
>> -			call_panic = 1;
>> +				  &context->target_ref,
>> +				  context->target_comm))
>> +		call_panic = 1;
>>  
>>  	if (context->pwd.dentry && context->pwd.mnt) {
>>  		ab = audit_log_start(context, GFP_KERNEL, AUDIT_CWD);
>> -- 
>> 2.50.1
> --
> paul-moore.com

  reply	other threads:[~2025-08-05 23:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250716212731.31628-1-casey.ref@schaufler-ca.com>
2025-07-16 21:27 ` [PATCH v5 0/5] Audit: Records for multiple security contexts Casey Schaufler
2025-07-16 21:27   ` [PATCH v5 1/5] Audit: Create audit_stamp structure Casey Schaufler
2025-07-16 21:27   ` [PATCH v5 2/5] LSM: security_lsmblob_to_secctx module selection Casey Schaufler
2025-07-16 21:27   ` [PATCH v5 3/5] Audit: Add record for multiple task security contexts Casey Schaufler
2025-08-05 19:39     ` Paul Moore
2025-08-06 16:03       ` Casey Schaufler
2025-07-16 21:27   ` [PATCH v5 4/5] Audit: Fix indentation in audit_log_exit Casey Schaufler
2025-08-05 19:39     ` Paul Moore
2025-08-05 23:06       ` Casey Schaufler [this message]
2025-08-11 22:21         ` Paul Moore
2025-07-16 21:27   ` [PATCH v5 5/5] Audit: Add record for multiple object contexts Casey Schaufler
2025-08-16 16:41 [PATCH v5 0/5] Audit: Records for multiple security contexts Casey Schaufler
2025-08-16 16:41 ` [PATCH v5 4/5] Audit: Fix indentation in audit_log_exit Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f6c9294-dfb3-45cf-8f46-c1a0063d2921@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=audit@vger.kernel.org \
    --cc=eparis@redhat.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=selinux@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®