From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"zhongjiang@huawei.com" <zhongjiang@huawei.com>,
"aacraid@microsemi.com" <aacraid@microsemi.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] scsi:qla1280: remove unnessary same condition check
Date: Thu, 2 Aug 2018 03:22:36 +0000 [thread overview]
Message-ID: <4f6e32d59aec6a75332b36377ed719dda293fe45.camel@wdc.com> (raw)
In-Reply-To: <1533177901-19514-2-git-send-email-zhongjiang@huawei.com>
On Thu, 2018-08-02 at 10:45 +0800, zhong jiang wrote:
> doulbe test in a expression is redundant. so just remove one of
> them.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/scsi/qla1280.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> index 390775d..8e6f156 100644
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -1504,7 +1504,6 @@ static void qla1280_mailbox_timeout(struct timer_list *t)
> /* Issue SCSI reset, if we can't reset twice then bus is dead */
> for (bus = 0; bus < ha->ports; bus++) {
> if (!ha->bus_settings[bus].disable_scsi_reset &&
> - qla1280_bus_reset(ha, bus) &&
> qla1280_bus_reset(ha, bus))
> ha->bus_settings[bus].scsi_bus_dead = 1;
> }
Same question here: does qla1280_bus_reset() have any side effects?
Bart.
next prev parent reply other threads:[~2018-08-02 3:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 2:44 [PATCH 0/2] remove double test condition zhong jiang
2018-08-02 2:45 ` [PATCH 1/2] scsi:qla1280: remove unnessary same condition check zhong jiang
2018-08-02 3:22 ` Bart Van Assche [this message]
2018-08-02 2:45 ` [PATCH 2/2] scsi:qlogicfas408: remove the same check in qlogicfas408_detect zhong jiang
2018-08-02 3:21 ` Bart Van Assche
2018-08-02 3:29 ` zhong jiang
2018-08-02 3:52 ` Bart Van Assche
2018-08-02 4:00 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6e32d59aec6a75332b36377ed719dda293fe45.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=aacraid@microsemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®