From: Pankaj Raghav <p.raghav@samsung.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>, <hch@lst.de>,
<axboe@kernel.dk>, <snitzer@kernel.org>,
<Johannes.Thumshirn@wdc.com>
Cc: <matias.bjorling@wdc.com>, <gost.dev@samsung.com>,
<linux-kernel@vger.kernel.org>, <hare@suse.de>,
<linux-block@vger.kernel.org>, <pankydev8@gmail.com>,
<bvanassche@acm.org>, <jaegeuk@kernel.org>, <dm-devel@redhat.com>,
<linux-nvme@lists.infradead.org>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH v8 04/11] nvmet: Allow ZNS target to support non-power_of_2 zone sizes
Date: Fri, 29 Jul 2022 09:45:26 +0200 [thread overview]
Message-ID: <4f6f9ea5-fac6-598d-fcaa-3cb24cb2d935@samsung.com> (raw)
In-Reply-To: <137b8772-a2cc-f195-1c0d-476214fabd52@opensource.wdc.com>
On 2022-07-28 05:09, Damien Le Moal wrote:
>> }
>
> This change should go into patch 3. Otherwise, adding patch 3 only will
> break the nvme target zone code.
>
Ok.
>>
>> static unsigned long get_nr_zones_from_buf(struct nvmet_req *req, u32 bufsize)
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 1be805223026..d1ef9b9552ed 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -1350,6 +1350,11 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
>> return BLK_ZONED_NONE;
>> }
>>
>> +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec)
>> +{
>> + return disk_zone_no(bdev->bd_disk, sec);
>> +}
>> +
>
> This should go into a prep patch before patch 3.
>
Bart commented in the earlier versions to see the new helpers along with
its usage instead of having it separately in a prep patch.
>> static inline int queue_dma_alignment(const struct request_queue *q)
>> {
>> return q ? q->dma_alignment : 511;
>
>
next prev parent reply other threads:[~2022-07-29 7:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220727162246eucas1p1a758799f13d36ba99d30bf92cc5e2754@eucas1p1.samsung.com>
2022-07-27 16:22 ` [PATCH v8 00/11] support non power of 2 zoned device Pankaj Raghav
[not found] ` <CGME20220727162247eucas1p203fc14aa17ecbcb3e6215d5304bb0c85@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 01/11] block: make bdev_nr_zones and disk_zone_no generic for npo2 zsze Pankaj Raghav
2022-07-28 2:54 ` Damien Le Moal
[not found] ` <CGME20220727162248eucas1p2ff8c3c2b021bedcae3960024b4e269e9@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 02/11] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-07-27 23:16 ` Bart Van Assche
2022-07-28 12:11 ` Pankaj Raghav
2022-07-28 13:29 ` Bart Van Assche
2022-07-29 9:09 ` Pankaj Raghav
2022-07-28 3:07 ` Damien Le Moal
2022-07-28 12:24 ` Pankaj Raghav
[not found] ` <CGME20220727162249eucas1p28fa44c840e590f6f1b53e0cc12ee3771@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 03/11] nvme: zns: Allow ZNS drives that have non-power_of_2 " Pankaj Raghav
[not found] ` <CGME20220727162250eucas1p133e8a814fee934f7161866122ef93273@eucas1p1.samsung.com>
2022-07-27 16:22 ` [PATCH v8 04/11] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
2022-07-28 3:09 ` Damien Le Moal
2022-07-29 7:45 ` Pankaj Raghav [this message]
[not found] ` <CGME20220727162251eucas1p12939ac3864fd8705ae139eb2d1087d8f@eucas1p1.samsung.com>
2022-07-27 16:22 ` [PATCH v8 05/11] null_blk: allow non power of 2 zoned devices Pankaj Raghav
2022-07-27 21:59 ` Chaitanya Kulkarni
2022-07-29 7:51 ` Pankaj Raghav
2022-07-28 3:14 ` Damien Le Moal
[not found] ` <CGME20220727162252eucas1p25be8b79231334fa0c759c2475859e93b@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 06/11] zonefs: " Pankaj Raghav
2022-07-28 3:16 ` Damien Le Moal
[not found] ` <CGME20220727162253eucas1p1a5912e0494f6918504cc8ff15ad5d31f@eucas1p1.samsung.com>
2022-07-27 16:22 ` [PATCH v8 07/11] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-07-28 3:18 ` Damien Le Moal
2022-07-28 12:15 ` David Sterba
2022-07-29 8:00 ` Pankaj Raghav
[not found] ` <CGME20220727162254eucas1p1fd990f746d9f9870b8d58ee0bd01fedd@eucas1p1.samsung.com>
2022-07-27 16:22 ` [PATCH v8 08/11] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-07-28 3:20 ` Damien Le Moal
[not found] ` <CGME20220727162255eucas1p2945c6dca42b799bb3b4abf3edb83dde8@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 09/11] dm-table: allow non po2 zoned devices Pankaj Raghav
2022-07-28 3:22 ` Damien Le Moal
[not found] ` <CGME20220727162256eucas1p284a15532173cce3eca46eee0cee3acdd@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 10/11] dm: call dm_zone_endio after the target endio callback for " Pankaj Raghav
2022-07-28 3:25 ` Damien Le Moal
2022-07-29 8:48 ` Pankaj Raghav
[not found] ` <CGME20220727162257eucas1p2848a75c4aa7e559abb5d9ae0fbd374c1@eucas1p2.samsung.com>
2022-07-27 16:22 ` [PATCH v8 11/11] dm: add power-of-2 zoned target for non-power-of-2 " Pankaj Raghav
2022-07-28 4:33 ` Damien Le Moal
2022-08-01 8:35 ` Pankaj Raghav
2022-07-27 23:19 ` [PATCH v8 00/11] support non power of 2 zoned device Bart Van Assche
2022-07-28 1:52 ` Damien Le Moal
2022-07-28 2:58 ` Bart Van Assche
2022-07-28 3:28 ` Damien Le Moal
2022-07-28 11:57 ` Pankaj Raghav
2022-07-28 13:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f6f9ea5-fac6-598d-fcaa-3cb24cb2d935@samsung.com \
--to=p.raghav@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias.bjorling@wdc.com \
--cc=mcgrof@kernel.org \
--cc=pankydev8@gmail.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®