From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add declare_ to declaring macros
Date: Fri, 14 May 2021 23:55:36 -0700 [thread overview]
Message-ID: <4f757b9bab4c9575f0257db6b9ed5a75419a3420.camel@perches.com> (raw)
In-Reply-To: <YJ9dDwKMKkifeICJ@kroah.com>
On Sat, 2021-05-15 at 07:33 +0200, Greg KH wrote:
> On Sat, May 15, 2021 at 09:11:16AM +0530, Shreyansh Chouhan wrote:
> > Prefixed the names of all the macros that were used for declaring things
> > with 'declare_'. This should help with clarifying about what these
> > macros do.
>
> Thanks, but I think I will leave the code as-is. It's a good "test" for
> people who try to modify the code without actually building it :)
This improves the code for the human reader.
I think wherever reasonable, code should be improved.
In any case, it's a test as checkpatch will emit the same message.
prev parent reply other threads:[~2021-05-15 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 3:41 Shreyansh Chouhan
2021-05-15 5:33 ` Greg KH
2021-05-15 5:58 ` Shreyansh Chouhan
2021-05-15 6:55 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f757b9bab4c9575f0257db6b9ed5a75419a3420.camel@perches.com \
--to=joe@perches.com \
--cc=chouhan.shreyansh630@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®