mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Thierry Reding <treding@nvidia.com>
Subject: Re: [BUG] 6.16-rc7: lockdep failure with max77620-gpio/max77686-rtc
Date: Thu, 31 Jul 2025 14:18:24 +0100	[thread overview]
Message-ID: <4f80be02-0bbe-4c10-a3d2-324916ea2ca4@sirena.org.uk> (raw)
In-Reply-To: <aItk4vWPnFk6lYjn@shell.armlinux.org.uk>

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

On Thu, Jul 31, 2025 at 01:43:14PM +0100, Russell King (Oracle) wrote:
> On Thu, Jul 31, 2025 at 01:31:32PM +0100, Mark Brown wrote:

> > Yes, your analysis is right here - it's not come up before because it's
> > very rare to chain regmap-irq chips.

> Yep, I just changed all the "d" variables in regmap-irq to "ricd"
> (first letter of the each word of the struct name), and lockdep
> confirms that it's the mutex.

> I'm not familiar enough with lockdep to know how to fix this, so what's
> the solution here?

I *think* mutex_lock_nested() is what we're looking for here, with the
depth information from the irq_desc but I'm also not super familiar with
this stuff.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-07-31 13:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 17:58 Russell King (Oracle)
2025-07-30 19:43 ` Krzysztof Kozlowski
2025-07-31 12:18   ` Russell King (Oracle)
2025-07-31 12:31     ` Mark Brown
2025-07-31 12:43       ` Russell King (Oracle)
2025-07-31 13:18         ` Mark Brown [this message]
2025-07-31 15:57           ` Russell King (Oracle)
2025-07-31 16:16             ` Mark Brown
2025-07-31 16:28               ` Russell King (Oracle)
2025-07-31 17:03                 ` Mark Brown
2025-07-31 19:20                   ` Russell King (Oracle)
2025-07-31 19:50                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f80be02-0bbe-4c10-a3d2-324916ea2ca4@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=brgl@bgdev.pl \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®