From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3E8738E5C9 for ; Tue, 24 Feb 2026 12:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771934995; cv=none; b=YpNXjUTJt2gMa4Mk3uml1sxWr465tGSj0G0w77FLyH+1R3mja60lt9hrz5sei9XEWeEDYHXnMZ86HSNI8dsmQtiufe/KS+y8rvWTQL/U6eQ0OWEDxFiwMlZOQtKDji60W917JspT2Y9W1OmARNC8dRwKD+RBHaMo26J4FIQT5Ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771934995; c=relaxed/simple; bh=AfOqYjknMePIFE+Z52QoCr/zw+xeW6yW1SGuBhqYl3U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ShnYpdXcQglcKm/NiQjcP4zF/NmV+p0Q3gd574qLXV17a+cQojkjiY8NphKc9pph+F7EwCXMebSJFbXwZwBKgFjj8xmgJpUKsy1HwXjdy/cVMagyhd2NTeWFrkzkrEWrA5sjJ26rDdNkO3QcHWJwfl+jW9RjAMEwjIyzoGp5w7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jiwtkV2n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N8VZZJQ5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jiwtkV2n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N8VZZJQ5" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61OAFQK03570192 for ; Tue, 24 Feb 2026 12:09:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j4gCCgG0BuqngRyFLK+QoLhgoiqWJB1YBIfGO3afyig=; b=jiwtkV2n9IK1Y0oq zFbzRSXapEk33kD22328KqEVTOCTT6zL+ZAApJMP/LqlfOpdrjAQN4fdmfHB7bgJ KPFDt2I4eMsHTmzId9b/xTgpHo03FW4BfSjR4fHnPJyzQlwB59Hn3Mv/pGcu9qlu YIwcCAbKkESdSVJA1uCRAsZITmjitGc9IW6b6DcfbGMAxwXi5/U6Mm5TL88lUWkX VWd2W4S40JnQrtZN+Ob9neDG2M/RYguwgiLjT48pRuC0zG9YUz+Vm8yTaF6cSxeW dwHb4CBu819HP4rCX3BhuulEbTPJK01N0qRLVfCMBHCAYkC/l3XCjbDQ+0R0Ds7N 9v3Uqg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn8rc5qw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 12:09:50 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a75ed2f89dso51441155ad.1 for ; Tue, 24 Feb 2026 04:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771934990; x=1772539790; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j4gCCgG0BuqngRyFLK+QoLhgoiqWJB1YBIfGO3afyig=; b=N8VZZJQ5H+5p1tb1mgXVHk1blsxWjJnbPgCaLRLpTtrvcF1E+3rJ9co3qggVNwa5BN SRFvu30Uw/Hgy8hxpWuouBftI1kKlBItqstVe5hGYODveenmQd7IgX94QEMVoR4ycuSA n9fNF2meUjwefLEt4GUd5QfbjGKyto8aBvwaFQdQOTkvqR5ShKXnJeVfavuT7/GscvNT AU0TuebY6ilQvQn8TpZ6WfjxdK+MdCGQF8BBgHU/TBJ5ucVQlWBZEU4ZYTlODSfaIv3f Xh4IrUUyCWrFbNRzFqx5k4AsxyZkOxWoZ0HInFuG0vY+/+9VCYfKxYkgUcl9osC/dhpO +dgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771934990; x=1772539790; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j4gCCgG0BuqngRyFLK+QoLhgoiqWJB1YBIfGO3afyig=; b=Ehkoc+e2kQBm1tVnfCBvd7BfvSpP3XJ66GYhdjM+1dP18soz5CmunHJVQMZn10sqhW 0H0alKBms4CArewgVqK4+KK03FnuVwLrkGcPic3/tKSOyfQEtKpP+TC9UV9hsZ373DHz d64JUAodP7g6U9xav1BbtorkxXOO9pjcgz1pAZP/eML/DSisxj/TdxF62t+EziLIVW5V Gqhp/oTifGmxhT9L8LwLSCDOzoe8knaeC09xjgh4RQL4RQo/nINLtX03YlHQqYqWC+wS KiC2FAWU1uzg6I3aUNL20z5ATGSl6+pXi8UsSYDK5ivUZtMjkS1wEqKF9YeNhFpqs9+/ 45Qg== X-Forwarded-Encrypted: i=1; AJvYcCUIxg6IHU4Hk5R9jRM/2LQgqdF1GLevosRpj7RrR4IDwsQijc4dpEKjMLKv1bcfZPlIL5En7LXfPwOxQQE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0Aoba4C8Tc57kYijOdG6mS7y54nyc58YgiquofWVCf4YOLib0 aAlYXURBJ8vZ1hNYmJlPFkFzC1rAQWTi1u16FcsIPIypeRB0oR7aqwgK1rdVzWpGw8x5pMKh9rm 10qmfsHrl+Mu9MJDholfSssX0I+HwL4IXACnxRaX5f+/E6wtWWSHeJhvxYAFw61hrxZ8= X-Gm-Gg: ATEYQzyVSGZHSvTHAxFNTrXhquGRKM+LC6w1c9OII+oqn0j+31KO7jx9A28TJSU+bhQ /JxdyP13ulRH02mmaFLwd7m2GN+vC0A97EBRjHeBOGQN0EyFnDX44g723hK600NRx3VakARUMAI Fs3MPFjY5g0zC9dIKJyhrF6aDOzAefnhH4qAlY+hf3nDFpK5H5x1nskViFn0RK2wPhytmdcaBhE hH5mOH1Lv9QK0mtcipfppIoJ9gGyGrWKhog+jZ61rKhNzDTn76CAMcEqa0yseWQ1UMRB/q+0zp5 AWZAJB3nRGYuGFcvFhsyvWj0phO7Y98nNjbxFzEOUbi/jGlLZSFo2R/bVADcheVNN/niIreAY2I /JWu4/DwX5l8ljlB1wG5qPph59wiMMYI3dRMsyg+YKHnBxpE7sy4= X-Received: by 2002:a17:902:ce81:b0:29e:c2dd:85ea with SMTP id d9443c01a7336-2ad74455891mr118333345ad.11.1771934990289; Tue, 24 Feb 2026 04:09:50 -0800 (PST) X-Received: by 2002:a17:902:ce81:b0:29e:c2dd:85ea with SMTP id d9443c01a7336-2ad74455891mr118333105ad.11.1771934989785; Tue, 24 Feb 2026 04:09:49 -0800 (PST) Received: from [10.218.12.237] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adb1bd6b05sm12153785ad.79.2026.02.24.04.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 04:09:49 -0800 (PST) Message-ID: <4f815a0f-a815-4b77-a4cf-a4b18e776eab@oss.qualcomm.com> Date: Tue, 24 Feb 2026 17:39:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml bindings To: Krzysztof Kozlowski Cc: andersson@kernel.org, mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, mani@kernel.org, casey.connolly@linaro.org, amit.kucheria@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, manaf.pallikunhi@oss.qualcomm.com References: <20260127155722.2797783-1-gaurav.kohli@oss.qualcomm.com> <20260127155722.2797783-3-gaurav.kohli@oss.qualcomm.com> <20260128-whispering-caracal-of-respect-a26638@quoll> <36706481-2549-4716-8e6d-0e4db42591a2@oss.qualcomm.com> <546faeda-d896-403c-a449-5c9b0cd7159e@kernel.org> <17474333-bb82-49d7-bc04-45ab21095c38@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: nKT9-HrLbEP4aDS8v34xcEVpji0NYdFV X-Authority-Analysis: v=2.4 cv=V7twEOni c=1 sm=1 tr=0 ts=699d950f cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=cOZJgYAoufmXjLtfvsEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA5OCBTYWx0ZWRfXxMuOKgFHYceF ja3Y4nJKTRt9K0PF1rkiXRv8KS8awX0pzj+tuqoK0nVqat173bKqiFOMIhV4SpndaCP50H53asB 6bdkPlSah1fN4LpEc8xOOR/9it3Vk/jwK9Ay1lbckjAium62oc7qa03IcwByD+Tk0Kfk8PpxWop +l00jbP8G884DSsD2Ur12+xwO2ttkvc7o055325m9hm+PASb7yAah9oASCQG5lTvy7WrOSEGMV2 r42ESQhMzy5D85g8vJuqpfAQ34ae5xjb56+rCpJSl9weKzWez99iHrASZli4fB3elevp5GOL37E fzF8bdktYnzidr3Zn6RyQfu57NM8kFwIw08QG7zTUwipOLIZSF0AluPVEhCqSUxZno/Wskjj0gI E5ez5Oy00yfyttyaAfJ7IqA7LtuXqompgc8ikWxgPJsWAT4k79a8W8Mr/4R/fQHVBzkeNZIVofq vDr/EX+CIJP82hAbOEw== X-Proofpoint-GUID: nKT9-HrLbEP4aDS8v34xcEVpji0NYdFV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240098 On 2/20/2026 1:14 PM, Krzysztof Kozlowski wrote: > On 20/02/2026 08:29, Gaurav Kohli wrote: >> >> >> On 2/11/2026 1:43 PM, Krzysztof Kozlowski wrote: >>> On 11/02/2026 08:37, Gaurav Kohli wrote: >>>> >>>> >>>> On 2/8/2026 3:36 PM, Krzysztof Kozlowski wrote: >>>>> On 29/01/2026 13:06, Gaurav Kohli wrote: >>>>>> >>>>>> On 1/28/2026 4:57 PM, Krzysztof Kozlowski wrote: >>>>>>> On Tue, Jan 27, 2026 at 09:27:16PM +0530, Gaurav Kohli wrote: >>>>>>>> The cooling subnode of a remoteproc represents a client of the Thermal >>>>>>>> Mitigation Device QMI service running on it. Each subnode of the cooling >>>>>>>> node represents a single control exposed by the service. >>>>>>>> >>>>>>>> Signed-off-by: Gaurav Kohli >>>>>>>> --- >>>>>>>> .../bindings/remoteproc/qcom,pas-common.yaml | 6 ++ >>>>>>>> .../bindings/thermal/qcom,qmi-cooling.yaml | 72 +++++++++++++++++++ >>>>>>>> 2 files changed, 78 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >>>>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>>>> index 68c17bf18987..6a736161d5ae 100644 >>>>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>>>> @@ -80,6 +80,12 @@ properties: >>>>>>>> and devices related to the ADSP. >>>>>>>> unevaluatedProperties: false >>>>>>>> >>>>>>>> + cooling: >>>>>>>> + $ref: /schemas/thermal/qcom,qmi-cooling.yaml# >>>>>>>> + description: >>>>>>>> + Cooling subnode which represents the cooling devices exposed by the Modem. >>>>>>> I do not see the reason why you need 3 (!!!) children here. Everything >>>>>>> should be folded here. >>>>>> >>>>>> >>>>>> Thanks Krzysztof for review. >>>>>> >>>>>> Each subsystem may support multiple thermal mitigation devices through >>>>>> remote TMD service. >>>>>> >>>>>> Because of this multiplicity, introduced separate binding file. >>>>> >>>>> This explains nothing. Subsystem does not matter for the binding. My >>>>> comment stays. >>>>> >>>> >>>> thanks for this suggestion, we will use qcom,pas-common.yaml to define >>>> bindings and avoid creating new file. >>> >>> I asked not to create any children nodes. >>> >> >> We have multiple cores within a subsystem(cdsp) and each core has its >> own independent DCVS. And also we have dedicated TSENS sensor placed on >> each core within the subsystem. > > Your own example in this patch had only one device, so how do you > imagine to convince us with incomplete or half baked code? > Target of this series supports one tmd per remoteproc, due to which we have not posted examples of multiple tmd. Can i use dt binding example sections to describe all tmd's per remoteproc? >> As a result, each core requires its own cooling device, which must be >> linked to its TSENS thermal zone. Because of this, we introduced >> multiple child nodes—one for each cooling device. > > So you have one device with cooling cells=1+2, no? > This will be a bigger framework change which is not supported, i can see other drivers are also using something like this multiple cooling device under device node, below are few examples : ->Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml In this multiple fan child nodes are present. -> Documentation/devicetree/bindings/thermal/nvidia,tegra124-soctherm.yaml In this multiple child nodes are present, like heavy and light. Please suggest if our current approach is fine or you want us to implement in some other way. >> > Best regards, > Krzysztof