From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E689F26056C for ; Mon, 18 May 2026 07:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091161; cv=none; b=kLnKnFUq5iFUnDubpwJfyMtNj7aoHIATEGPOl1yAqEEg0eJFd9jJ3nqM0a/PA610NGE190a/ImmhmEMpOfRAHG89mSUNbqIV0DixtfbfbDniYkm7VFyWkmN2zvOtfvfD8TE9Mo8D6CaOd6fy+c/pndLvAht4O20w5MncsBR1mI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779091161; c=relaxed/simple; bh=mY1Y6DE3ED910R/Akfi6keCapnlS44F/hjQ0ODPO1dA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hLI4fVllc5mchlXtZA+ZjKmdp9EeyDiigmesf2xfr1LcDpTqXEYHUIahfg80FccQh9CM2WisEatazO/m7KVxbQtzKdaRTdV2K6bQqHXSWCZrRmfrXM3tUc5mlPmp5uQzjvFRGcW5o+/fg6oDmTC0i8Fd2TPjhQdJBfWqWCLbi2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d9s9F95e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SXIIhVWS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d9s9F95e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SXIIhVWS" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I7agvn1462932 for ; Mon, 18 May 2026 07:59:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zxa4aoJy+8GGKmRaYi1pSnhQkdsyiCfnvq+yyPcQAFI=; b=d9s9F95ePq5loa3q s7a+Qgrahhvnw7U4g31QyHl0l96kBUbykO0djD5c3qZx1lOZpotOF7EkzspCpYLL CJGiUfJPitFxRhxmet7mwTwVmim1IV8Qf2loJYL8YVw7Oam2h5x6eBaHmhb2pz3f JmkuLPKWf/4tLsb4LWmujUBH17S2ieu0YzD0V6f77YYte3Jw1Fgal6bIljyAzR2K +JnB7TLDBmVLHOovvHQ0bh/zdYjINpZRZJetNZ+rJ2JDta0tPyocuDy0IWfkNxB+ CuZe81paVkyj3sX6S0DB5eafMUgWVHH0hmUreH5STkpWla1vNfIksZWDO34TYFkx FyXmMw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e6h0g5b23-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 07:59:19 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-514b5cc5cd2so7492021cf.1 for ; Mon, 18 May 2026 00:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779091158; x=1779695958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zxa4aoJy+8GGKmRaYi1pSnhQkdsyiCfnvq+yyPcQAFI=; b=SXIIhVWStIKF9EJcCTmqQCQVxwVryS7x52Ry4PYDLm+rV+rvdniCzfvKttQ6Ti2etf mjXyWPbJ3+U9QgP+3uzvixib8CZFBrYrVJmZfktHUX2dF2f1QL2NdxkCKn6u+3qHLQ+v 4Hx0SVVc4y1pfpLqF5sVwoM+N91fgmT4n8Qpa5RyoQaA4agOvhUix+d+NWAWMn/aFqbM dw7cqeakCJXsmOTQahs6h2r2CeM0g5hKHJG7Om1Cyte8sqT7TJmuA88Z2qENYLplNPT9 WU0MQ2QcVbSon5nZZeC+zQM0Q1DiLzSLMcdjuPJU0iibDvP4bXqwGgs5LadllHBH/5qG OMNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779091158; x=1779695958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zxa4aoJy+8GGKmRaYi1pSnhQkdsyiCfnvq+yyPcQAFI=; b=Wbe/G+pMxE2GVrejU7O/rGc8Lk1Evt0udotVWJ3NRZY3zZum9YIN3AKnPt0btqXtwZ Xa2Gz31DeXldmD6BckdHd2lv0GLJKxW14yUUqa/0WKcZopsN2MrUG01gwL5AOtKjGOh6 voD0rCdfn0MNJYaUfED1aQTdGHWz23+SqGyD6rv4xYr6zskuhA6E6yNBvMy18TxGWssL xOdYOgtIEc77lzgK6B7xRsstf7uNKzRkZUd1E72ZI0vkY6O/JM46r26kzxB3eUzI2Mx2 9wK2M87uhCphu/REKduGpgJc0e+hvyuFKZ+J0allHh0gVdB7MiDIlpinri0K0B+frCh2 sWMg== X-Forwarded-Encrypted: i=1; AFNElJ+kK2fd6GVZwUbJlqLj5uMEdIA13E5laEJiXeejXG+YNPh22DhkNo5HqmcIN2kiH58LEwcfNxGOjKd8RC4=@vger.kernel.org X-Gm-Message-State: AOJu0YyPMc6koEmYflUuqKlsmsYIsCJfSy58GXqlAuskbYWfSx+qGcI6 OZqe7lh4NZ9ZV6jer9olYlRAwoRtVwpbs5sUV58UD6mGjKZ1B7Hr7irWDV1Slfydy06w7c77RMf PY+CRD5kqR2+jdg9ins5O5NXMAz5T7Q4/G4Q401IyH0GFkFCmCsUdw4XbjoxhnY8MPqE= X-Gm-Gg: Acq92OH3VcXPVbZKiEAN4gWzXnxHQ5cDYEOZYTX1GzU5xGUaPrHrNbD6Ud5Uyn3Ge6U vfHowh/PNvdl3sNaVKI0NKHO5EhE6X/w1ECDIBWslKgh5so5hRrMuDVOwbnp9NBKcaI2o0DGTWX SeFVUX8lpkbim56hCnGs6+V8BMCfYPGW8/JxrAw/0HhT0ncLsMQdAPo5A55UG/6tHXeERZbXOgj 9f/05nnRd9CO+9v6hQtO6rGqHm5+2LOh/wWUwhBIWcJxZ6OFpLApdhAQwF3fsbkEX208JXa7jT5 3zVgs8TJMDsXp3vjPhUoCl/w+PFT1ziIjsR+yeuT+cmi2cHT5Cg48Mjvv0QAGAD03fX4nfF3Z/c IRIORs5lxpQd8JPoN5k+2xkDoc7jA7RzebBTIpDOlKxyEzeZXPJ0im4dehdWveAmilmp9SMxt5A NDORI= X-Received: by 2002:a05:622a:1104:b0:50e:487a:bfef with SMTP id d75a77b69052e-51659fd3213mr148249761cf.2.1779091158227; Mon, 18 May 2026 00:59:18 -0700 (PDT) X-Received: by 2002:a05:622a:1104:b0:50e:487a:bfef with SMTP id d75a77b69052e-51659fd3213mr148249591cf.2.1779091157767; Mon, 18 May 2026 00:59:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4e68fa6sm543154966b.54.2026.05.18.00.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 00:59:16 -0700 (PDT) Message-ID: <4f8697b8-d602-4718-bc8f-4bd0dba50040@oss.qualcomm.com> Date: Mon, 18 May 2026 09:59:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing To: Jianping Li , srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, abelvesa@kernel.org, jorge.ramirez-ortiz@linaro.org Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ekansh.gupta@oss.qualcomm.com, quic_chennak@quicinc.com, stable@kernel.org References: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> <20260515124217.20723-4-jianping.li@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260515124217.20723-4-jianping.li@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA3NSBTYWx0ZWRfX67Jizmlgh5yz MqJMuPyEawdc8pVr0sWm9185/zu8JRhghc8KCJWuRj1JXfYjNGSz9nSFFfxQVnUdfM3ffLe9uUk rTbICrwvBGwDgEdL2gKnCYG0G73L2JxIcr8E19hsd5sd26DYUjn+fMbMsiLl5bTq0Vp2m15GouS o0A18mbygs8yozbECZMwQ3KyKeVJJFxHi9hme6wnkpt8vw91oUY5njADtBNxpXq/0lYL2mli3JK 7AsbDEFpKJq6Bb+K313N3ydOM31SlnPh7GBPupFcmrvnAomR+VOJmVnrwLgvNNTC55eCVVuEanp XMbXvjGuJ/s8V2KaEueyyclIc7sjvkq7S1w6MtvVCHs7/jSvm+/69UXqPrO2YHLHFpy663oq9rZ BksHLoy/Qo3IKydfR1MsloLwG4B4nn6oufYNzF+8eIRE/WSBndSXg0WXZhNJg2gLjJiOIj2WLlM YUkm8HAVV66n+II5JQw== X-Authority-Analysis: v=2.4 cv=W7gIkxWk c=1 sm=1 tr=0 ts=6a0ac6d7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=hhTr-yxhb_4ls8DXav4A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: 3qpam-SMD9m6LXrSwnYazRr79ner83KO X-Proofpoint-ORIG-GUID: 3qpam-SMD9m6LXrSwnYazRr79ner83KO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180075 On 5/15/26 2:42 PM, Jianping Li wrote: > Audio PD static process creation assumes that a reserved-memory > region is defined in DT and exposed via cctx->remote_heap. > > If reserved-memory is missing or incomplete, the driver may pass > invalid address/size information to the DSP, leading to undefined > behavior or crashes. > > Add explicit validation for remote_heap presence and size before > sending the memory to DSP, and fail early if the configuration is > invalid. > > Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") > Cc: stable@kernel.org > Signed-off-by: Jianping Li > --- > drivers/misc/fastrpc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 3c7c3b410d7d..a0337cce77f3 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1363,6 +1363,12 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, > args[1].length = inbuf.namelen; > args[1].fd = -1; > > + if (!fl->cctx->remote_heap || > + !fl->cctx->remote_heap->dma_addr || > + !fl->cctx->remote_heap->size) { > + err = -ENOMEM; > + goto err; Let's maybe add an UERR() with some context Konrad