From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED9FC47071 for ; Thu, 16 Nov 2023 04:34:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235674AbjKPEeD (ORCPT ); Wed, 15 Nov 2023 23:34:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230266AbjKPEdy (ORCPT ); Wed, 15 Nov 2023 23:33:54 -0500 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FC811BD for ; Wed, 15 Nov 2023 20:33:49 -0800 (PST) Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7789577b53fso20343385a.3 for ; Wed, 15 Nov 2023 20:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1700109228; x=1700714028; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=bndky/isFZdPv4y+9HMU+8QO0OsZEFaDO/mxDCye0C0=; b=Be2nyhJV8JByTCu9BsElBdGHDrrhMuIfyJI/dW5Ptt4EUKql5kjRdkX35r7Ph+ocBB /LY1ZvqLo1a6v3v/Mji8zsoeKxpSQeJaWYTwmZTLARnwOL+UqNKskMYW81yULkInncEW y/PVI9i7A2a/GmitESvrxjUERfNuMYi4JjrntU7AwykluwNteWHkgFBBJsCpSOCPMjbE Wy9K70Nl1QZaIPNNbUGKu4zdspq8PzlFWKrViqaq3xAsJ7X5SePmlVcXHUWZl176RH3U JEEv8/hCNT7+uizusuOj0/z6OHBcVfKgfMlYBpnKTxfuQO8eXa/2j+IP9b+ViTfn8PHX NsdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700109228; x=1700714028; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bndky/isFZdPv4y+9HMU+8QO0OsZEFaDO/mxDCye0C0=; b=eb6UsqKVV+RNG0ZXyr2TKVCmRJp6VAzW+sr8eKvy2qtk/QOD6hdOd8OzR8swp80wQ3 NT5kIEHyOCNvupnYFEHsIFe2dsDjUfoSp+9cBkGKzu5WOY55OsHs7Z/CGrYniiuC8SMB IoT1SchRuBLFyXo58FA5tD22EhBMziwIio2Bp/MHikTQ4rW+nPBCHlWGDUD5Zfp10YbG ZabdIcIRByEv0C3NKL6UHKtUGErOhP9Q2tlWVKURt6DNHIv20eVB9GdPtgnC7i0ShNpm 2HcXlKQLFO6r6gpH2BGgfP5mpHk4/dYGqZ4MYtT1b3nkUX6GTh6Hcn0EZK61GmUBP+wF EdYQ== X-Gm-Message-State: AOJu0Yz8P9jrjSV//zK1dNRiDwHdThJdwsbAKe0YbSqCTVNOHuWyZqDh NJUeBbzW4tFYn4uOCat/8gJ3 X-Google-Smtp-Source: AGHT+IGCdgvNrhLjs0RBnM3O7h6Ri70uA7en86HSqfGY/HAxnYl36rBdMYafIeqWPJt4yM0F6QD9XA== X-Received: by 2002:a05:620a:4156:b0:775:cf5f:8a57 with SMTP id k22-20020a05620a415600b00775cf5f8a57mr8673614qko.7.1700109228335; Wed, 15 Nov 2023 20:33:48 -0800 (PST) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id t26-20020a05620a005a00b0077263636a95sm4006757qkt.93.2023.11.15.20.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 20:33:47 -0800 (PST) Date: Wed, 15 Nov 2023 23:33:47 -0500 Message-ID: <4f8c441e02222f063242adfbf4d733e1.paul@paul-moore.com> From: Paul Moore To: Roberto Sassu , viro@zeniv.linux.org.uk, brauner@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, jmorris@namei.org, serge@hallyn.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, dhowells@redhat.com, jarkko@kernel.org, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com, mic@digikod.net Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, selinux@vger.kernel.org, Roberto Sassu Subject: Re: [PATCH v5 13/23] security: Introduce file_pre_free_security hook References: <20231107134012.682009-14-roberto.sassu@huaweicloud.com> In-Reply-To: <20231107134012.682009-14-roberto.sassu@huaweicloud.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 7, 2023 Roberto Sassu wrote: > > In preparation for moving IMA and EVM to the LSM infrastructure, introduce > the file_pre_free_security hook. > > IMA calculates at file close the new digest of the file content and writes > it to security.ima, so that appraisal at next file access succeeds. > > LSMs could also take some action before the last reference of a file is > released. > > The new hook cannot return an error and cannot cause the operation to be > reverted. > > Signed-off-by: Roberto Sassu > Acked-by: Casey Schaufler > Reviewed-by: Mimi Zohar > --- > fs/file_table.c | 1 + > include/linux/lsm_hook_defs.h | 1 + > include/linux/security.h | 4 ++++ > security/security.c | 11 +++++++++++ > 4 files changed, 17 insertions(+) > > diff --git a/fs/file_table.c b/fs/file_table.c > index de4a2915bfd4..64ed74555e64 100644 > --- a/fs/file_table.c > +++ b/fs/file_table.c > @@ -385,6 +385,7 @@ static void __fput(struct file *file) > eventpoll_release(file); > locks_remove_file(file); > > + security_file_pre_free(file); I worry that security_file_pre_free() is a misleading name as "free" tends to imply memory management tasks, which isn't the main focus of this hook. What do you think of security_file_release() or security_file_put() instead? > ima_file_free(file); > if (unlikely(file->f_flags & FASYNC)) { > if (file->f_op->fasync) -- paul-moore.com