From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A887927701; Wed, 5 Jun 2024 21:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717622228; cv=fail; b=kPhD3XrD0mGX9rcPfggP0fSMZVRGGi6041va8epkY3icwS9Sz5D/4ndeoSic7xDDKpRVCmmZdnw34ZpyAieLRy+wy7sANRsTyL1SjNYXqeHUkj0h5KKkropKevRFWFmXPX779FFbQC2yroPfSMzTXcQU7ATHmVRYIdbiMUf+SoM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717622228; c=relaxed/simple; bh=ljLRFnXDJSUm0dYBat7az8MZ4ehZVKANFMG9pW/MqUM=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=E3s4hHRUkkN59sao/kO6JrJ1PSpSfTbR9ufFypzsYacMUkG4Guk/mOflX2a/FfD9YRjCpj52z0PxSPY/sxZW6l5272gQPqLZewfYEsHu4RwTGaVIP69njJM5czxV3eZaHx1zXF50B6Eo+Ts8C2NkTdbJ0AGUVXhHaUYd5hnnY2I= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jNPXiafj; arc=fail smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jNPXiafj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717622226; x=1749158226; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ljLRFnXDJSUm0dYBat7az8MZ4ehZVKANFMG9pW/MqUM=; b=jNPXiafjeoUE0VKGuM2wCQuB4VK5BxrfwcXXm3nLtm6Lvnt5imFmtqqm rVh07V65LahpHMAY20+ZFH6bfwhucOp8EYxTJlWTcjdoz9/uFPxTq8JKO Ub22F4vts7SAmBJ41GDus3Jqb5QJwmdpJhhpAggYxgw+WunZobRqfItax Oyg2L4Ww8TtbfllNBd/FpXrNCvESIL18HZgY41pDecVzkN/ZFhPkmLXG9 fS1iD2Vm1MqGxRAU8w0V5kxW3lQECpdbtpwsuO4qLZ6GoTMTJGf8oHiBY HTyYtGiB0OnaZ7s1Aq55dEZrJ1Q57VWuDsRMFbCQzS+JpZfgA1dEEmRHR Q==; X-CSE-ConnectionGUID: KljBnGzCTAejYsUg/AWgCA== X-CSE-MsgGUID: II/vhDb9RB26tNzX1G3xzw== X-IronPort-AV: E=McAfee;i="6600,9927,11094"; a="31756763" X-IronPort-AV: E=Sophos;i="6.08,217,1712646000"; d="scan'208";a="31756763" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2024 14:17:06 -0700 X-CSE-ConnectionGUID: gelD3rpERhmBbrXv5T+Xfw== X-CSE-MsgGUID: xmI0VV8jRSCfKPEtn8XzYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,217,1712646000"; d="scan'208";a="37609144" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jun 2024 14:17:05 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Jun 2024 14:17:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 5 Jun 2024 14:17:04 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 5 Jun 2024 14:17:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHYRVa6y6i+XAKAHzYW52DbG1FKvfu8IH9Rjbzj6XqXRMToYgK+O6jaPXMEcoVXFIA+LPxLdJldDVME+RjI1LDL7IRhRxPi+UpoSCPs6N1GvdcDxmMrmFBU6mXUWzrkPEJ4/RkrrAMn/ChWiaRWP9wtVuVxxDMRaYYUnQ2MT3+x4582eph7AJE2DRqqRc0PqSVr9aQAetsndKopIv6rbMrlCihGBoCAQKE8Exi5OavgrQelLJfWUya955n+sWTElV5xuYiGC5s9uHWGbBG7OJnogjklSEWajA/ObROq/7h6J4DY9VBRTVEZNYwBCit6Vq76wX5Hj0Yb8RUxYpRLVAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oephq+iYsdLIoN6+AB4ff+/TnzYr/OGKR1bt57aUIYM=; b=FL5guntNp6frZ60vltXMgsK3tvQZ6fwK7MP3a3tRK6Z9IBT4zkQqkEObFd8P/Q2t/pDi5J+cRS/h1/d381G1sY3IdvdHRoCDeBFTxa/kzI1EgwHV2nJg++SNTGS9P7SGYRO5gsOwoIA77IIFQcz9rXnl7Hv9W2+JWWL1bHlHMhDr0CrVctuNufP7f+sw26GOoP4OXKF28GYNYa+7eiS+k3YPL29cYHmd2lHpG0ciXD0Gc+9w+nRzgs4+nIvBBdMBddhvd2ARsNvwGF2BEA+YhlAZEIUUolbO3yXSOHZEZnZUb6qYVA6XtXBhWm2Yw5OjavALmaSQm/3d/UdeVLeTQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB5089.namprd11.prod.outlook.com (2603:10b6:303:9b::16) by DS0PR11MB6375.namprd11.prod.outlook.com (2603:10b6:8:c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.24; Wed, 5 Jun 2024 21:16:49 +0000 Received: from CO1PR11MB5089.namprd11.prod.outlook.com ([fe80::7de8:e1b1:a3b:b8a8]) by CO1PR11MB5089.namprd11.prod.outlook.com ([fe80::7de8:e1b1:a3b:b8a8%3]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 21:16:49 +0000 Message-ID: <4f9af0e9-5ce0-4b76-a2cd-cbd37331d869@intel.com> Date: Wed, 5 Jun 2024 14:16:47 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] igb: Add MII write support To: Chris Packham , Jackie Jone , "davem@davemloft.net" CC: "jesse.brandeburg@intel.com" , "anthony.l.nguyen@intel.com" , "kuba@kernel.org" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20240604031020.2313175-1-jackie.jone@alliedtelesis.co.nz> Content-Language: en-US From: Jacob Keller In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW3PR06CA0025.namprd06.prod.outlook.com (2603:10b6:303:2a::30) To CO1PR11MB5089.namprd11.prod.outlook.com (2603:10b6:303:9b::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB5089:EE_|DS0PR11MB6375:EE_ X-MS-Office365-Filtering-Correlation-Id: fd9c2980-0fcb-4342-d045-08dc85a4cffc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aHBkRHJMVUh3eEd0a1pPbXNFZ29wRE5ISldjNEk4MUJTNk9sV2RGSGJlSzRM?= =?utf-8?B?b2N6Y2pFRFFQSHdmVURTczJnMTBudGtIOEtJU1RsL3ZYNDlBV2lxS2pVMUE0?= =?utf-8?B?R0RFd2dVU1d0MDJPRXBYVCtWQ292RmhmQTVTWHV3a2NMT1BzQW1HNTJ1SWN5?= =?utf-8?B?eXZybkZFNkVLeUR6SkYxR0lFMkk4WUdmOUVJRnRlRWtSYXFQRGtxTzZmenNj?= =?utf-8?B?TE9PYS8vVjRRU3kvOGZuNVpzM0lxNmQ4L29wWkQ0MVl6MWd2d2ozYUFxZVpP?= =?utf-8?B?bmZTVGZGaEhHQWRvMlhYU0hZUnNYVis0RlRzM3RNQkxWUTdQK3NiVjl4eE5D?= =?utf-8?B?cWNhZExoWFArMnpZREhJMHVaM1B4UVQxRkhyL2RzaG9CS2tVcXFVZVBIS05m?= =?utf-8?B?R0R6UnYxNXNLL0podUpQODJGbGdjczN5a3E3WFkwdStOakZLSWNUeG5FSmV2?= =?utf-8?B?eWF5MjU3cUdndlUyUlBzSDExZ0NRWTk1dzdNc2lrR3RoU2FBcTVhT1J0WGd3?= =?utf-8?B?NmU0V2NIeS9JOTBoWkhXNDNhdXFyMnVYVnNhWlQ0RSsxaHdsYU1EbEJqODVz?= =?utf-8?B?WTZRT0xXSGc1Zy9jK3JldTRWcXlXV2FGbmRlck5HVDFmNG4vem9EQzdQTG5i?= =?utf-8?B?ejA0emx0M2diK0Y0RWNrSzNlNmtkeGU2bUFrTjJma0JzeGxYUk9Ecm50UUoy?= =?utf-8?B?d2JlSWJ0UzBDQ1lGdmJSd2pUUVl6d1FyZ1RrRE05WW1zWGJ4NXhGNmZldW1Z?= =?utf-8?B?citXWkJsUU53cTlkNkcrK2lWM3VtRTkrRWNzUU1Hc1RuVXFZeWNDd0MyQmp4?= =?utf-8?B?TFg3T1ZwLzNaemZ4NUJaVjhlcWo3dDFVUE4yRXN6Z3lGMVVBQ2YxRExhQ0VN?= =?utf-8?B?QTdSTVIwWjR6U1VXNythMitKZnhKZXRRN0daRi96U0FrMkNES3NSc2lLa1NY?= =?utf-8?B?S0VjUEpObWtyL2lUYUlXbVhScmFaR2ZkL0xzY1h5QkhUSVR6NXk5U1V6R0RL?= =?utf-8?B?dU05U2NDS1JRUWpJa1FTNml0U1VOY3craGRGcDRUbXRKeUdRZ09xREVjZnlt?= =?utf-8?B?VnlBL0h0WnNJbkdlTUgvdUpORlI2eS9aREF0Q0E1bkhjMlFVa2tGaHRBdTBF?= =?utf-8?B?bWc4Q01CZUh1cEwwenlyK2d5MThCdlhacjJLbXYxeG94MGVqRDlidFBGU2U2?= =?utf-8?B?QzVBNXdJMnhjOWl0YWI4d0l3dTJDVzl3NzRkVzhxUGpNRjBQNmkxRHhZUm1q?= =?utf-8?B?dUdlTEZNMGoxNW9qZTUyTkJqaXA5RFdPVTVNa2J3UTlVaFR1Sk93SVkrUXlw?= =?utf-8?B?czBrSVFDYjdGT3hCUFR2c3NmczFDUnYwekNTQzQ2MVp3L1NHNDdncGhUNWgr?= =?utf-8?B?cmZxMFhxdDBwd1NUSUJzYmFlVzJ1OW5sTUJjS1ArSDdXQzUyT3IzNGdOWkY4?= =?utf-8?B?L2JiOUtxeFF3NXVPNGVGWU50MEQ5amJJRmw4Sk9XNzFxbDNOMUVIcXVtSlls?= =?utf-8?B?dGdJY3hkK2x6VnNDYzYrUmVvdTFFSlZqWjBiMUFjZjFuMXJENTlyRUJYbFU5?= =?utf-8?B?MVV3aVdqWnhaUmxLY0tzeHdRdnMyN1orZWtVL2VTMnFuMHdxclF1ZmZyREhZ?= =?utf-8?B?dm0wempzL0hrdnB0cERrVWJKZ3Z2WFVMbXYza1RVT05CK3hlY0UvNXJNNmpr?= =?utf-8?B?cnZLYUNTWWZIeUhkNVhocGNkaDVmcW9JbjQrYXhYM3lwZGJJekZhTldSOTFk?= =?utf-8?Q?po5kc/Ygondcu8iwMz7I8wp3PWMwX4/3/3fDOAP?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5089.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejE0azZPTDM5UTgyS2RaMHFXdnJVVEFuNUUxRnA5ZmltcVhOa1huK1dWSE1u?= =?utf-8?B?TkRKcXdNa2I2ZTlIVGZYRiszQlMwTDJBU1hLQlM3Wm5hL2srUHFXK1h6clEv?= =?utf-8?B?NWhrRWJKcm1pNDNXS3ZZUTdmSzhmWkxrQ0xyNmwyYy9Ddi9Obm43aS9nNkdt?= =?utf-8?B?bHErTGF1d3l1Wk9aRlJSbk45RVh2aUorWjRJNXRNeFFySUY5SVJPdDRUL0kx?= =?utf-8?B?OTlJVVhaUkswbG1NWVpTR0hnSWdBRS81R1Rkd0hyQmJHZjltUytLZXdobXBF?= =?utf-8?B?M0RNYjg1UGFHWVJZblJHUjZ2aURWUFA2eGNXU1VsUmdiY0c3TGw3aXNibWVZ?= =?utf-8?B?a2ZKNXBSMHI0ZEl0Sm9YZitmY3RyTW9QTGx6UGFmNzVLQXU5OU1UTjJRM3A2?= =?utf-8?B?UTVHRXNTekl3T0c1MC95TFBYWGFMSkQzY0JGY2ZzYTlIN0cxQks4WjVPT2lK?= =?utf-8?B?OU9VT05wRFhvMjVlam1HbW1PUzVoQSsxSnhqZUJ5OVpDanhhaUhEMVVvTTVV?= =?utf-8?B?dXZ6RWFXQS9ibC84UHArcnJVNVBBejA0OG1ydmFPMC9tSC93Zkh5R0phdDNX?= =?utf-8?B?Sm1XaHd3VUdLZFJia3hRZER3R3dOZnNuNjVNSW43NnkzNE1jbGpYOFdoSFEv?= =?utf-8?B?NGlRUGprZWo4MjI3ZHIySHhlZlMyNGx6RFM1NmJPZ1VJUGNHUCtKZ0Z5ZEdX?= =?utf-8?B?dHQvS1FqS1gvTStBeGFHUDJnYWxZSWNadkM0MldMOS9nZWJXSU5MNHBxMlpI?= =?utf-8?B?NnVKTUNUZ21jTHJycFNwQzhWNGtKNlpVMHZDUWxPTmQwVDBLQkNueDVlaHVj?= =?utf-8?B?aUs5Y1M4V0t4aW1JVnVuU1VBekFJNytsVjI1ZXZOeXdaeUtLSUVRcGlGdXZl?= =?utf-8?B?eEIwY3RtUkpzMWJMMU9XaU5DWVBhY1dlbnB6dDNiQ08vVTlkVU5uc3dlZEUy?= =?utf-8?B?N1czWUdWQXJTZFpsaGRwTUhCQ1lZUENjbmJrQU9nd3pZckcyTTVocHAxNVR6?= =?utf-8?B?ZGhKQ0pob1E0Uk50aGdkYTRNb2VQMHZZK25MUk1TRlJ2Q1RDMDFGVytiREpY?= =?utf-8?B?VStkUk82MVhTMlo4eXpqZnVaQk9ja3BXVWYzM25JMDBxYi9TdkdIeWpMc0hh?= =?utf-8?B?MFVCM1RKN0xMaUFCeXVUNEVYRzV1VFFmbjBhekZhRlJ4Snk2aytuajRPU05n?= =?utf-8?B?VUZKTjJiNTAzOHhqNS9kL1dWNU5aY2ZqN2p6T3NCZUlSQmUvNkkxMmg2Zjly?= =?utf-8?B?M1lwTHl5cVVFbzNjMm5RUnBCNkVmdGlKNkVwS0puMEdaZjJvN2RTUUU5MU8y?= =?utf-8?B?VGIyOXprTGNNcm1VSy93cERoNFlJVUNINGt6cFg0SERKRXRGb1ZOYkUra2cv?= =?utf-8?B?bmhVV3B5bzh0TGduVUZXNVFuUG9uZWtzdGhldlFHWE54OWFYRjV5R0FoSUFN?= =?utf-8?B?SFBOSmV0RU9iMDdOZldSaE9aV1VzRDgra05vT0tsR3dwUEhiU3pzZ0xMQ2hO?= =?utf-8?B?QlJDUi9ZbFZqbHJLKzZnQ3BZRGJ2bjRiSTZMbVVUWUVwLzRNZ3FEQTNMSWh1?= =?utf-8?B?clFYVDhZS2NEWk9aQWdqc0t0eGhMZmx0NVB2Tld4Z2hYMzkrci9UTTc5d0U3?= =?utf-8?B?cTdoSzJ2NWN5Uk13OHY1SmY3bzNLS1B1czVVUDVDNTB0MFQwaENMNTcwVVBq?= =?utf-8?B?bjVHUEsxaW5IVDlRcjNHUkd1OGNXNm1tdlZvQmc2bDR5T2I5ajROY1lyQWps?= =?utf-8?B?VUgzb0VjOFF1WnU2UFhyYU9kd3prWUZFK2Fub2lGQTE5M09uSVNKejhHcWFh?= =?utf-8?B?bFN1UFdvREVHbUpScFNucVlpd1AzSXVxNkY4RmZ2NmQ3TWl3UVFuYlNHOEVz?= =?utf-8?B?MXdFcTVFV1FEd094TDRrN0ZmRDdpZlJiVHFZdDNZNXFnYTdteElKNXFqQkFs?= =?utf-8?B?NzRVSW5zY2pFMFpyWXI0a1VsN3hHODI3aWRZOHQzYUJJdVZ2M3M5dXg0RTJy?= =?utf-8?B?YW9jVkhSc1JoSHZ3eTdpV3hUNDNhWm9PZG52Q3I4M0RBSFhmZWxZWnAzUU5k?= =?utf-8?B?MCs0WEcxNjdvUjZOaEJWQlk2MTU4Rkhmb0xKZCtVSCtWNERGZk1LV2dZdjkw?= =?utf-8?B?VkpNM0tUTVBMV0NNSDhSY05GZVFxaE9KcnpzMlM3a3NjNlhHcG9DYldOTjVC?= =?utf-8?B?MXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: fd9c2980-0fcb-4342-d045-08dc85a4cffc X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 21:16:49.1072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MTOjkdvTc/zydyEU67zE7q2PT4qtRg4KJv1nVNC0qQishylw9sOdPn6QHxOxoEfDyn1Ir/0o5NF1T7yJPL4gMP53iCDEGzYl6f2DUfjCawg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6375 X-OriginatorOrg: intel.com On 6/5/2024 2:10 PM, Chris Packham wrote: > > On 6/06/24 08:51, Jacob Keller wrote: >> >> On 6/3/2024 8:10 PM, jackie.jone@alliedtelesis.co.nz wrote: >>> From: Jackie Jone >>> >>> To facilitate running PHY parametric tests, add support for the SIOCSMIIREG >>> ioctl. This allows a userspace application to write to the PHY registers >>> to enable the test modes. >>> >>> Signed-off-by: Jackie Jone >>> --- >>> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c >>> index 03a4da6a1447..7fbfcf01fbf9 100644 >>> --- a/drivers/net/ethernet/intel/igb/igb_main.c >>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c >>> @@ -8977,6 +8977,10 @@ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd) >>> return -EIO; >>> break; >>> case SIOCSMIIREG: >>> + if (igb_write_phy_reg(&adapter->hw, data->reg_num & 0x1F, >>> + data->val_in)) >>> + return -EIO; >>> + break; >> A handful of drivers seem to expose this. What are the consequences of >> exposing this ioctl? What can user space do with it? >> >> It looks like a few drivers also check something like CAP_NET_ADMIN to >> avoid allowing write access to all users. Is that enforced somewhere else? > > CAP_NET_ADMIN is enforced via dev_ioctl() so it should already be > restricted to users with that capability. Ok good. That at least limits this so that random users can't cause any side effects. I'm not super familiar with what can be affected by writing the MII registers. I'm also not sure what the community thinks of exposing such access directly. >From the description this is intended to use for debugging and testing purposes?