From: Akhila YS <akhilayalmati@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: st,spear600-smi: convert to DT schema
Date: Wed, 25 Feb 2026 20:32:29 +0530 [thread overview]
Message-ID: <4f9f988a-5f3a-463f-aabe-aac1b018bd93@gmail.com> (raw)
In-Reply-To: <CAL_JsqJhnuWzPxUWywZkjt=zc0nSFKP7hM_ekmKKr7p_jXaaag@mail.gmail.com>
On 10-02-2026 19:17, Rob Herring wrote:
> On Thu, Jan 22, 2026 at 10:23 AM Akhila YS <akhilayalmati@gmail.com> wrote:
>> Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI)
>> Controller binding to YAML format.
>>
>> Signed-off-by: Akhila YS <akhilayalmati@gmail.com>
>> ---
>> .../devicetree/bindings/mtd/spear_smi.txt | 29 ---------
>> .../devicetree/bindings/mtd/st,spear600-smi.yaml | 72 ++++++++++++++++++++++
>> 2 files changed, 72 insertions(+), 29 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/spear_smi.txt b/Documentation/devicetree/bindings/mtd/spear_smi.txt
>> deleted file mode 100644
>> index c41873e92d26..000000000000
>> --- a/Documentation/devicetree/bindings/mtd/spear_smi.txt
>> +++ /dev/null
>> @@ -1,29 +0,0 @@
>> -* SPEAr SMI
>> -
>> -Required properties:
>> -- compatible : "st,spear600-smi"
>> -- reg : Address range of the mtd chip
>> -- #address-cells, #size-cells : Must be present if the device has sub-nodes
>> - representing partitions.
>> -- interrupts: Should contain the STMMAC interrupts
>> -- clock-rate : Functional clock rate of SMI in Hz
>> -
>> -Optional properties:
>> -- st,smi-fast-mode : Flash supports read in fast mode
>> -
>> -Example:
>> -
>> - smi: flash@fc000000 {
>> - compatible = "st,spear600-smi";
>> - #address-cells = <1>;
>> - #size-cells = <1>;
>> - reg = <0xfc000000 0x1000>;
>> - interrupt-parent = <&vic1>;
>> - interrupts = <12>;
>> - clock-rate = <50000000>; /* 50MHz */
>> -
>> - flash@f8000000 {
>> - st,smi-fast-mode;
>> - ...
>> - };
>> - };
>> diff --git a/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
>> new file mode 100644
>> index 000000000000..8fe27aae7527
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml
>> @@ -0,0 +1,72 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller
>> +
>> +maintainers:
>> + - Richard Weinberger <richard@nod.at>
>> +
>> +description:
>> + The SPEAr600 Serial Memory Interface (SMI) is a dedicated serial flash
>> + controller supporting up to four chip selects for serial NOR flashes
>> + connected in parallel. The controller is memory-mapped and the attached
>> + flash devices appear in the CPU address space.The driver
>> + (drivers/mtd/devices/spear_smi.c) probes the attached flashes
>> + dynamically by sending commands (e.g., RDID) to each bank.
>> + Flash sub nodes describe the memory range and optional per-flash
>> + properties.
>> +
>> +allOf:
>> + - $ref: mtd.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: st,spear600-smi
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 1
>> +
>> + clock-rate:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: Functional clock rate of the SMI controller in Hz.
>> +
>> + st,smi-fast-mode:
>> + type: boolean
>> + description: Indicates that the attached flash supports fast read mode.
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clock-rate
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + flash@fc000000 {
>> + compatible = "st,spear600-smi";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + reg = <0xfc000000 0x1000>;
>> + interrupt-parent = <&vic1>;
>> + interrupts = <12>;
>> + clock-rate = <50000000>; /* 50 MHz */
>> +
>> + flash@f8000000 {
> This is now a warning in linux-next:
>
> Documentation/devicetree/bindings/mtd/st,spear600-smi.example.dtb:
> flash@fc000000 (st,spear600-smi): Unevaluated properties are not
> allowed ('flash@f8000000' was unexpected)
> from schema $id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml
>
> Please send a fix (and test your schemas before sending).
Sure, i will resolve that issue and send a next version.
>
> Rob
--
Best Regards,
Akhila.
prev parent reply other threads:[~2026-02-25 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 16:23 Akhila YS
2026-01-22 18:41 ` Conor Dooley
2026-01-29 19:12 ` Miquel Raynal
2026-02-10 13:47 ` Rob Herring
2026-02-23 15:00 ` Rob Herring
2026-02-25 16:28 ` Miquel Raynal
2026-02-26 14:43 ` Akhila YS
2026-02-25 15:02 ` Akhila YS [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f9f988a-5f3a-463f-aabe-aac1b018bd93@gmail.com \
--to=akhilayalmati@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®