From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbdK3NWF (ORCPT ); Thu, 30 Nov 2017 08:22:05 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45776 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752903AbdK3NVp (ORCPT ); Thu, 30 Nov 2017 08:21:45 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20171130132142euoutp0259df43812c9b55e6a2d56bb1c4516359~737z8JCqo2358523585euoutp029 X-AuditID: cbfec7ef-f79ee6d000003120-a5-5a2005e578fa Subject: Re: [PATCH v4] component: add debugfs support To: Russell King - ARM Linux Cc: Greg Kroah-Hartman , Marek Szyprowski , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org From: Maciej Purski Message-id: <4fa2267d-462b-ebef-7504-508084f4797f@samsung.com> Date: Thu, 30 Nov 2017 14:21:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-version: 1.0 In-reply-to: <20171130125416.GB10595@n2100.armlinux.org.uk> Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42LZduznOd2nrApRBvvWK1tsnLGe1aJ58Xo2 i8u75rBZHJq6l9Fi7ZG77A6sHpevXWT22D93DbtH35ZVjB6fN8kFsERx2aSk5mSWpRbp2yVw ZayZuYKlYB93xae1Ug2MXZxdjJwcEgImEr9OPWWGsMUkLtxbz9bFyMUhJLCMUWL/5iUsEM5n RokbkzvYYDqOr3nDDFd1qvsAI4TzjFHiweEmsFnCAmYSz37PYwKxRYA6jh38AjaKWWAHo0R/ 73egDg4ONgEtiTXt8SAmr4CdRNOfOpByFgFViaf7DzKC2KICERLHDy8Hs3kFBCV+TL7HAmJz ClhLzP69mB3EZhawknj2r5UVwhaXaG69yQJhy0tsXvMW7FAJgT1sEvNXvof600WiddYTJghb WOLV8S3sELaMRGfHQah4tcTFr7ugPq6RaLy9AarGWuLzpC3MEAv4JCZtm84Mcr+EAK9ER5sQ hOkhMX9zLES1o8TGJ1fYIcFzglHic9c3pgmM8rOQvDMLyQuzkLwwC8kLCxhZVjGKpJYW56an FhvqFSfmFpfmpesl5+duYgSmkdP/jr/fwfi0OeQQowAHoxIP7w01+Sgh1sSy4srcQ4wSHMxK IrzKJ4BCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW2j2iKFBNITS1KzU1MLUotgskwcnMB0kqQ7 96DldLNHBvWdtyt3tDIuTjF+kB21s/pDdtk7tf29ks5bk1IO/G9QOHOjyqJUbPeuU71L7Vc9 PLr0RE2V/UY5x9WlvCxhf+Y734jyXXe4f6mvrJjzV7FSxvrEuk3fjgXFiG/cxH9lBtPDpUk3 tgdM0uNd5d9/7IaBU8DiuCStyPBb7/9vU2Ipzkg01GIuKk4EAJ9IZXsfAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xK7pPWRWiDBa0sVlsnLGe1aJ58Xo2 i8u75rBZHJq6l9Fi7ZG77A6sHpevXWT22D93DbtH35ZVjB6fN8kFsERx2aSk5mSWpRbp2yVw ZayZuYKlYB93xae1Ug2MXZxdjJwcEgImEsfXvGGGsMUkLtxbz9bFyMUhJLCEUaK9cRczhPOM UeLT9RdsIFXCAmYSz37PYwKxRYC6jx38wgJSxCywi1Hi9ZS5UO2nGCX2P18J1M7BwSagJbGm PR7E5BWwk2j6UwfSyyKgKvF0/0FGEFtUIELiefN7VhCbV0BQ4sfkeywgNqeAtcTs34vZQWxm oL1fXh5mhbDFJZpbb7JA2PISm9e8ZZ7AKDgLSfssJC2zkLTMQtKygJFlFaNIamlxbnpusaFe cWJucWleul5yfu4mRmDQbzv2c/MOxksbgw8xCnAwKvHw3lCTjxJiTSwrrsw9xCjBwawkwqt8 AijEm5JYWZValB9fVJqTWnyIUZqDRUmct3fP6kghgfTEktTs1NSC1CKYLBMHJzD4mwT3/j0i J1TV6VczJaPu+nID5ttTg7h6Jlyv/eTFKLlq6V0JP2WWtTPUOM5+DUs6oT6x8cDJZI3Ea7cv R9hrHD/6mGPbY+/QtzmmVkxOlXvfbLbaHjjx/bZV7b8tru+UeCuzTSThwJp93i9vy7NucF3K wXTQyOJRvsinw5vz/nKpJp6b/f7PKiWW4oxEQy3mouJEAF7utSB2AgAA X-CMS-MailID: 20171130132141eucas1p19f118e06e195418e37ac85cc2bf4e44f X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171130124906eucas1p2a671ee7d62ddebe9fde3a5def2d97f44 X-RootMTR: 20171130124906eucas1p2a671ee7d62ddebe9fde3a5def2d97f44 References: <1512046112-9474-1-git-send-email-m.purski@samsung.com> <20171130125416.GB10595@n2100.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2017 01:54 PM, Russell King - ARM Linux wrote: > On Thu, Nov 30, 2017 at 01:48:32PM +0100, Maciej Purski wrote: >> Currently there is no information in any vfs about which devices >> a master component consists of, what makes debugging hard if >> one of the component devices fails to register. >> >> Add 'device_component' directory to debugfs. Create a new file for each >> component master, when it has been added. Remove it on a master >> deletion. Show a list of devices required by the given master and their >> status (registered or not). This provides an easy way to check, which >> device has failed to register if the given master device is not >> available in the system. >> >> Signed-off-by: Maciej Purski >> --- >> Changes in v4: >> - fix and expand commit message >> - inline no-op functions > > inline on static functions makes no sense - the compiler itself is at > liberty to inline any static function that it thinks would benefit, > and it is likely to do so with such a simple function. > > Generally we prefer to omit "inline" in .c files and let the compiler > decide whether to inline or not. > > What was the reason for making this change? Do you have a case where > this doesn't happen? > I don't have any case. I just thought this would be more obvious, but if the general preference is to omit "inline", I'll fix this in the next version. Thanks. Best regards, Maciej