From: David Heidelberg <david@ixit.cz>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Praveen Talari <praveen.talari@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
phone-devel <phone-devel@vger.kernel.org>
Subject: Re: [PATCH] serial: qcom-geni: Fix unbalanced runtime PM resume for no_console_suspend
Date: Fri, 18 Sep 2026 00:06:50 +0200 [thread overview]
Message-ID: <4fadd84c-ed8f-4a5f-a4dc-078fcf1171d2@ixit.cz> (raw)
In-Reply-To: <20260828-serial-qcom-geni-fix-unbalanced-rpm-resume-v1-1-af3e5aef17a6@oss.qualcomm.com>
On 28/08/2026 16:32, Abel Vesa wrote:
> When no_console_suspend is set for the serial console, the system
> suspend callback skips pm_runtime_force_suspend() to keep the console
> active. The resume callback still unconditionally calls
> pm_runtime_force_resume(), which triggers an "Unbalanced
> pm_runtime_enable!" warning.
>
> Only force resume when the suspend callback force suspended the device.
>
> Fixes: d0cd9c8d0fd5 ("serial: qcom-geni: add force suspend/resume to system sleep callbacks")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> drivers/tty/serial/qcom_geni_serial.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Seen the same "Unbalanced pm_runtime_enable!" on every resume with
no_console_suspend on OnePlus 6T; gone with this patch.
Tested-by: David Heidelberg <david@ixit.cz> # OnePlus 6T (sdm845)
prev parent reply other threads:[~2026-09-17 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 14:32 Abel Vesa
2026-08-28 14:40 ` Praveen Talari
2026-09-17 22:06 ` David Heidelberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fadd84c-ed8f-4a5f-a4dc-078fcf1171d2@ixit.cz \
--to=david@ixit.cz \
--cc=abel.vesa@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=praveen.talari@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®