From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] vfio: Use dev_printk() when possible
Date: Mon, 25 Mar 2019 13:49:25 -0700 [thread overview]
Message-ID: <4faf234df19c1b54b70cbe82c0dacacc58568b87.camel@perches.com> (raw)
In-Reply-To: <20190325194220.5873-1-helgaas@kernel.org>
On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote:
> Use dev_printk() when possible to make messages consistent with other
> device-related messages.
trivial note:
> diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
[]
> @@ -89,7 +89,8 @@ static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
> } while ((pcs_value & MDIO_CTRL1_RESET) && --count);
>
> if (pcs_value & MDIO_CTRL1_RESET)
> - pr_warn("%s XGBE PHY reset timeout\n", __func__);
> + dev_warn(&vdev->device, "%s XGBE PHY reset timeout\n",
> + __func__);
Many of these could use a colon after the %s used with __func__
to make the output more consistent with other modules.
next prev parent reply other threads:[~2019-03-25 20:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 19:42 Bjorn Helgaas
2019-03-25 20:49 ` Joe Perches [this message]
2019-03-29 17:03 ` Bjorn Helgaas
2019-03-29 20:32 ` Alex Williamson
2019-03-25 21:59 ` Auger Eric
2019-03-28 20:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4faf234df19c1b54b70cbe82c0dacacc58568b87.camel@perches.com \
--to=joe@perches.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®