From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "bmasney@redhat.com" <bmasney@redhat.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"driver-core@lists.linux.dev" <driver-core@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 2/4] pmdomain: core: migrate to dev_add_sync_state()
Date: Tue, 22 Sep 2026 12:00:05 +0000 [thread overview]
Message-ID: <4fb0f9cdbeb7c12bb66f7c591d2099ea1faec7a7.camel@siemens.com> (raw)
In-Reply-To: <20260626-clk-sync-state-v1-2-4156d8196dc8@redhat.com>
On Fri, 2026-06-26 at 12:32 -0400, Brian Masney wrote:
> We have cases where a device node represents a provider for multiple
> types of resources, like clocks, power-domains, resets, etc. Having just
> a single sync_state on the device is not sufficient since other
> frameworks will want to add their own sync_state callback.
>
> Migrate the pmdomain core code from dev_set_drv_sync_state() to
> dev_add_sync_state() so that this works nicely with other frameworks
> that want to add their own sync_state callback.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> Assisted-by: Claude:claude-opus-4-6
Assuming this is v3 (not specified in the Subject),
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> ---
> drivers/pmdomain/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c
> index 842c4169e290..22791353249c 100644
> --- a/drivers/pmdomain/core.c
> +++ b/drivers/pmdomain/core.c
> @@ -2697,7 +2697,7 @@ int of_genpd_add_provider_simple(struct device_node *np,
> genpd->sync_state = GENPD_SYNC_STATE_SIMPLE;
> device_set_node(&genpd->dev, fwnode);
> } else {
> - dev_set_drv_sync_state(dev, genpd_sync_state);
> + dev_add_sync_state(dev, genpd_sync_state);
> }
>
> put_device(dev);
> @@ -2771,7 +2771,7 @@ int of_genpd_add_provider_onecell(struct device_node *np,
> if (!dev)
> sync_state = true;
> else
> - dev_set_drv_sync_state(dev, genpd_sync_state);
> + dev_add_sync_state(dev, genpd_sync_state);
>
> put_device(dev);
--
Alexander Sverdlin
Siemens AG
www.siemens.com
next prev parent reply other threads:[~2026-09-22 12:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 16:32 [PATCH 0/4] clk: implement sync_state support Brian Masney
2026-06-26 16:32 ` [PATCH 1/4] driver: core: introduce dev_add_sync_state() Brian Masney
2026-06-29 10:11 ` Konrad Dybcio
2026-06-29 15:31 ` Brian Masney
2026-09-22 11:57 ` Sverdlin, Alexander
2026-06-26 16:32 ` [PATCH 2/4] pmdomain: core: migrate to dev_add_sync_state() Brian Masney
2026-06-29 12:29 ` Konrad Dybcio
2026-09-22 12:00 ` Sverdlin, Alexander [this message]
2026-06-26 16:32 ` [PATCH 3/4] driver: core: remove dev_set_drv_sync_state() Brian Masney
2026-09-22 12:02 ` Sverdlin, Alexander
2026-06-26 16:32 ` [PATCH 4/4] clk: implement sync_state support Brian Masney
2026-06-29 13:44 ` Konrad Dybcio
2026-06-29 15:48 ` Brian Masney
2026-09-22 13:17 ` Sverdlin, Alexander
2026-06-29 10:06 ` [PATCH 0/4] " Konrad Dybcio
2026-06-29 15:34 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fb0f9cdbeb7c12bb66f7c591d2099ea1faec7a7.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=bmasney@redhat.com \
--cc=driver-core@lists.linux.dev \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®