From: Jiri Slaby <jirislaby@kernel.org>
To: oushixiong <oushixiong@kylinos.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tty: vt: Fix spelling typo in comment
Date: Wed, 26 Jul 2023 11:58:11 +0200 [thread overview]
Message-ID: <4fb1c846-2439-84b4-3423-223103878413@kernel.org> (raw)
In-Reply-To: <20230726091044.705393-1-oushixiong@kylinos.cn>
On 26. 07. 23, 11:10, oushixiong wrote:
> Signed-off-by: oushixiong <oushixiong@kylinos.cn>
> ---
> drivers/tty/vt/vt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 1e8e57b45688..bcdd249e47a0 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -3473,7 +3473,7 @@ static int __init con_init(void)
> INIT_WORK(&vc_cons[currcons].SAK_work, vc_SAK);
> tty_port_init(&vc->port);
> visual_init(vc, currcons, 1);
> - /* Assuming vc->vc_{cols,rows,screenbuf_size} are sane here. */
> + /* Assuming vc->vc_{cols,rows,screenbuf_size} are same here. */
NACK for many reasons, incl. this is _wrong_.
Please read SubmittingPatches first.
--
js
next prev parent reply other threads:[~2023-07-26 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 9:10 oushixiong
2023-07-26 9:10 ` [PATCH 2/2] tty: vt: Remove some repetitive initialization oushixiong
2023-07-26 9:40 ` [PATCH 1/2] tty: vt: Fix spelling typo in comment Greg Kroah-Hartman
2023-07-26 9:58 ` Jiri Slaby [this message]
2023-07-27 20:45 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fb1c846-2439-84b4-3423-223103878413@kernel.org \
--to=jirislaby@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oushixiong@kylinos.cn \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®