From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE56C7EE23 for ; Mon, 5 Jun 2023 08:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbjFEIAM (ORCPT ); Mon, 5 Jun 2023 04:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231866AbjFEIAE (ORCPT ); Mon, 5 Jun 2023 04:00:04 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B0094 for ; Mon, 5 Jun 2023 00:59:38 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6513e7e5d44so2457635b3a.0 for ; Mon, 05 Jun 2023 00:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1685951978; x=1688543978; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=i/GVJvs0fO7RUWruqKiskwPZk0P6pKeBthWGtwyfpDQ=; b=KL7dhsuAz8Jm0gCfDhaKqdt0kygANUoCSHpmuNJcYPFG6VVZ1gCK7FAJCR9A5HZ2kT TCRsN5lB/7tM2fPWFn3yD0ouWUEZ6+Kwj15MSgahAHbaZl0ToIm6YiaEPQ3D7iEisLr3 AYKFKs4n7HVgy0YA8htSk5dMUoWlnvzJ0NZbNG/E1i6UZZX+toFTkpRoYRc3uVEL2nU7 wqua2b1xZHdma4G+Oh9gN0Nc/3g+RsmgdpdYcMSrkH1roRyoCl3NQiB+/8d+4nfzyEYw 1dwU+A/fj58fnDt9gY0BzilhSSOUIrrBKnvw4jsS09K8iPbMTd2L1Tu+fmYuzbTcOTuP SbIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685951978; x=1688543978; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=i/GVJvs0fO7RUWruqKiskwPZk0P6pKeBthWGtwyfpDQ=; b=hKgYTIooguVXXMzcPaQMle67roLAwz3Zo2LO4wY4V7KUad5oUbSoZDTjH/H+m6xu8C 2lmaVuCrOEm3FYaUOzlpGzk63KMxYnC4zNBOyAypQLxmyVyFHOeTpVi0Zz9PU3zx5V0c wmm7UbJwjn545V0+mJV+quFCTLBZjLlohkmp1f1AeuG8Bf/AbozjNyL9rHe6cUupmjaJ J29z5KZeSRmDsUTUi/CHK/Te0iFlhgzZE86QDAXCYaMNF5uPw7YQb5Vw8x41Gh/Mx1rM mr9dFbgNWyWcCNsqPAcn7i2ValKY2pWgiuJcAo4lxZ8cFnBTlyyBcE2Ue/4B7Hwl+Wpt llkQ== X-Gm-Message-State: AC+VfDz0JQZU7dXkVEhz36/CIIOxp8QnIafHLnhJY3IXTJEuIHCrML66 78L+Li+UJIkOFk2n567owcJuCV2wpK5ocbMV1dI= X-Google-Smtp-Source: ACHHUZ5+pa5F3cil1dzSW5I/tnOna61G4vLcCBFoHlY6dQ6bvthkr9eU/W5qwOK/0yI1CDRM91yhAA== X-Received: by 2002:a05:6a21:9988:b0:10b:fb01:a72a with SMTP id ve8-20020a056a21998800b0010bfb01a72amr3001108pzb.60.1685951978026; Mon, 05 Jun 2023 00:59:38 -0700 (PDT) Received: from [10.200.9.101] ([139.177.225.249]) by smtp.gmail.com with ESMTPSA id f3-20020a170902ce8300b001ae365072ccsm5908673plg.122.2023.06.05.00.59.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 00:59:37 -0700 (PDT) Message-ID: <4fb5f66d-c8c2-f857-7461-b974154dbc2b@bytedance.com> Date: Mon, 5 Jun 2023 15:59:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 00/14] Reduce preallocations for maple tree To: "Yin, Fengwei" Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Liu, Yujie" , "Liam R. Howlett" , Andrew Morton , Peng Zhang References: <20230601021605.2823123-1-Liam.Howlett@oracle.com> <7a5dc9ce-b58f-e1b3-db1a-d00a8a556ae5@intel.com> From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/6/5 14:18, Yin, Fengwei 写道: > > > On 6/5/2023 12:41 PM, Yin Fengwei wrote: >> Hi Peng, >> >> On 6/5/23 11:28, Peng Zhang wrote: >>> >>> >>> 在 2023/6/2 16:10, Yin, Fengwei 写道: >>>> Hi Liam, >>>> >>>> On 6/1/2023 10:15 AM, Liam R. Howlett wrote: >>>>> Initial work on preallocations showed no regression in performance >>>>> during testing, but recently some users (both on [1] and off [android] >>>>> list) have reported that preallocating the worst-case number of nodes >>>>> has caused some slow down.  This patch set addresses the number of >>>>> allocations in a few ways. >>>>> >>>>> During munmap() most munmap() operations will remove a single VMA, so >>>>> leverage the fact that the maple tree can place a single pointer at >>>>> range 0 - 0 without allocating.  This is done by changing the index in >>>>> the 'sidetree'. >>>>> >>>>> Re-introduce the entry argument to mas_preallocate() so that a more >>>>> intelligent guess of the node count can be made. >>>>> >>>>> Patches are in the following order: >>>>> 0001-0002: Testing framework for benchmarking some operations >>>>> 0003-0004: Reduction of maple node allocation in sidetree >>>>> 0005:      Small cleanup of do_vmi_align_munmap() >>>>> 0006-0013: mas_preallocate() calculation change >>>>> 0014:      Change the vma iterator order >>>> I did run The AIM:page_test on an IceLake 48C/96T + 192G RAM platform with >>>> this patchset. >>>> >>>> The result has a little bit improvement: >>>> Base (next-20230602): >>>>    503880 >>>> Base with this patchset: >>>>    519501 >>>> >>>> But they are far from the none-regression result (commit 7be1c1a3c7b1): >>>>    718080 >>>> >>>> >>>> Some other information I collected: >>>> With Base, the mas_alloc_nodes are always hit with request: 7. >>>> With this patchset, the request are 1 or 5. >>>> >>>> I suppose this is the reason for improvement from 503880 to 519501. >>>> >>>> With commit 7be1c1a3c7b1, mas_store_gfp() in do_brk_flags never triggered >>>> mas_alloc_nodes() call. Thanks. >>> Hi Fengwei, >>> >>> I think it may be related to the inaccurate number of nodes allocated >>> in the pre-allocation. I slightly modified the pre-allocation in this >>> patchset, but I don't know if it works. It would be great if you could >>> help test it, and help pinpoint the cause. Below is the diff, which can >>> be applied based on this pachset. >> I tried the patch, it could eliminate the call of mas_alloc_nodes() during >> the test. But the result of benchmark got a little bit improvement: >> 529040 >> >> But it's still much less than none-regression result. I will also double >> confirm the none-regression result. > Just noticed that the commit f5715584af95 make validate_mm() two implementation > based on CONFIG_DEBUG_VM instead of CONFIG_DEBUG_VM_MAPPLE_TREE). I have > CONFIG_DEBUG_VM but not CONFIG_DEBUG_VM_MAPPLE_TREE defined. So it's not an > apple to apple. > > > I disable CONFIG_DEBUG_VM and re-run the test and got: > Before preallocation change (7be1c1a3c7b1): > 770100 > After preallocation change (28c5609fb236): > 680000 > With liam's fix: > 702100 > plus Peng's fix: > 725900 Thank you for your test, now it seems that the performance regression is not so much. > > > Regards > Yin, Fengwei > >> >> >> Regards >> Yin, Fengwei >> >>> >>> Thanks, >>> Peng >>> >>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >>> index 5ea211c3f186..e67bf2744384 100644 >>> --- a/lib/maple_tree.c >>> +++ b/lib/maple_tree.c >>> @@ -5575,9 +5575,11 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp) >>>          goto ask_now; >>>      } >>> >>> -    /* New root needs a singe node */ >>> -    if (unlikely(mte_is_root(mas->node))) >>> -        goto ask_now; >>> +    if ((node_size == wr_mas.node_end + 1 && >>> +         mas->offset == wr_mas.node_end) || >>> +        (node_size == wr_mas.node_end && >>> +         wr_mas.offset_end - mas->offset == 1)) >>> +        return 0; >>> >>>      /* Potential spanning rebalance collapsing a node, use worst-case */ >>>      if (node_size  - 1 <= mt_min_slots[wr_mas.type]) >>> @@ -5590,7 +5592,6 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp) >>>      if (likely(!mas_is_err(mas))) >>>          return 0; >>> >>> -    mas_set_alloc_req(mas, 0); >>>      ret = xa_err(mas->node); >>>      mas_reset(mas); >>>      mas_destroy(mas); >>> >>> >>>> >>>> >>>> Regards >>>> Yin, Fengwei >>>> >>>>> >>>>> [1] https://lore.kernel.org/linux-mm/202305061457.ac15990c-yujie.liu@intel.com/ >>>>> >>>>> Liam R. Howlett (14): >>>>>    maple_tree: Add benchmarking for mas_for_each >>>>>    maple_tree: Add benchmarking for mas_prev() >>>>>    mm: Move unmap_vmas() declaration to internal header >>>>>    mm: Change do_vmi_align_munmap() side tree index >>>>>    mm: Remove prev check from do_vmi_align_munmap() >>>>>    maple_tree: Introduce __mas_set_range() >>>>>    mm: Remove re-walk from mmap_region() >>>>>    maple_tree: Re-introduce entry to mas_preallocate() arguments >>>>>    mm: Use vma_iter_clear_gfp() in nommu >>>>>    mm: Set up vma iterator for vma_iter_prealloc() calls >>>>>    maple_tree: Move mas_wr_end_piv() below mas_wr_extend_null() >>>>>    maple_tree: Update mas_preallocate() testing >>>>>    maple_tree: Refine mas_preallocate() node calculations >>>>>    mm/mmap: Change vma iteration order in do_vmi_align_munmap() >>>>> >>>>>   fs/exec.c                        |   1 + >>>>>   include/linux/maple_tree.h       |  23 ++++- >>>>>   include/linux/mm.h               |   4 - >>>>>   lib/maple_tree.c                 |  78 ++++++++++---- >>>>>   lib/test_maple_tree.c            |  74 +++++++++++++ >>>>>   mm/internal.h                    |  40 ++++++-- >>>>>   mm/memory.c                      |  16 ++- >>>>>   mm/mmap.c                        | 171 ++++++++++++++++--------------- >>>>>   mm/nommu.c                       |  45 ++++---- >>>>>   tools/testing/radix-tree/maple.c |  59 ++++++----- >>>>>   10 files changed, 331 insertions(+), 180 deletions(-) >>>>>