From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: x86@kernel.org, linux-video@atrey.karlin.mff.cuni.cz,
xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Martin Mares <mj@ucw.cz>
Subject: Re: [PATCH -tip v2 1/2] x86/boot: Remove semicolon from "rep" prefixes
Date: Fri, 18 Apr 2025 12:20:13 +0100 [thread overview]
Message-ID: <4fb6d880-3d5f-4d42-8419-dcc697949a10@citrix.com> (raw)
In-Reply-To: <CAFULd4ZNiRdARn8O98zROQRWoL1ASQ+iPPTTmLRxjo9SGRHyRg@mail.gmail.com>
On 18/04/2025 12:15 pm, Uros Bizjak wrote:
> On Fri, Apr 18, 2025 at 12:24 PM Andrew Cooper
> <andrew.cooper3@citrix.com> wrote:
>> On 18/04/2025 8:13 am, Uros Bizjak wrote:
>>> diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c
>>> index f2e96905b3fe..0641c8c46aee 100644
>>> --- a/arch/x86/boot/video.c
>>> +++ b/arch/x86/boot/video.c
>>> @@ -292,7 +292,7 @@ static void restore_screen(void)
>>> "shrw %%cx ; "
>>> "jnc 1f ; "
>>> "stosw \n\t"
>>> - "1: rep;stosl ; "
>>> + "1: rep stosl ; "
>>> "popw %%es"
>> Doesn't this one still need a separator between STOSL and POPW ?
> ";" is a separator as well.
Yes, it is. I've clearly not had enough coffee yet. Sorry for the noise.
~Andrew
prev parent reply other threads:[~2025-04-18 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 7:13 Uros Bizjak
2025-04-18 7:13 ` [PATCH -tip v2 2/2] x86/asm: " Uros Bizjak
2025-04-18 8:16 ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-04-18 8:16 ` [tip: x86/boot] x86/boot: " tip-bot2 for Uros Bizjak
2025-04-18 10:24 ` [PATCH -tip v2 1/2] " Andrew Cooper
2025-04-18 11:15 ` Uros Bizjak
2025-04-18 11:20 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fb6d880-3d5f-4d42-8419-dcc697949a10@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-video@atrey.karlin.mff.cuni.cz \
--cc=mingo@kernel.org \
--cc=mj@ucw.cz \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®