From: Uros Bizjak <ubizjak@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Xin Li <xin3.li@intel.com>,
Xin Li <xin@zytor.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: RFC, untested: handing of MSR immediates and MSRs on Xen
Date: Thu, 24 Oct 2024 00:08:02 +0200 [thread overview]
Message-ID: <4fba013b-6cce-d81c-dccf-994f56548629@gmail.com> (raw)
In-Reply-To: <83b67fa6-fbe0-4a38-891c-b0b49d5cc5f9@zytor.com>
On 23. 10. 24 23:34, H. Peter Anvin wrote:
> And I of course forgot the include the actual code.
> ALTERNATIVE_2("ds wrmsr",
> "wrmsrns",
> X86_FEATURE_WRMSRNS,
> "call %P[xen]",
> X86_FEATURE_XENPV)
Please use %c asm operand modifier instead of %P. Please see comment in
arch/x86/include/asm/alternative.h for the reason:
--q--
* Use the %c operand modifier which is the generic way to print a bare
* constant expression with all syntax-specific punctuation omitted. %P
* is the x86-specific variant which can handle constants too, for
* historical reasons, but it should be used primarily for PIC
* references: i.e., if used for a function, it would add the PLT
* suffix.
--/q--
Uros.
next prev parent reply other threads:[~2024-10-23 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 21:31 H. Peter Anvin
2024-10-23 21:34 ` H. Peter Anvin
2024-10-23 22:08 ` Uros Bizjak [this message]
2024-10-23 23:05 ` H. Peter Anvin
2024-10-23 21:52 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fba013b-6cce-d81c-dccf-994f56548629@gmail.com \
--to=ubizjak@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®