From: Helge Deller <deller@gmx.de>
To: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>,
Jingoo Han <jingoohan1@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] fbdev: s3c-fb: Fix potential registration corruption on probe failure
Date: Wed, 18 Nov 2026 19:17:08 +0100 [thread overview]
Message-ID: <4fba8bdb-de77-4418-8ffc-7ad6982e8027@gmx.de> (raw)
In-Reply-To: <20261118-324f82bd41-fbdev-0@mail.sdu.edu.cn>
On 11/18/26 15:22, Guangshuo Li wrote:
> Probe failure cleanup calls unregister_framebuffer() even when the
> window has not been registered. Its zero-initialized node can then
> remove another framebuffer from registered_fb[0].
>
> Track successful registration and only unregister those framebuffers.
> Also skip empty window slots while unwinding a failed probe.
>
> This issue was found by our static analysis tool under development.
I think s3c_fb_probe_win() needs to clean up when some things
like cmap fail to be allocated.
Your patch seems to just work around one of the possible pitfalls.
Helge
prev parent reply other threads:[~2026-11-18 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 14:22 Guangshuo Li
2026-11-18 18:17 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fba8bdb-de77-4418-8ffc-7ad6982e8027@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=liguangshuo@mail.sdu.edu.cn \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®