From: "Hugo Osvaldo Barrera" <hugo@whynothugo.nl>
To: "Conor Dooley" <conor@kernel.org>
Cc: "Marcel Holtmann" <marcel@holtmann.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: bluetooth: broadcom: add BCM43752
Date: Mon, 29 Jun 2026 18:57:17 +0200 [thread overview]
Message-ID: <4fbe561f-bde2-44a8-8198-6a0a179f62f3@app.fastmail.com> (raw)
In-Reply-To: <20260629-handwork-retract-224b150e5969@spud>
On Mon, 29 Jun 2026, at 14:04, Conor Dooley wrote:
> On Mon, Jun 29, 2026 at 01:32:18PM +0200, Hugo Osvaldo Barrera wrote:
>>
>>
>> On Sun, 28 Jun 2026, at 21:17, Conor Dooley wrote:
>> > On Sun, Jun 28, 2026 at 11:55:00AM +0200, Hugo Osvaldo Barrera wrote:
>> >> Document the compatible string for BCM43752.
>> >>
>> >> Signed-off-by: Hugo Osvaldo Barrera <hugo@whynothugo.nl>
>> >> ---
>> >> .../devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml | 1 +
>> >> 1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> >> index 95501e858e6f..04e8a968548d 100644
>> >> --- a/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> >> +++ b/Documentation/devicetree/bindings/net/bluetooth/brcm,bluetooth.yaml
>> >> @@ -29,6 +29,7 @@ properties:
>> >> - brcm,bcm43438-bt
>> >> - brcm,bcm4345c5
>> >> - brcm,bcm43540-bt
>> >> + - brcm,bcm43752-bt
>> >
>> > This new compatible uses no match data. Why is a fallback compatible not
>> > suitable?
>> >
>>
>> I wasn't aware that this was the preferred approach.
>>
>> I used `compatible = "brcm,bcm43752-bt", "brcm,bcm43430a0-bt";`
>> in my DT and Bluetooth works equally well. Both of these patches
>> can be ignored, thanks for the review.
>
> You still need to add a binding patch to document the new compatible,
> just it will permit the fallback.
>
Right, CHECK_DTBS=y fails without that change.
So the second patch (which changes brcm,bluetooth.yaml) should be merged,
but not the other one is unnecessary and can be ignored.
I don't need to re-submit the second path independently, it's fine to
just merge one patch and ignore the other, right?
--
Hugo
next prev parent reply other threads:[~2026-06-29 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 9:54 [PATCH 1/2] Bluetooth: hci_bcm: " Hugo Osvaldo Barrera
2026-06-28 9:55 ` [PATCH 2/2] dt-bindings: bluetooth: broadcom: " Hugo Osvaldo Barrera
2026-06-28 16:49 ` Hugo Osvaldo Barrera
2026-06-28 19:16 ` Conor Dooley
2026-06-28 19:17 ` Conor Dooley
2026-06-29 11:32 ` Hugo Osvaldo Barrera
2026-06-29 12:04 ` Conor Dooley
2026-06-29 16:57 ` Hugo Osvaldo Barrera [this message]
2026-06-29 21:15 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fbe561f-bde2-44a8-8198-6a0a179f62f3@app.fastmail.com \
--to=hugo@whynothugo.nl \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®