From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 424BF14F135 for ; Fri, 10 Jan 2025 07:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736494117; cv=none; b=Vp8EWM2cBaPU4vqMa3bZl5KXjVxudBCoE+lAEFuN60FVS5w/OE1htuYmOK8qAKcGw4smAQuoisLbLb4EjY4BzzxlWCZCwS4WlBSAX2LUiy9hVyVzwzvz5f7otrQEomZQTwtqcSgaaOlGf7rO28iLOt0sD2sQ9enGJsky0FnmCC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736494117; c=relaxed/simple; bh=Tj80GQgz7cdLS31HWkURdY3Nqa0FV5Yb4usVjm7yzz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sGvYcPQINrF592/7sb4kK45+yPYIzIDI8kVHlwJP+2b6Pfv9xVLBdkdPuTaGtprT7h7wTjuNWJeOmyGrxkjcREvuXpLUPQwDRTcXz2MMdLrjG/dhhukR50YgAm6Y66B1AlIQ/vetd8XC64vU6MQzX/Uk2SvC9DXP3cIHWGi34Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=T8Lf3jm7; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="T8Lf3jm7" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43618283dedso17297685e9.3 for ; Thu, 09 Jan 2025 23:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736494113; x=1737098913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ZJRFGM2ZG+coRXTqQCvYs0LKh46U5mjzozm/MQ0XUOY=; b=T8Lf3jm77OgVczeEuM9elYkauGXdU8A4XtjP7LCknRH8a/605wBahh64Uo9zbg9uRF G8c51H/GuuqZlCt95CC0l/HZH3Y/v+VptXUvfUm1cbOj9Zc3esuTGAw6jgs086/NMkku etr2C2CdAk52I/qcA9B9LyKdPlsV78jyDo4RZayk7i3oVEQJS11e8M20j/XoiESxor3D 8S27lifJ3lxu7MpA/kYRcVziAceP5es5O064jzg6inZ2ISCuKhv/eO6dXcB2VGj70aMr R3/8UiOaQySKZjyZGAD+tBmfhEgguxREV3iCla6bj7MgWZBRD2Roir/GPulFkwQZatwQ Dhaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736494113; x=1737098913; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZJRFGM2ZG+coRXTqQCvYs0LKh46U5mjzozm/MQ0XUOY=; b=uwn+Aznp65zteyCPDLNqj3AVxRaL/9a9mpviuu+J58mzMKNeE4efym9AFkmFf7BnQh G+vQ0fJjsGeByT0QuN9+uIt5xoOM2jumvzwMsrwFxkbCYS6ibE8lFTiiwrlv0UlA0Lib fSNS0Zi6o9IVTuf54A9tg9Bz+OBEffnPFLwnSTLU6pj+g2xjHkEu5CtRl52I20uJRRU2 R9j53knDLcBLjdeaVNzvHOpBAgyWNMYnGWHDLkOAnk1EfRTiBOKr/J029R6wKzIM+IAr QlKsYyMb7AEmSgj8Edlge42s5YzgfgwJCD5PzydKot2m6sQNt0hQR6vy/1WJ0bVq5sna PFHA== X-Forwarded-Encrypted: i=1; AJvYcCWd+CXKcMl64SPO/6Kwn4OUet7nUDHxQjlaYP3l/OoavsOWnSCicLTCEZ+2z1piSlusU//MKkN/7Ze0x3U=@vger.kernel.org X-Gm-Message-State: AOJu0YzqaEk5QjF9jU3VGHp9/OpkOsLbGohcL+8gcdSikHMnM9XZxAta EJ37oJXy67zEGupwfHHiBbYWDKdyUrVv65zNjo246DqbCfNAxvCC4MG8H+ztbA== X-Gm-Gg: ASbGncuS+95Q8RdwL89hlVROAQ3jfYaKQx+UcJAyCfkador2RC5wkd2/xADI3MEPlMm yPQalD5wGUP8ed4aGEt1/JEiqXibowZG7OVBwzQmZVW89WS8tim3Hpn1NQq2EZaLWH5itg1wyrl KZPBavxh+2lKGeAhZ3oXIllnSaOpMmRuqk14R1+PFXco6c2JT7fx1v10IoHgbNqmFz5HSyMW5iX ZJmJ07oWVZaX3salzmXaNkVw8uYb4pD6e8Zxav5qGvlMCF4nx4o0AtMnJYhgseAdEwENAPVXk0r xeBOxhprW0IbM0U5GHRVaEdlKOQesVftRCu3qjXBoA== X-Google-Smtp-Source: AGHT+IENrB3MhlnYRLXmvbJQZ89EztD+WkABHcrx/ugwLRvqd+MU+lGMtQyjjAiRCrOMAtmOMl/uWw== X-Received: by 2002:a05:600c:a45:b0:434:a75b:5f59 with SMTP id 5b1f17b1804b1-436e26adfa2mr80816525e9.3.1736494113247; Thu, 09 Jan 2025 23:28:33 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e37c17sm43086665e9.27.2025.01.09.23.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 23:28:32 -0800 (PST) Message-ID: <4fbf231b-7389-4956-8c7c-6412aa0c4736@suse.com> Date: Fri, 10 Jan 2025 08:28:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] xen: update pvcalls_front_accept prototype To: Stefano Stabellini Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <0f8fc348-14f5-40ac-912a-1785caedb675@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10.01.2025 01:10, Stefano Stabellini wrote: > On Wed, 8 Jan 2025, Jan Beulich wrote: >> On 08.01.2025 00:30, Stefano Stabellini wrote: >>> On Tue, 7 Jan 2025, Jan Beulich wrote: >>>> On 06.01.2025 22:36, Stefano Stabellini wrote: >>>>> xen: update pvcalls_front_accept prototype >>>>> >>>>> Signed-off-by: Stefano Stabellini >>>>> --- >>>>> >>>>> Changes in v2: >>>>> - also update pvcalls-front.c >>>> >>>> The patch still gives the impression of being incomplete: There's no >>>> caller of the function that you update. However, there's no such caller >>>> in the first place. Why don't you just delete the function then? >>> >>> It is meant to be called from an out-of-tree module, which has not been >>> upstreamed yet >> >> And which then would require an EXPORT_SYMBOL() anyway. In Xen, as you're >> well aware, such unreachable code would actually constitute a Misra >> violation. >> >> Without any in-tree caller, imo the change needs a non-empty description, >> clarifying why the adjustment is wanted / needed. > > How about: > > --- > xen: update pvcalls_front_accept prototype > > While currently there are no in-tree callers of these functions, it is > best to keep them up-to-date with the latest network API. SGTM, fwiw. Jan