mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paresh Bhagat <p-bhagat@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <praneeth@ti.com>,
	<kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<khasim@ti.com>, <v-singh1@ti.com>, <afd@ti.com>, <bb@ti.com>,
	<devarsht@ti.com>, "Vadapalli, Siddharth" <s-vadapalli@ti.com>
Subject: Re: [EXTERNAL] Re: [PATCHv4 4/6] arm64: dts: ti: Add support for AM62D2-EVM
Date: Thu, 26 Jun 2025 13:54:49 +0530	[thread overview]
Message-ID: <4fc54cf9-6417-42f1-8da4-4c8182f74adf@ti.com> (raw)
In-Reply-To: <bf784ce6-aee7-4366-87ab-f0f79f8ef28c@lunn.ch>

Hi Andrew,

On 24/06/25 13:51, Andrew Lunn wrote:
> > +&cpsw_port1 { > + status = "okay"; > + phy-mode = "rgmii-rxid"; > + 
> phy-handle = <&cpsw3g_phy0>; Does the PCB have extra long RX clock 
> lines? More likely, this should be 'rgmii-id', and you should delete 
> the ti,rx-internal-delay
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uXdgV9dududxisXOFnkjP9PiILYQjt7Q3CKXWbpFj_azwskWiOd4wL5JX89-p35UM2TbsxxlxwNFQJTlPm4wjyyHNTY$> 
>
> ZjQcmQRYFpfptBannerEnd
> > +&cpsw_port1 {
> > +	status = "okay";
> > +	phy-mode = "rgmii-rxid";
> > +	phy-handle = <&cpsw3g_phy0>;
>
> Does the PCB have extra long RX clock lines?
>
> More likely, this should be 'rgmii-id', and you should delete the
> ti,rx-internal-delay in the PHY node, allowing it to insert the 2ns
> delay in the normal way.
>
> 	Andrew

I assume you are referring to the changes in a patch here
https://lore.kernel.org/r/cover.1750756583.git.matthias.schiffer@ew.tq-group.com/

Will fix this in next version. Thanks for the review.


  reply	other threads:[~2025-06-26  8:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 14:12 [PATCHv4 0/6] Add support for AM62D2 SoC and EVM Paresh Bhagat
2025-06-23 14:12 ` [PATCHv4 1/6] arm64: dts: ti: Add bootph property to nodes at source for am62a Paresh Bhagat
2025-06-23 14:45   ` Bryan Brattlof
2025-06-24  9:13     ` Paresh Bhagat
2025-06-23 14:12 ` [PATCHv4 2/6] dt-bindings: arm: ti: Add bindings for AM62D2 SoC Paresh Bhagat
2025-06-23 14:25   ` Krzysztof Kozlowski
2025-06-24 10:39     ` Paresh Bhagat
2025-06-24 10:55       ` Krzysztof Kozlowski
2025-06-24 11:21         ` Paresh Bhagat
2025-06-23 14:12 ` [PATCHv4 3/6] arm64: dts: ti: Add pinctrl entries for AM62D2 family of SoCs Paresh Bhagat
2025-06-23 14:12 ` [PATCHv4 4/6] arm64: dts: ti: Add support for AM62D2-EVM Paresh Bhagat
2025-06-24  8:21   ` Andrew Lunn
2025-06-26  8:24     ` Paresh Bhagat [this message]
2025-06-23 14:12 ` [PATCHv4 5/6] arm64: dts: ti: Update firmware-name for IPC Paresh Bhagat
2025-06-23 14:29   ` Bryan Brattlof
2025-06-24  9:12     ` Paresh Bhagat
2025-06-23 14:12 ` [PATCHv4 6/6] arm64: dts: ti: Add eMMC support for AM62D Paresh Bhagat
2025-06-23 14:28   ` Bryan Brattlof
2025-06-24  9:11     ` Paresh Bhagat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fc54cf9-6417-42f1-8da4-4c8182f74adf@ti.com \
    --to=p-bhagat@ti.com \
    --cc=afd@ti.com \
    --cc=andrew@lunn.ch \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khasim@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=v-singh1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®