From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15573.qiye.163.com (mail-m15573.qiye.163.com [101.71.155.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED992FB091; Fri, 24 Oct 2025 08:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761292805; cv=none; b=N6B1SpAiLDc07RHk/uICQPi/m1hX0RQsWcpy8ZjaTDt2eqCCHMUgeAYv3q3Imd9oQSYRcv1aaK5u9p0FhB+TTc5CJAtfPwz+zeoh+Vai2wo8XOgp5M1HvXUX8XJofs7vNWmw6UhZFiOOCFsofIzisE06XqCrYbwB9ORzpXsAFWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761292805; c=relaxed/simple; bh=8/c2zO3wjjVEVKC7w7sGL42qX58Qw4g6k9YQBSWM3h8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pyLzj+SQ5IXZGxEokVoNhMgu7xpXQ4d1iJZwgmCeLJ+EEJTEXi5T8aK1u0RgmAOk09lUgfbgorQysM6iKsSZsO5rt3OcuU3jI8EkbOYfYelVaCTN+dvgccxPjBch+MhaRoDKMOpmD5LyzR3tXq6ZnwvslrbXe07LQJevk9ykLi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=QaYS+xGW; arc=none smtp.client-ip=101.71.155.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="QaYS+xGW" Received: from [172.16.12.149] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 270e97439; Fri, 24 Oct 2025 15:59:51 +0800 (GMT+08:00) Message-ID: <4fddba9a-b073-4bca-bd13-64a415f4bc47@rock-chips.com> Date: Fri, 24 Oct 2025 15:59:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions To: Heikki Krogerus Cc: Chaoyi Chen , Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> <3a24bd7f-c247-4541-8cf5-c1e66e2af5a0@rock-chips.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9a153b2e3e03abkunm42a5cff32ee4f7 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQksYGlZCGUJPHU1DSEpNThhWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSEpPSE xVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=QaYS+xGWbmlxS3kZEJm0a+NYYxT+z5Us5JjdoYYrwKfwWRwLPdNdoBqojU08LMSVNkW2NIt3ivjahLd1DVJdesdRGPkSC4FCyheMfrC+mvLZrgdXQB4BixWM4KY9vnwKKHrM7/OMtoXWLyQqUwV1fQRklY7nO+ZKaFuWNKD3re8=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=A1oUD+BICHOTQ/+ohzJOid/WRrQzOP6u0erXNB3l774=; h=date:mime-version:subject:message-id:from; Hi Heikki, On 10/24/2025 3:43 PM, Heikki Krogerus wrote: >> I noticed the following statement in typec_register_altmode(): >> >> ``` >> >>     /* The partners are bind to drivers */ >>     if (is_typec_partner(parent)) >>         alt->adev.dev.bus = &typec_bus; >> >> ``` >> >> If the condition is not met, the bus will not be set, which means bus_notify() >> won't be able to take effect. Did I miss something? > Right, that would be the condition that I was talking about. Only > partner altmodes are used in the bus. > > Hold on! Do you need the port altmode instead of the partner altmode? > If that's the case, then we can't use the bus notifier. So we'll need > the separate notifier chain after all. Yes, we need port altmode.  The partner altmode device appears too late for DRM device, as it only shows up after the corresponding DP device is inserted. > > Let me take a closer look at patch 2/9. Sorry about the hassle. > -- Best, Chaoyi