From: Bean Huo <huobean@gmail.com>
To: Avri Altman <avri.altman@wdc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Bean Huo <beanhuo@micron.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: Allow RTT negotiation
Date: Thu, 2 May 2024 21:51:03 +0200 [thread overview]
Message-ID: <4fe336f1-0441-4697-9da5-45a5f7a4007a@gmail.com> (raw)
In-Reply-To: <20240502131943.7292-1-avri.altman@wdc.com>
Avri,
On 02.05.24 3:19 PM, Avri Altman wrote:
> + /* RTT override makes sense only for UFS-4.0 and above */
> + if (dev_info->wspecversion < 0x400)
> + return;
> +
> + rtt = min_t(int, desc_buf[DEVICE_DESC_PARAM_RTT_CAP], hba->nortt);
> + /* rtt is 2 after manufacturing */
> + if (rtt < 3)
> + return;
> +
> + if (ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR,
> + QUERY_ATTR_IDN_MAX_NUM_OF_RTT, 0, 0, &rtt))
> + dev_err(hba->dev, "failed writing bMaxNumOfRTT\n");
> +}
bMaxNumOfRTT is Persistent Property, do we need to re-write every time
power cycle?
Kind regards,
Bean
next prev parent reply other threads:[~2024-05-02 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 13:19 Avri Altman
2024-05-02 19:51 ` Bean Huo [this message]
2024-05-03 10:43 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe336f1-0441-4697-9da5-45a5f7a4007a@gmail.com \
--to=huobean@gmail.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®