From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 918CC3932D1 for ; Wed, 24 Jun 2026 07:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782287243; cv=none; b=qYseUuSeX6Iso+I8g/DDUSAz+0I+e42Vuou0/4oYc+3cvFRtEdCrEgMH0OFQdYOYngeTy5JfgrNKIma5spUuyZt/OWrvdO8Zq/H23VCgM+0rjJxsc4R56GAgmCF5nj6MiSpTOmJskM8YteqGHBHlae5mKs1OT4i8psNnESjFyWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782287243; c=relaxed/simple; bh=SubK8zh8375/xh1JLgTbSXAfRTQrObsHSJUFoEOOZOg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ISCki4fcqrK750j2t5OdRl2eSugxsyC4hqcgiTiIpv6PIurRc9CR8Rh3qrKE+Y0jfMOweEY+4ck5aCT8Duy48qa3NH1Bsssm2Iw58vYnNB9WOfyOns8tKVccBD73PhWnt++WpeyUsBReHYNHCBtyV1cJz2Yt6gko3M/HzB9qykw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BMGb4dDH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C3qN80LE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BMGb4dDH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C3qN80LE" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65O5tqLk1892144 for ; Wed, 24 Jun 2026 07:47:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /g4fRALXysleQymhzTRyHSwPBhUJqCQ0cZjYYVP6ilc=; b=BMGb4dDHJyH/0WEN v8/5eV9pYq5LZDPtvFoG8vxESxJYIDq7nrMFWDwlW98oXAUncUy3amdI4f7Zal7s ABE7HLm8xtm3iW3pyaoOUyfYERJhUpxIjtduP0bSyNtqHTLGFE7B38+KnLkTk48r N4H1pb8BfiU89LfCVNL5XdFk1S5rs4vHPp8BsCEnbXggr54e41fLs58v0NGKj+Ww Veavpn/+RBGPde6sv2G0oqjCpULKNFUut+OzkqKrGnzstWsx33tzVALLzpyKTtGG o6wdwwYSObBylDHYWHDjedLHHFfxHqqCwh+qUhb1KgGxUyAwN0ABJYMFk/azSm4q FJXG/A== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f05bf94n6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 07:47:21 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8ded0d4d805so2089816d6.1 for ; Wed, 24 Jun 2026 00:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782287241; x=1782892041; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/g4fRALXysleQymhzTRyHSwPBhUJqCQ0cZjYYVP6ilc=; b=C3qN80LE3PZ0Ab4yqxa/eObUcZQgRCZBXoYOyyyaCjmu0zk2GcZrV2qIHzlI4OFsu2 QWJ7kxDQNHg+jp2kyMt6Gc1SrOB+dqHsvfLVnt919U/qC+tPtgXL91d6NH9tp0ll+Ttt Ijxs7sVbDv6Hlil5DrHJqFxE4bT279QSnKf+svEhp5/hdymoOpHhlP7+HHdl5zoasKxd Cvoqg843McSHJCi7Jxl6mMK/hkbyiQyVIuZH4lG1BDzfJCG7jJltcUmX4+OABqFWZ6v5 xeoMrJsMI6z820e5Hq/XNbSevJkSpxdu5I74iOWp6P4S+KAueY6LS/CCvl9xXST9sIoq E5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782287241; x=1782892041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/g4fRALXysleQymhzTRyHSwPBhUJqCQ0cZjYYVP6ilc=; b=KSpgAl+HuFJrv9ouZdkmvTWx9ka89uE8zHUo+/Sw0OqLOL7aBAPJaLBVoFsYM+XTZC ddr+Zh0aGYhWPntL9+Do9e+xNPEOvlArtT9+Fb+sYra41ITfjBE9EcZ6PcqAPj869Hom EnV9Jk6ZH6RaGMqmh4gHtdjc9xVmUlydBfyX8Hr21ScNm3PMgjlUddgxqEWkGRqyD3hN DdCzsMUCMMAW0hz8Yf931nP3saR34vZoIXUZpVqOEIP/SWyILoroV1e3HesMBanPRrWr 0WicjPOsmyjgNoYK6j1UqATXyhWu8YgnCvlvpjf/DWMBZgiB0xNojc5thbIzNle65foo Pg1g== X-Forwarded-Encrypted: i=1; AFNElJ+qyRSWdS6NP8jLBcW2PN+L+Os43Fl90ocMjlTNQxEeBaUOglZ7i49GiFCDizIpTfh8VGgNX0JYe8Uh5gg=@vger.kernel.org X-Gm-Message-State: AOJu0YxUlvdeyuFlA+LXZ/8eE/gnONVaeCb3zpy1LEPDHVkcA2Y02nth q/pwoQ/rmCJYsA70swUGRs7dbu7J5qsXXnr8JJbcoqPyMEnStW2nFAA6y7F+ctEvSOes34FyrZi M5F3bIBtCEZ9W8EfLheFCTFCNkiIiCslYl98CKdNiKzI4BUh9xC2S4Sm1645fjqsk9dI= X-Gm-Gg: AfdE7cmeZB2ZzJOcSNnXR7rlhAqTGahF/t+njJkhQH8tDzuXsD55T4M2cIgSFWJjQG6 yyUPFcb4wIgOkB6GBMHqLrSREDywMob816NQvUdwYNgfYAXTDuHNt0H3jQJ3E5i2sdvyhaPKN3X H39OPcwNcNp5BKART/XTf2T5VhoHRsshY3Q95YVgX5CgRkaLrBUxtaO5giz0aj7cABrwl8WFxXO nChhMxNhejIqMc8ILkkWALjhs4fWFemfmQpT9v8kFSLvopt1u7/tTPUH7YuRcidnh/w8aWuNu7V vkbF9r08gLLaclBAsmRFLHarPZhUYEbszEv59jKld16t+p9GCXLmFLzWE6/ORwVUYWDGFn+7wLD udIzAq/MLPgJMr/Y8WE9TgsM83KU2pcr1e0A= X-Received: by 2002:a05:622a:b:b0:50e:487a:bfef with SMTP id d75a77b69052e-51a60d5ecfamr25152951cf.2.1782287240959; Wed, 24 Jun 2026 00:47:20 -0700 (PDT) X-Received: by 2002:a05:622a:b:b0:50e:487a:bfef with SMTP id d75a77b69052e-51a60d5ecfamr25152801cf.2.1782287240551; Wed, 24 Jun 2026 00:47:20 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e498cf8sm603381966b.13.2026.06.24.00.47.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 00:47:19 -0700 (PDT) Message-ID: <4fe3e01e-93f7-4832-b93e-d006c644b3ce@oss.qualcomm.com> Date: Wed, 24 Jun 2026 09:47:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qup: Propagate clock enable failures To: Pengpeng Hou , Andi Shyti Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260624055237.29977-1-pengpeng@iscas.ac.cn> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260624055237.29977-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=X8Bi7mTe c=1 sm=1 tr=0 ts=6a3b8b89 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=_6zfsGPuifU0wGZyNaAA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: vq-9GgaKroO8D1BtmiRyuDBzQb8InBa7 X-Proofpoint-ORIG-GUID: vq-9GgaKroO8D1BtmiRyuDBzQb8InBa7 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA2MyBTYWx0ZWRfXxziEKyoYQCzd jNit4dtyHYJONzohdAlgLgUQPrYN/HSzJ74F9xlFUonY2Rcfr+YQQgAAYz4t25AjZo8aKoLUdxn xHWk/XBtoT4/eKE+PpsqJXLjIQ8n1w8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA2MyBTYWx0ZWRfX3GqWsr+ogxHV pbwPl7UN42MVNSrKAlWQznE/Npy54J1ySliXKWRegc5S6kWQkupn/zvVU31Fzyr36sj+HquSV5k 5VyzXW5raEuoqTw2pPNIv5R41UFqQAvRljD//DyPL60+KqxQfBKP+epQUnBsGLslJJ6+UXqGHdq w15ZQtFdJqTQPdxnP+JMdcLntcvNW5wUmX9RRsKOyaSkv0wfWdT/u6CmKdi0sfVqdrdQELjdlxk SLZEDV2aAky8xv+CJkGlegr0BAe+g7p01/XfktdDsjJWD6GEgKyJFTLGn3I9sQrQfx/BLwjfLMA f+u+Xrc3Gjr6vBpVSW9XsjVdmaOKUHpfbFY/GNO4boFgotnag6dfVT1rVYUACB5znxNTPCW4PoP 89RWbIpK+uDc0o//ekPGxt/pM7d1fu0Mgojqm/8Dd4jbKY9hTl2YPn7VhikQeh+7fU9xPx6MFtn uCtKWAh1AGkkvb4YMDQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240063 On 6/24/26 7:52 AM, Pengpeng Hou wrote: > The QUP I2C driver treats the core and iface clocks as required > resources, but qup_i2c_enable_clocks() ignores clk_prepare_enable() > failures. Probe can then continue to register the I2C adapter, and > runtime/system resume can return success, even when a required clock > transition failed. > > Make the helper return an error, unwind a partially enabled clock, and > propagate failures from probe and resume paths. > > Signed-off-by: Pengpeng Hou > --- Reviewed-by: Konrad Dybcio Konrad